You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/11/14 10:29:44 UTC

[GitHub] spark pull request #23033: [SPARK-26036][PYTHON] Break large tests.py files ...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/23033

    [SPARK-26036][PYTHON] Break large tests.py files into smaller files

    ## What changes were proposed in this pull request?
    
    This PR continues to break down a big large file into smaller files. See https://github.com/apache/spark/pull/23021. It targets to follow https://github.com/numpy/numpy/tree/master/numpy.
    
    Basically this PR proposes to break down `pyspark/tests.py` into ...:
    
    ```
    pyspark
    ...
    ├── testing
    ...
    │   └── utils.py
    ├── tests
    │   ├── __init__.py
    │   ├── test_appsubmit.py
    │   ├── test_broadcast.py
    │   ├── test_conf.py
    │   ├── test_context.py
    │   ├── test_daemon.py
    │   ├── test_join.py
    │   ├── test_profiler.py
    │   ├── test_rdd.py
    │   ├── test_readwrite.py
    │   ├── test_serializers.py
    │   ├── test_shuffle.py
    │   ├── test_taskcontext.py
    │   ├── test_util.py
    │   └── test_worker.py
    ...
    ```
    
    
    ## How was this patch tested?
    
    Existing tests should cover.
    
    `cd python` and .`/run-tests-with-coverage`. Manually checked they are actually being ran.
    
    Each test (not officially) can be ran via:
    
    ```bash
    SPARK_TESTING=1 ./bin/pyspark pyspark.tests.test_context
    ```
    
    Note that if you're using Mac and Python 3, you might have to `OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-26036

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23033
    
----
commit 08cb59eeda3fd3b1042013f72f6fc45ea1146bd1
Author: hyukjinkwon <gu...@...>
Date:   2018-11-14T10:16:13Z

    Break large tests.py files into smaller files

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    **[Test build #98821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98821/testReport)** for PR 23033 at commit [`08cb59e`](https://github.com/apache/spark/commit/08cb59eeda3fd3b1042013f72f6fc45ea1146bd1).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    **[Test build #98823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98823/testReport)** for PR 23033 at commit [`ad9159a`](https://github.com/apache/spark/commit/ad9159a25517239ff713f42afc05fdb9fc204b7d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98828/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    **[Test build #98845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98845/testReport)** for PR 23033 at commit [`79bb522`](https://github.com/apache/spark/commit/79bb5225c6dc7633aa19c18c32f0555b4b0af1ae).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98845/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5021/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5023/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Yup will do.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    **[Test build #98828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98828/testReport)** for PR 23033 at commit [`1fe6b88`](https://github.com/apache/spark/commit/1fe6b883d989d1d27edcba75a2d2ae430063e616).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    @BryanCutler, looks we should add `pyspark.ml.tests` at https://github.com/apache/spark/blob/master/python/run-tests.py#L252-L253 so that we can run unittests first over doc tests (because arguably unittests take longer then doctests).
    
    I think it's missed when `ml/tests.py` was added. For instance, the latest above took it took few minutes longer then usual because the ml tests ran at the last.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    **[Test build #98845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98845/testReport)** for PR 23033 at commit [`79bb522`](https://github.com/apache/spark/commit/79bb5225c6dc7633aa19c18c32f0555b4b0af1ae).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    I am merging this for the same reason with #23021. Let me know if there's any concern even after this got merged.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98823/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23033: [SPARK-26036][PYTHON] Break large tests.py files into sm...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23033
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org