You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2016/04/11 23:34:58 UTC
Review Request 46052: Provide backward compatibility for kdc_host in
krb5-conf for krb5.conf templates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46052/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and Sumit Mohanty.
Bugs: AMBARI-15805
https://issues.apache.org/jira/browse/AMBARI-15805
Repository: ambari
Description
-------
Provide backward compatibility for `kdc_host` in `krb5-conf` for `krb5.conf` templates.
This is necessary in the event the `krb5.conf` template is not updated during the Ambari 2.4.0 upgrade while the `kdc_host` property is renamed to `kdc-hosts`.
Diffs
-----
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py d57b2a1
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 0c52e73
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py aab01ad
Diff: https://reviews.apache.org/r/46052/diff/
Testing
-------
Manually tested
# Local test result: PASSED
```
$ python -m unittest test_kerberos_client
.........
----------------------------------------------------------------------
Ran 9 tests in 0.112s
OK
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 46052: Provide backward compatibility for kdc_host
in krb5-conf for krb5.conf templates
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46052/#review128437
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On April 12, 2016, 12:24 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46052/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 12:24 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15805
> https://issues.apache.org/jira/browse/AMBARI-15805
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide backward compatibility for `kdc_host` in `krb5-conf` for `krb5.conf` templates.
>
> This is necessary in the event the `krb5.conf` template is not updated during the Ambari 2.4.0 upgrade while the `kdc_host` property is renamed to `kdc-hosts`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py d57b2a1
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 0c52e73
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py aab01ad
>
> Diff: https://reviews.apache.org/r/46052/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test result: PASSED
>
> ```
> $ python -m unittest test_kerberos_client
> .........
> ----------------------------------------------------------------------
> Ran 9 tests in 0.112s
>
> OK
> ```
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:53 min
> [INFO] Finished at: 2016-04-12T03:52:28+00:00
> [INFO] Final Memory: 166M/479M
> [INFO] ------------------------------------------------------------------------
>
> {color:green}+1 overall{color}. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12798105/AMBARI-15805_trunk_01.patch
> against trunk revision .
>
> {color:green}+1 @author{color}. The patch does not contain any @author tags.
>
> {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
>
> {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
>
> {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
>
> {color:green}+1 core tests{color}. The patch passed unit tests in ambari-server.
>
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46052: Provide backward compatibility for kdc_host
in krb5-conf for krb5.conf templates
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46052/#review128431
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 12, 2016, 8:24 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46052/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:24 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15805
> https://issues.apache.org/jira/browse/AMBARI-15805
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide backward compatibility for `kdc_host` in `krb5-conf` for `krb5.conf` templates.
>
> This is necessary in the event the `krb5.conf` template is not updated during the Ambari 2.4.0 upgrade while the `kdc_host` property is renamed to `kdc-hosts`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py d57b2a1
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 0c52e73
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py aab01ad
>
> Diff: https://reviews.apache.org/r/46052/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test result: PASSED
>
> ```
> $ python -m unittest test_kerberos_client
> .........
> ----------------------------------------------------------------------
> Ran 9 tests in 0.112s
>
> OK
> ```
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:53 min
> [INFO] Finished at: 2016-04-12T03:52:28+00:00
> [INFO] Final Memory: 166M/479M
> [INFO] ------------------------------------------------------------------------
>
> {color:green}+1 overall{color}. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12798105/AMBARI-15805_trunk_01.patch
> against trunk revision .
>
> {color:green}+1 @author{color}. The patch does not contain any @author tags.
>
> {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
>
> {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
>
> {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
>
> {color:green}+1 core tests{color}. The patch passed unit tests in ambari-server.
>
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46052: Provide backward compatibility for kdc_host
in krb5-conf for krb5.conf templates
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46052/#review128379
-----------------------------------------------------------
Ship it!
- Jonathan Hurley
On April 12, 2016, 8:24 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46052/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:24 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15805
> https://issues.apache.org/jira/browse/AMBARI-15805
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide backward compatibility for `kdc_host` in `krb5-conf` for `krb5.conf` templates.
>
> This is necessary in the event the `krb5.conf` template is not updated during the Ambari 2.4.0 upgrade while the `kdc_host` property is renamed to `kdc-hosts`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py d57b2a1
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 0c52e73
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py aab01ad
>
> Diff: https://reviews.apache.org/r/46052/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test result: PASSED
>
> ```
> $ python -m unittest test_kerberos_client
> .........
> ----------------------------------------------------------------------
> Ran 9 tests in 0.112s
>
> OK
> ```
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:53 min
> [INFO] Finished at: 2016-04-12T03:52:28+00:00
> [INFO] Final Memory: 166M/479M
> [INFO] ------------------------------------------------------------------------
>
> {color:green}+1 overall{color}. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12798105/AMBARI-15805_trunk_01.patch
> against trunk revision .
>
> {color:green}+1 @author{color}. The patch does not contain any @author tags.
>
> {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
>
> {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
>
> {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
>
> {color:green}+1 core tests{color}. The patch passed unit tests in ambari-server.
>
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46052: Provide backward compatibility for kdc_host
in krb5-conf for krb5.conf templates
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46052/
-----------------------------------------------------------
(Updated April 12, 2016, 8:24 a.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and Sumit Mohanty.
Bugs: AMBARI-15805
https://issues.apache.org/jira/browse/AMBARI-15805
Repository: ambari
Description
-------
Provide backward compatibility for `kdc_host` in `krb5-conf` for `krb5.conf` templates.
This is necessary in the event the `krb5.conf` template is not updated during the Ambari 2.4.0 upgrade while the `kdc_host` property is renamed to `kdc-hosts`.
Diffs
-----
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py d57b2a1
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 0c52e73
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py aab01ad
Diff: https://reviews.apache.org/r/46052/diff/
Testing (updated)
-------
Manually tested
# Local test result: PASSED
```
$ python -m unittest test_kerberos_client
.........
----------------------------------------------------------------------
Ran 9 tests in 0.112s
OK
```
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:53 min
[INFO] Finished at: 2016-04-12T03:52:28+00:00
[INFO] Final Memory: 166M/479M
[INFO] ------------------------------------------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12798105/AMBARI-15805_trunk_01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in ambari-server.
Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console
Thanks,
Robert Levas