You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/05/10 16:50:18 UTC
[GitHub] [fluo-muchos] karthick-rn opened a new pull request #394: Add support for multiple VMSS on Azure
karthick-rn opened a new pull request #394:
URL: https://github.com/apache/fluo-muchos/pull/394
This PR is part2 of the change described in #392
Just for the record, this feature has been tested against the following settings:
- HA/non-HA
- ADLS Gen2
- Azure proxy host
Additionally, removed reference to the author name in the python code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #394: Add support for multiple VMSS on Azure
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #394:
URL: https://github.com/apache/fluo-muchos/pull/394#discussion_r629679047
##########
File path: conf/.gitignore
##########
@@ -2,3 +2,5 @@
/hosts/*
/keys
/user_data
+/azure_vmss_to_hosts.txt
Review comment:
Sure, I have renamed the runtime generated file from `.txt` to `.conf` & updating the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn merged pull request #394: Add support for multiple VMSS on Azure
Posted by GitBox <gi...@apache.org>.
karthick-rn merged pull request #394:
URL: https://github.com/apache/fluo-muchos/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #394: Add support for multiple VMSS on Azure
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #394:
URL: https://github.com/apache/fluo-muchos/pull/394#discussion_r629646811
##########
File path: conf/.gitignore
##########
@@ -2,3 +2,5 @@
/hosts/*
/keys
/user_data
+/azure_vmss_to_hosts.txt
Review comment:
`.txt` here seems to imply this is some sort of documentation. So, it's especially weird if the documentation is ignored. However, since it's a config file, is there a better naming convention that can be used? `.conf`, perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org