You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Juraj Burian (JIRA)" <ji...@codehaus.org> on 2005/10/03 13:28:09 UTC
[jira] Created: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
--------------------------------------------------------------------------------------------------------------
Key: MNG-1076
URL: http://jira.codehaus.org/browse/MNG-1076
Project: Maven 2
Type: Bug
Components: maven-eclipse-plugin
Versions: 2.0-beta-2
Reporter: Juraj Burian
Priority: Minor
Fix For: 2.0-beta-3
Attachments: src.patch
Let:
<dependency>
<groupId>java</groupId>
<artifactId>tools</artifactId>
<version>1.5.03</version>
<systemPath>${java.home}/../lib/tools.jar</systemPath>
<scope>system</scope>
</dependency>
Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
I have patch for you, see attached file.
best regards
J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=comments#action_48740 ]
John Casey commented on MNG-1076:
---------------------------------
Well, the approach will work. However, a cleaner approach is to use the artifact.getScope() method to determine whether to treat the dependency as an external library or not. I've got this implemented, and will commit soon.
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Assignee: John Casey
> Priority: Minor
> Attachments: maven-eclipse-plugin.patch, maven-eclipse-plugin.path, src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=all ]
John Casey closed MNG-1076:
---------------------------
Resolution: Fixed
tested, and it works by detecting scope = 'system' and using an external library reference in this case.
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Assignee: John Casey
> Priority: Minor
> Attachments: maven-eclipse-plugin.patch, maven-eclipse-plugin.path, src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "Juraj Burian (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=all ]
Juraj Burian updated MNG-1076:
------------------------------
Attachment: maven-eclipse-plugin.path
updated formating & merged
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Priority: Minor
> Fix For: 2.0-beta-4
> Attachments: maven-eclipse-plugin.path, src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=all ]
Brett Porter updated MNG-1076:
------------------------------
Fix Version: (was: 2.0-beta-3)
2.0-beta-4
deferring so an eclipse user can review the patch. thanks for this.
At the least, need to correct exception handling and formatting
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Priority: Minor
> Fix For: 2.0-beta-4
> Attachments: src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "Juraj Burian (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=all ]
Juraj Burian updated MNG-1076:
------------------------------
Attachment: maven-eclipse-plugin.patch
updated to current state
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Assignee: John Casey
> Priority: Minor
> Attachments: maven-eclipse-plugin.patch, maven-eclipse-plugin.path, src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1076) incorrect classpath entry is generated when dependency has system and is absolute
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1076?page=all ]
Brett Porter updated MNG-1076:
------------------------------
Assign To: John Casey
Fix Version: (was: 2.0-beta-4)
John, please review this patch
> incorrect classpath entry is generated when dependency has <scope>system</scope> and <systemPath/> is absolute
> --------------------------------------------------------------------------------------------------------------
>
> Key: MNG-1076
> URL: http://jira.codehaus.org/browse/MNG-1076
> Project: Maven 2
> Type: Bug
> Components: maven-eclipse-plugin
> Versions: 2.0-beta-2
> Reporter: Juraj Burian
> Assignee: John Casey
> Priority: Minor
> Attachments: maven-eclipse-plugin.path, src.patch
>
>
> Let:
> <dependency>
> <groupId>java</groupId>
> <artifactId>tools</artifactId>
> <version>1.5.03</version>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <scope>system</scope>
> </dependency>
> Generated classpathentry is: <classpathentry kind="var" path="M2_REPO/..."/>
> By my opinion correct classpathentry looks like: <classpathentry kind="lib" path="C:\Java\jdk1.5.0_03\lib\tools.jar"/> if <systemPath/> is absolute.
> I have patch for you, see attached file.
> best regards
> J.Burian
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org