You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2015/03/26 04:16:14 UTC
[GitHub] spark pull request: [Minor][SQL] Minor changes
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/5199
[Minor][SQL] Minor changes
Couple of minor changes for SQL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark tiny_code_change2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5199
----
commit 84d15d50693fbea35c11963484ef8cd798e7bd55
Author: Cheng Hao <ha...@intel.com>
Date: 2015-03-26T03:01:21Z
minor changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86355111
[Test build #29210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29210/consoleFull) for PR 5199 at commit [`645b9be`](https://github.com/apache/spark/commit/645b9bee819501e7aec8d2ae1b29812a857d9fde).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-91973190
Thank you @marmbrus , @srowen it was part of Multi-way Join, but since we are not going to implement that, I am tend to close this for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86355134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29210/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86340581
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29203/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86340564
[Test build #29203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29203/consoleFull) for PR 5199 at commit [`84d15d5`](https://github.com/apache/spark/commit/84d15d50693fbea35c11963484ef8cd798e7bd55).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86337114
[Test build #29210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29210/consoleFull) for PR 5199 at commit [`645b9be`](https://github.com/apache/spark/commit/645b9bee819501e7aec8d2ae1b29812a857d9fde).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5199#discussion_r27209161
--- Diff: core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala ---
@@ -152,6 +152,20 @@ private[spark] class CompactBuffer[T: ClassTag] extends Seq[T] with Serializable
}
private[spark] object CompactBuffer {
+ def constantEmpty[T: ClassTag](): CompactBuffer[T] = new CompactBuffer[T] {
+ override def apply(position: Int): T =
+ sys.error("apply() is not valid for a constant empty buffer")
--- End diff --
Can this throw `UnsupportedOperationException` instead? this makes a bald `RuntimeException` which is slightly poor form to throw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/5199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5199#discussion_r28199545
--- Diff: core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala ---
@@ -152,6 +152,20 @@ private[spark] class CompactBuffer[T: ClassTag] extends Seq[T] with Serializable
}
private[spark] object CompactBuffer {
+ def constantEmpty[T: ClassTag](): CompactBuffer[T] = new CompactBuffer[T] {
--- End diff --
Is this really worth creating a new class for? Creating new subclasses can actually affect how JIT is going to inline things so might end up degrading performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor][SQL] Minor changes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5199#issuecomment-86321699
[Test build #29203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29203/consoleFull) for PR 5199 at commit [`84d15d5`](https://github.com/apache/spark/commit/84d15d50693fbea35c11963484ef8cd798e7bd55).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org