You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/28 10:18:51 UTC

[GitHub] Myasuka opened a new pull request #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options

Myasuka opened a new pull request #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options
URL: https://github.com/apache/flink/pull/7586
 
 
   ## What is the purpose of the change
   
   Enable to configure RocksDB's `DBOptions` and `ColumnFamilyOptions` through `flink-conf.yaml`.
   1. Introduce option `state.backend.rocksdb.predefined-options`, so that the `PredefinedOptions` could be configured through `flink-conf.yaml`.
   1. Introduce a bunch of customized options within `RocksDBCustomizedOptions` to cover current `PredefinedOptions` and support to configure them through `flink-conf.yaml`.
   1. Support to configure options programmatically to override options defined through `flink-conf.yaml`.
   1. Keep backward compatibility for current solution of `PredefinedOptions`  and `OptionsFactory`. Old user code would control RocksDB as before without any impacts from `RocksDBCustomizedOptions` introduced.
   
   
   ## Brief change log
   
     - Introduce option `state.backend.rocksdb.predefined-options` within `RocksDBOptions`.
     - Introduce new class `RocksDBCustomizedOptions` with a bunch of customized options.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Added test validating that `RocksDBCustomizedOptions` could be well parsed or created.
     - Added test validating that a RocksDB option would be finally controlled according to the priority of `OptionsFactory` --> `RocksDBCustomizedOptions` --> `PredefinedOptions`.
    - Added test validating that programmatically configured options could override options defined through `flink-conf.yaml`.
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes, `RocksDBStateBackend` is not annotated with `@Public` but is visible for users. 
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services