You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Joe Stein <cr...@gmail.com> on 2012/06/14 20:42:26 UTC
[VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Hello,
This is the second candidate for the second incubator release for Apache
Kafka, version 0.7.1-incubating.
This release fixes the following issues
http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
RC2 fixes the issue identified in RC1 =>
https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
to 2012
*** Please download, test and vote by Monday June, 18th, 12pm PDT
Release artifacts:
http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
The tag to be voted upon (off the 0.7.1 branch):
https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
Kafka's KEYS file containing PGP keys we use to sign the release:
http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
+1
Ran quick start, unit tests and rat tests.
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 21, 2012, at 12:35 PM, Kevan Miller wrote:
> I think Alan's (Kafka's) position is that dependencies don't matter since they are not distributing binary artifacts.
Dependencies do matter and they need to be checked. IMO, that point is non-negotiable.
The point that I'm trying to make is that the *documentation* of these dependencies in the LICENSE and NOTICE is what is vague in the "rules". The previous Kafka release did no such documentation and I'm certain other projects have done this as well.
With that said, I am of the same opinion as you, Kevan, and think that they should be documented in LICENSE and NOTICE. However, I don't think that it should hold up this release.
> I would agree with Alan, if Kafka source was simply intended to be used in source form. That's not the case. The Kafka project is designed to be built/compiled into a distribution. So, IMO, Kafka must document their dependencies. Note that if Kafka only had compile-time/test-time dependencies and simply built .jar files (and someone else was responsible for bundling everything together into a "distribution"), then I'd have a different opinion.
>
> In this case, the Kafka source release contains AL v2 licensed source code along with some binary artifacts under several licenses (you're welcome to comment on this, also). The Kafka LICENSE/NOTICE files only contain the licenses for this source code and the binary artifacts contained within the source release. They don't document the dependencies that they will bundle into a distribution.
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 6:33 PM, Marvin Humphrey wrote:
> On Thu, Jun 21, 2012 at 12:35 PM, Kevan Miller <ke...@gmail.com> wrote:
>>> If a project has a gazillion dependencies, regardless of whether those
>>> dependencies are direct or transitive, that makes dealing with licensing more
>>> challenging, but it doesn't change our legal obligations.
>>
>> I think you and I agree. Though there may be some ambiguities in what we
>> mean by direct or transitive dependencies.
>
> By "direct dependency", I meant a dependency where our code uses the
> dependency's API directly. By "transitive dependency", I meant "a dependency
> of a dependency":
>
> if A depends on B and B depends on C then A depends on C
>
> ... and thus C is a "transitive" dependency of A.
>
> I guess this "transitive dependency" terminology is a Maven thing.
>
> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Transitive_Dependencies
Yes. This is how I would define transitive dependencies. I wasn't sure why you raised the direct/transitive dependency issue, in the first place. And wanted to be sure we were on the same page (given the binary dependencies in the source).
>
>> So, attempting to clarify:
>>
>> I think Alan's (Kafka's) position is that dependencies don't matter since
>> they are not distributing binary artifacts.
>>
>> I would agree with Alan, if Kafka source was simply intended to be used in
>> source form. That's not the case. The Kafka project is designed to be
>> built/compiled into a distribution. So, IMO, Kafka must document their
>> dependencies. Note that if Kafka only had compile-time/test-time
>> dependencies and simply built .jar files (and someone else was responsible
>> for bundling everything together into a "distribution"), then I'd have a
>> different opinion.
>
> OK, that's what I was missing. :)
>
> If Kafka is indeed intended for use as an application/end-product, then it
> seems appropriate to document the licensing of unbundled dependencies -- but
> not legally mandatory since those bits aren't in the release artifacts.
>
> As someone who's not involved in Kafka, I don't feel it's my role to make the
> policy call as to whether the additional licensing info really ought to be
> there.
My perspective, in 0.7.0 vote, Kafka put up source and binaries for a release vote. Issues were raised with their LICENSE/NOTICE files (same ones being raised now). They believe they fixed the issue by moving to a source-only release. Nothing else changed. This is bogus.
>
>> In this case, the Kafka source release contains AL v2 licensed source code
>> along with some binary artifacts under several licenses (you're welcome to
>> comment on this, also).
>
> /ASF Member hat on
>
> I agree with Roy that the ASF releases only source code, and that therefore
> binary files such as jars do not belong in our canonical source releases.
>
> The one TLP that I follow closely where this has been an issue with past
> releases has changed its way of doing things. I hope that other TLPs have
> made similar adaptations.
>
> /ASF Member hat off, IPMC Member hat on
>
> At the least, I don't think a podling ought to graduate if their releases
> contain binary artifacts. Problematic past practices of TLPs should not serve
> as precedents for podlings.
>
> /IPMC Member hat off
>
> As to whether this particular release should be blocked because there are jars
> in the "source" archive, I think it probably should, though I'm not planning
> to get involved in the VOTE.
That's fine. I cast my vote. The IPMC can decide. My main issue is that the Kafka community has not done anything to fix their licensing issues. Alan seems to agree that they need to be fixed and wants to address in the next release -- that's good.
>
> I'm sympathetic that Kafka drew the short straw before and got whipsawed
> during their first incubating release over NOTICE disagreements. (What was it
> -- 9, 10 release candidates?) However, I'm not how much flexibility we have
> with regards to the issue at hand.
I'm really not interested in reviewing the old vote threads. IMO, the podling brought some of this on themselves by trying to avoid the issue. Contrast with Airavata. Looks like they addressed their issues and seem to be in good shape. I may be missing something basic, but that's my perspective...
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 21, 2012, at 3:33 PM, Marvin Humphrey wrote:
>> So, attempting to clarify:
>>
>> I think Alan's (Kafka's) position is that dependencies don't matter since
>> they are not distributing binary artifacts.
>>
>> I would agree with Alan, if Kafka source was simply intended to be used in
>> source form. That's not the case. The Kafka project is designed to be
>> built/compiled into a distribution. So, IMO, Kafka must document their
>> dependencies. Note that if Kafka only had compile-time/test-time
>> dependencies and simply built .jar files (and someone else was responsible
>> for bundling everything together into a "distribution"), then I'd have a
>> different opinion.
>
> OK, that's what I was missing. :)
>
> If Kafka is indeed intended for use as an application/end-product, then it
> seems appropriate to document the licensing of unbundled dependencies -- but
> not legally mandatory since those bits aren't in the release artifacts.
>
> As someone who's not involved in Kafka, I don't feel it's my role to make the
> policy call as to whether the additional licensing info really ought to be
> there.
Agreed, it should be in there, not must be in there. If others feel differently then they are free to ratify a new rule about this. Piggy backing refinements in policy on top of votes is, IMO, one the biggest frustrations podlings have with the Incubator.
>> In this case, the Kafka source release contains AL v2 licensed source code
>> along with some binary artifacts under several licenses (you're welcome to
>> comment on this, also).
>
> /ASF Member hat on
>
> I agree with Roy that the ASF releases only source code, and that therefore
> binary files such as jars do not belong in our canonical source releases.
>
> The one TLP that I follow closely where this has been an issue with past
> releases has changed its way of doing things. I hope that other TLPs have
> made similar adaptations.
>
> /ASF Member hat off, IPMC Member hat on
/ASF Member hat on :)
It's my understanding that there are other graduated projects that distribute jars w/ their source code.
With that said, the statement " jars do not belong in our canonical source releases" strikes as an aesthetic statement. Sometimes, it's required because of the way the project build system is organized.
/ASF Member hat off, IPMC Member hat on :)
>
> At the least, I don't think a podling ought to graduate if their releases
> contain binary artifacts. Problematic past practices of TLPs should not serve
> as precedents for podlings.
Oh, but past practices are used to justify all sorts of things here at ASF. If there is no concrete rule prohibiting it. If you and Kevan feel strongly about it I invite you to join the project and update it yourselves. This is, of course, open source. ;)
> /IPMC Member hat off
>
> As to whether this particular release should be blocked because there are jars
> in the "source" archive, I think it probably should, though I'm not planning
> to get involved in the VOTE.
>
> I'm sympathetic that Kafka drew the short straw before and got whipsawed
> during their first incubating release over NOTICE disagreements. (What was it
> -- 9, 10 release candidates?) However, I'm not how much flexibility we have
> with regards to the issue at hand.
I think that it warrants saying again, piggy backing refinements in policy on top of votes is, IMO, one the biggest frustrations podlings have with the Incubator.
If you feel strongly about a refinement then start and manage its ratification on general@i.a.o or members@a.o *on its own separate thread*.
If you feel strongly about how a project's build is organized, roll up your sleeves and join in on the fun.
Regards,
Alan
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Thu, Jun 21, 2012 at 12:35 PM, Kevan Miller <ke...@gmail.com> wrote:
>> If a project has a gazillion dependencies, regardless of whether those
>> dependencies are direct or transitive, that makes dealing with licensing more
>> challenging, but it doesn't change our legal obligations.
>
> I think you and I agree. Though there may be some ambiguities in what we
> mean by direct or transitive dependencies.
By "direct dependency", I meant a dependency where our code uses the
dependency's API directly. By "transitive dependency", I meant "a dependency
of a dependency":
if A depends on B and B depends on C then A depends on C
... and thus C is a "transitive" dependency of A.
I guess this "transitive dependency" terminology is a Maven thing.
http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Transitive_Dependencies
> So, attempting to clarify:
>
> I think Alan's (Kafka's) position is that dependencies don't matter since
> they are not distributing binary artifacts.
>
> I would agree with Alan, if Kafka source was simply intended to be used in
> source form. That's not the case. The Kafka project is designed to be
> built/compiled into a distribution. So, IMO, Kafka must document their
> dependencies. Note that if Kafka only had compile-time/test-time
> dependencies and simply built .jar files (and someone else was responsible
> for bundling everything together into a "distribution"), then I'd have a
> different opinion.
OK, that's what I was missing. :)
If Kafka is indeed intended for use as an application/end-product, then it
seems appropriate to document the licensing of unbundled dependencies -- but
not legally mandatory since those bits aren't in the release artifacts.
As someone who's not involved in Kafka, I don't feel it's my role to make the
policy call as to whether the additional licensing info really ought to be
there.
> In this case, the Kafka source release contains AL v2 licensed source code
> along with some binary artifacts under several licenses (you're welcome to
> comment on this, also).
/ASF Member hat on
I agree with Roy that the ASF releases only source code, and that therefore
binary files such as jars do not belong in our canonical source releases.
The one TLP that I follow closely where this has been an issue with past
releases has changed its way of doing things. I hope that other TLPs have
made similar adaptations.
/ASF Member hat off, IPMC Member hat on
At the least, I don't think a podling ought to graduate if their releases
contain binary artifacts. Problematic past practices of TLPs should not serve
as precedents for podlings.
/IPMC Member hat off
As to whether this particular release should be blocked because there are jars
in the "source" archive, I think it probably should, though I'm not planning
to get involved in the VOTE.
I'm sympathetic that Kafka drew the short straw before and got whipsawed
during their first incubating release over NOTICE disagreements. (What was it
-- 9, 10 release candidates?) However, I'm not how much flexibility we have
with regards to the issue at hand.
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Suresh Marru <sm...@apache.org>.
On Jun 22, 2012, at 12:00 PM, Kevan Miller wrote:
>
> On Jun 21, 2012, at 10:44 PM, Alan D. Cabrera wrote:
>
>> +1
>>
>> If this is going to be a new hard requirement the people who feel strongly about this should add something to Rat or write some kind of a plugin.
>
> Check out the recent 0.3 Airavata release. I didn't review it, until just now. However, from what I can see, they have a large number of dependencies and, IMO, have done an excellent job of documenting their LICENSE/NOTICE. Scanning the list, it looks like licensing issues were raised on their 0.2 release. From what I can see, the community responded to the issues and fixed them -- excellent job Airavata!
Yes in Airavata we have fairly large transitive dependencies (112 jars) and it took us a while, but thanks to our mentor Ate Douma's persistence we now have the binary distribution L&N files right. An automatic tool would have been nice, but what we found was for some of the non-apache jars you really have to go to the websites and find the files. If Kafka's needs help in verifying the requirements for next release I will be happy to help. FYI, here are Airavata L&N files [1] [2
Suresh
[1] - https://svn.apache.org/repos/asf/incubator/airavata/trunk/modules/distribution/src/main/resources/LICENSE
[2] - https://svn.apache.org/repos/asf/incubator/airavata/trunk/modules/distribution/src/main/resources/NOTICE
>
> --kevan
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 10:44 PM, Alan D. Cabrera wrote:
> +1
>
> If this is going to be a new hard requirement the people who feel strongly about this should add something to Rat or write some kind of a plugin.
Check out the recent 0.3 Airavata release. I didn't review it, until just now. However, from what I can see, they have a large number of dependencies and, IMO, have done an excellent job of documenting their LICENSE/NOTICE. Scanning the list, it looks like licensing issues were raised on their 0.2 release. From what I can see, the community responded to the issues and fixed them -- excellent job Airavata!
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
+1
If this is going to be a new hard requirement the people who feel strongly about this should add something to Rat or write some kind of a plugin.
Regards,
Alan
On Jun 21, 2012, at 5:29 PM, Jun Rao wrote:
> Kevan,
>
> I agree that to the benefit of users, it would be reasonable for Apache
> projects to include license/notice for all dependant jars (directly or
> indirectly) in a release. However, this has to be done automatically by
> tools, not manually by human beings. IMO, without such tools, it's unfair
> (and error prone) to make this a requirement for all Apache projects.
>
> Thanks,
>
> Jun
>
> On Thu, Jun 21, 2012 at 12:35 PM, Kevan Miller <ke...@gmail.com>wrote:
>
>>
>> On Jun 21, 2012, at 1:50 PM, Marvin Humphrey wrote:
>>
>>> On Thu, Jun 21, 2012 at 6:15 AM, Kevan Miller <ke...@gmail.com>
>> wrote:
>>>> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>>>
>>>>> With that said, I think it's something good and extremely useful to
>> strive
>>>>> for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE
>> with
>>>>> regards to transitive dependencies, is not a showstopper IMO unless
>> there
>>>>> are explicit rules prohibiting it on the ASF rules.
>>>>
>>>> I don't have a chapter and verse to quote you. I'll work on
>> getting/creating
>>>> some clarification. I may not be able to start on that for the next few
>>>> days...
>>>
>>> I feel like I'm missing something. There shouldn't be any difference
>> between
>>> a first-order dependency and a transitive dependency. All that matters
>> is
>>> whether or not the dependency is bundled, right?[1] Why would we need
>> ASF
>>> rules regarding *transitive* dependency license documentation in
>> particular?
>>
>> Because Alan and I disagreed and nobody else had commented? ;-)
>>
>>>
>>> So long as we bundle the bits, we have to bundle the licensing --
>> possibly
>>> bubbling up any relevant ALv2 NOTICE provisions into the top-level NOTICE
>>> since that's what the ALv2 requires. On the other hand, if the bits
>> aren't
>>> bundled, then the licensing shouldn't be bundled either.
>>>
>>> If the bundled dependencies of the canonical ASF source release and a
>>> convenience binary differ, then their licensing must be analyzed
>> separately
>>> and may differ.
>>>
>>> If a project has a gazillion dependencies, regardless of whether those
>>> dependencies are direct or transitive, that makes dealing with licensing
>> more
>>> challenging, but it doesn't change our legal obligations.
>>
>> I think you and I agree. Though there may be some ambiguities in what we
>> mean by direct or transitive dependencies. So, attempting to clarify:
>>
>> I think Alan's (Kafka's) position is that dependencies don't matter since
>> they are not distributing binary artifacts.
>>
>> I would agree with Alan, if Kafka source was simply intended to be used in
>> source form. That's not the case. The Kafka project is designed to be
>> built/compiled into a distribution. So, IMO, Kafka must document their
>> dependencies. Note that if Kafka only had compile-time/test-time
>> dependencies and simply built .jar files (and someone else was responsible
>> for bundling everything together into a "distribution"), then I'd have a
>> different opinion.
>>
>> In this case, the Kafka source release contains AL v2 licensed source code
>> along with some binary artifacts under several licenses (you're welcome to
>> comment on this, also). The Kafka LICENSE/NOTICE files only contain the
>> licenses for this source code and the binary artifacts contained within the
>> source release. They don't document the dependencies that they will bundle
>> into a distribution.
>>
>> --kevan
>>
>>>
>>> Marvin Humphrey
>>>
>>> [1] Leaving aside concerns about copyleft, field of use restrictions,
>> etc.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by sebb <se...@gmail.com>.
On 22 June 2012 01:29, Jun Rao <ju...@gmail.com> wrote:
> Kevan,
>
> I agree that to the benefit of users, it would be reasonable for Apache
> projects to include license/notice for all dependant jars (directly or
> indirectly) in a release. However, this has to be done automatically by
> tools, not manually by human beings. IMO, without such tools, it's unfair
> (and error prone) to make this a requirement for all Apache projects.
Note that the N&L files only apply to the jars that are actually
included in a release.
So any automated solution needs to take account of whether the
dependency is actually present or not.
In fact dependencies are irrelevant here - what counts is presence in
the release.
One reason the N&L files must agree with their contents is so the
end-user knows what they are getting.
It's important to provide full disclosure of the terms of all the
components of the release.
> Thanks,
>
> Jun
>
> On Thu, Jun 21, 2012 at 12:35 PM, Kevan Miller <ke...@gmail.com>wrote:
>
>>
>> On Jun 21, 2012, at 1:50 PM, Marvin Humphrey wrote:
>>
>> > On Thu, Jun 21, 2012 at 6:15 AM, Kevan Miller <ke...@gmail.com>
>> wrote:
>> >> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>> >
>> >>> With that said, I think it's something good and extremely useful to
>> strive
>> >>> for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE
>> with
>> >>> regards to transitive dependencies, is not a showstopper IMO unless
>> there
>> >>> are explicit rules prohibiting it on the ASF rules.
>> >>
>> >> I don't have a chapter and verse to quote you. I'll work on
>> getting/creating
>> >> some clarification. I may not be able to start on that for the next few
>> >> days...
>> >
>> > I feel like I'm missing something. There shouldn't be any difference
>> between
>> > a first-order dependency and a transitive dependency. All that matters
>> is
>> > whether or not the dependency is bundled, right?[1] Why would we need
>> ASF
>> > rules regarding *transitive* dependency license documentation in
>> particular?
>>
>> Because Alan and I disagreed and nobody else had commented? ;-)
>>
>> >
>> > So long as we bundle the bits, we have to bundle the licensing --
>> possibly
>> > bubbling up any relevant ALv2 NOTICE provisions into the top-level NOTICE
>> > since that's what the ALv2 requires. On the other hand, if the bits
>> aren't
>> > bundled, then the licensing shouldn't be bundled either.
>> >
>> > If the bundled dependencies of the canonical ASF source release and a
>> > convenience binary differ, then their licensing must be analyzed
>> separately
>> > and may differ.
>> >
>> > If a project has a gazillion dependencies, regardless of whether those
>> > dependencies are direct or transitive, that makes dealing with licensing
>> more
>> > challenging, but it doesn't change our legal obligations.
>>
>> I think you and I agree. Though there may be some ambiguities in what we
>> mean by direct or transitive dependencies. So, attempting to clarify:
>>
>> I think Alan's (Kafka's) position is that dependencies don't matter since
>> they are not distributing binary artifacts.
>>
>> I would agree with Alan, if Kafka source was simply intended to be used in
>> source form. That's not the case. The Kafka project is designed to be
>> built/compiled into a distribution. So, IMO, Kafka must document their
>> dependencies. Note that if Kafka only had compile-time/test-time
>> dependencies and simply built .jar files (and someone else was responsible
>> for bundling everything together into a "distribution"), then I'd have a
>> different opinion.
>>
>> In this case, the Kafka source release contains AL v2 licensed source code
>> along with some binary artifacts under several licenses (you're welcome to
>> comment on this, also). The Kafka LICENSE/NOTICE files only contain the
>> licenses for this source code and the binary artifacts contained within the
>> source release. They don't document the dependencies that they will bundle
>> into a distribution.
>>
>> --kevan
>>
>> >
>> > Marvin Humphrey
>> >
>> > [1] Leaving aside concerns about copyleft, field of use restrictions,
>> etc.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 22, 2012, at 7:05 AM, Kevan Miller wrote:
>
> On Jun 21, 2012, at 10:46 PM, Alan D. Cabrera wrote:
>
>>
>> On Jun 21, 2012, at 5:45 PM, Chris Douglas wrote:
>>
>>> On Thu, Jun 21, 2012 at 5:42 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
>>>> Obeying dependency license provisions is not an ASF policy, it's a legal
>>>> requirement. Fairness is immaterial.
>>>>
>>>> If you bundle the bits, you must deal with the licensing and you must get it
>>>> right.
>>>
>>> Sure, but that's not an issue here. The legal requirements are
>>> satisfied, as was established at length during the Kafka 0.7.0
>>> release. -C
>>
>> This reflects my sentiments as well.
>
> Alan,
> That seems to be at odds with your previous email(s) on this thread. IIUC, I think you're more of the mind that the legal requirements are not being met, but should be fixed in the next release, not this one.
As I think I mentioned in other emails. I am all for *vetting* the dependencies to make sure that they follow licensing provisions and are compatible with ASF policy. This *must* be done before *any* release.
What I claim can be put on hold until the next release is the extensive documentation of those dependencies in the LICENSE/NOTICE that you seem to be proposing.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 10:46 PM, Alan D. Cabrera wrote:
>
> On Jun 21, 2012, at 5:45 PM, Chris Douglas wrote:
>
>> On Thu, Jun 21, 2012 at 5:42 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
>>> Obeying dependency license provisions is not an ASF policy, it's a legal
>>> requirement. Fairness is immaterial.
>>>
>>> If you bundle the bits, you must deal with the licensing and you must get it
>>> right.
>>
>> Sure, but that's not an issue here. The legal requirements are
>> satisfied, as was established at length during the Kafka 0.7.0
>> release. -C
>
> This reflects my sentiments as well.
Alan,
That seems to be at odds with your previous email(s) on this thread. IIUC, I think you're more of the mind that the legal requirements are not being met, but should be fixed in the next release, not this one.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 21, 2012, at 5:45 PM, Chris Douglas wrote:
> On Thu, Jun 21, 2012 at 5:42 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
>> Obeying dependency license provisions is not an ASF policy, it's a legal
>> requirement. Fairness is immaterial.
>>
>> If you bundle the bits, you must deal with the licensing and you must get it
>> right.
>
> Sure, but that's not an issue here. The legal requirements are
> satisfied, as was established at length during the Kafka 0.7.0
> release. -C
This reflects my sentiments as well.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Chris Douglas <cd...@apache.org>.
On Thu, Jun 21, 2012 at 5:42 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
> Obeying dependency license provisions is not an ASF policy, it's a legal
> requirement. Fairness is immaterial.
>
> If you bundle the bits, you must deal with the licensing and you must get it
> right.
Sure, but that's not an issue here. The legal requirements are
satisfied, as was established at length during the Kafka 0.7.0
release. -C
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 8:42 PM, Marvin Humphrey wrote:
> Hi, Jun,
>
> On Thu, Jun 21, 2012 at 5:29 PM, Jun Rao <ju...@gmail.com> wrote:
>> I agree that to the benefit of users, it would be reasonable for Apache
>> projects to include license/notice for all dependant jars (directly or
>> indirectly) in a release. However, this has to be done automatically by
>> tools, not manually by human beings. IMO, without such tools, it's unfair
>> (and error prone) to make this a requirement for all Apache projects.
>
> Obeying dependency license provisions is not an ASF policy, it's a legal
> requirement. Fairness is immaterial.
>
> If you bundle the bits, you must deal with the licensing and you must get it
> right.
Totally agree.
Jun
It would be nice to have tools which automatically handle/assist in building LICENSE/NOTICE info. In my experience, they don't exist, yet. If anyone might be interested in working on such a tool -- that'd be great.
With or without the tool, each project is required to comply with their licensing requirements.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Marvin Humphrey <ma...@rectangular.com>.
Hi, Jun,
On Thu, Jun 21, 2012 at 5:29 PM, Jun Rao <ju...@gmail.com> wrote:
> I agree that to the benefit of users, it would be reasonable for Apache
> projects to include license/notice for all dependant jars (directly or
> indirectly) in a release. However, this has to be done automatically by
> tools, not manually by human beings. IMO, without such tools, it's unfair
> (and error prone) to make this a requirement for all Apache projects.
Obeying dependency license provisions is not an ASF policy, it's a legal
requirement. Fairness is immaterial.
If you bundle the bits, you must deal with the licensing and you must get it
right.
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Kevan,
I agree that to the benefit of users, it would be reasonable for Apache
projects to include license/notice for all dependant jars (directly or
indirectly) in a release. However, this has to be done automatically by
tools, not manually by human beings. IMO, without such tools, it's unfair
(and error prone) to make this a requirement for all Apache projects.
Thanks,
Jun
On Thu, Jun 21, 2012 at 12:35 PM, Kevan Miller <ke...@gmail.com>wrote:
>
> On Jun 21, 2012, at 1:50 PM, Marvin Humphrey wrote:
>
> > On Thu, Jun 21, 2012 at 6:15 AM, Kevan Miller <ke...@gmail.com>
> wrote:
> >> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
> >
> >>> With that said, I think it's something good and extremely useful to
> strive
> >>> for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE
> with
> >>> regards to transitive dependencies, is not a showstopper IMO unless
> there
> >>> are explicit rules prohibiting it on the ASF rules.
> >>
> >> I don't have a chapter and verse to quote you. I'll work on
> getting/creating
> >> some clarification. I may not be able to start on that for the next few
> >> days...
> >
> > I feel like I'm missing something. There shouldn't be any difference
> between
> > a first-order dependency and a transitive dependency. All that matters
> is
> > whether or not the dependency is bundled, right?[1] Why would we need
> ASF
> > rules regarding *transitive* dependency license documentation in
> particular?
>
> Because Alan and I disagreed and nobody else had commented? ;-)
>
> >
> > So long as we bundle the bits, we have to bundle the licensing --
> possibly
> > bubbling up any relevant ALv2 NOTICE provisions into the top-level NOTICE
> > since that's what the ALv2 requires. On the other hand, if the bits
> aren't
> > bundled, then the licensing shouldn't be bundled either.
> >
> > If the bundled dependencies of the canonical ASF source release and a
> > convenience binary differ, then their licensing must be analyzed
> separately
> > and may differ.
> >
> > If a project has a gazillion dependencies, regardless of whether those
> > dependencies are direct or transitive, that makes dealing with licensing
> more
> > challenging, but it doesn't change our legal obligations.
>
> I think you and I agree. Though there may be some ambiguities in what we
> mean by direct or transitive dependencies. So, attempting to clarify:
>
> I think Alan's (Kafka's) position is that dependencies don't matter since
> they are not distributing binary artifacts.
>
> I would agree with Alan, if Kafka source was simply intended to be used in
> source form. That's not the case. The Kafka project is designed to be
> built/compiled into a distribution. So, IMO, Kafka must document their
> dependencies. Note that if Kafka only had compile-time/test-time
> dependencies and simply built .jar files (and someone else was responsible
> for bundling everything together into a "distribution"), then I'd have a
> different opinion.
>
> In this case, the Kafka source release contains AL v2 licensed source code
> along with some binary artifacts under several licenses (you're welcome to
> comment on this, also). The Kafka LICENSE/NOTICE files only contain the
> licenses for this source code and the binary artifacts contained within the
> source release. They don't document the dependencies that they will bundle
> into a distribution.
>
> --kevan
>
> >
> > Marvin Humphrey
> >
> > [1] Leaving aside concerns about copyleft, field of use restrictions,
> etc.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 1:50 PM, Marvin Humphrey wrote:
> On Thu, Jun 21, 2012 at 6:15 AM, Kevan Miller <ke...@gmail.com> wrote:
>> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>
>>> With that said, I think it's something good and extremely useful to strive
>>> for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE with
>>> regards to transitive dependencies, is not a showstopper IMO unless there
>>> are explicit rules prohibiting it on the ASF rules.
>>
>> I don't have a chapter and verse to quote you. I'll work on getting/creating
>> some clarification. I may not be able to start on that for the next few
>> days...
>
> I feel like I'm missing something. There shouldn't be any difference between
> a first-order dependency and a transitive dependency. All that matters is
> whether or not the dependency is bundled, right?[1] Why would we need ASF
> rules regarding *transitive* dependency license documentation in particular?
Because Alan and I disagreed and nobody else had commented? ;-)
>
> So long as we bundle the bits, we have to bundle the licensing -- possibly
> bubbling up any relevant ALv2 NOTICE provisions into the top-level NOTICE
> since that's what the ALv2 requires. On the other hand, if the bits aren't
> bundled, then the licensing shouldn't be bundled either.
>
> If the bundled dependencies of the canonical ASF source release and a
> convenience binary differ, then their licensing must be analyzed separately
> and may differ.
>
> If a project has a gazillion dependencies, regardless of whether those
> dependencies are direct or transitive, that makes dealing with licensing more
> challenging, but it doesn't change our legal obligations.
I think you and I agree. Though there may be some ambiguities in what we mean by direct or transitive dependencies. So, attempting to clarify:
I think Alan's (Kafka's) position is that dependencies don't matter since they are not distributing binary artifacts.
I would agree with Alan, if Kafka source was simply intended to be used in source form. That's not the case. The Kafka project is designed to be built/compiled into a distribution. So, IMO, Kafka must document their dependencies. Note that if Kafka only had compile-time/test-time dependencies and simply built .jar files (and someone else was responsible for bundling everything together into a "distribution"), then I'd have a different opinion.
In this case, the Kafka source release contains AL v2 licensed source code along with some binary artifacts under several licenses (you're welcome to comment on this, also). The Kafka LICENSE/NOTICE files only contain the licenses for this source code and the binary artifacts contained within the source release. They don't document the dependencies that they will bundle into a distribution.
--kevan
>
> Marvin Humphrey
>
> [1] Leaving aside concerns about copyleft, field of use restrictions, etc.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Thu, Jun 21, 2012 at 6:15 AM, Kevan Miller <ke...@gmail.com> wrote:
> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>> With that said, I think it's something good and extremely useful to strive
>> for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE with
>> regards to transitive dependencies, is not a showstopper IMO unless there
>> are explicit rules prohibiting it on the ASF rules.
>
> I don't have a chapter and verse to quote you. I'll work on getting/creating
> some clarification. I may not be able to start on that for the next few
> days...
I feel like I'm missing something. There shouldn't be any difference between
a first-order dependency and a transitive dependency. All that matters is
whether or not the dependency is bundled, right?[1] Why would we need ASF
rules regarding *transitive* dependency license documentation in particular?
So long as we bundle the bits, we have to bundle the licensing -- possibly
bubbling up any relevant ALv2 NOTICE provisions into the top-level NOTICE
since that's what the ALv2 requires. On the other hand, if the bits aren't
bundled, then the licensing shouldn't be bundled either.
If the bundled dependencies of the canonical ASF source release and a
convenience binary differ, then their licensing must be analyzed separately
and may differ.
If a project has a gazillion dependencies, regardless of whether those
dependencies are direct or transitive, that makes dealing with licensing more
challenging, but it doesn't change our legal obligations.
Marvin Humphrey
[1] Leaving aside concerns about copyleft, field of use restrictions, etc.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 21, 2012, at 6:15 AM, Kevan Miller wrote:
>
> On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>
>>
>> On Jun 19, 2012, at 8:13 AM, Kevan Miller wrote:
>>
>>>
>>> On Jun 18, 2012, at 9:51 PM, Jun Rao wrote:
>>>
>>>> Kevin,
>>>>
>>>> Thanks for the comments. Just want to clarify on your points on
>>>> LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
>>>> not those pulled in during building. We had a long discussion during our
>>>> 1st release and in the end, we have reached the conclusion that we don't
>>>> have to document LICENSE/NOTICE for jars not included in the source (since
>>>> we are just doing a source release). Please correct me if you think this is
>>>> blocking the release. We have to include a small number of jars in the
>>>> source because there is no easy way to pull them in automatically.
>>>
>>> Hi Jun,
>>> Well, IMO, a source-only release does not free you from your responsibilities of creating/reviewing the licensing of what your build produces.
>>>
>>> Would it be ok if your source-only release builds binaries with artifacts that are not open source or an approved open source license? How am I expected to review your release if you can't/haven't documented your LICENSE/NOTICE files?
>>>
>>> Your users will expect to build Kafka (not simply use Kafka source). IMO, you have a responsibility/requirement to document the licensing of Kafka, not just the portions of Kafka (i.e. Kafka source code) that you choose to document.
>>
>> There's precedent for not doing this, e.g. the previous release of Kafka and I am certain other ASF releases. Precedence has great weight.
>
> Licensing issues were raised with the last release of Kafka. A source-only release was created to avoid the issue -- a practice which is debatable, at very best, and I is IMO wrong. From an ASF perspective, all releases are source releases. In some instances, projects also create/distribute binary artifacts. So now, a new release is being created. Yet, no progress has been made to address the same licensing issues.
>
> I see your note in the current vote thread. That seems to be a good plan. I think we differ on what is required/optional and when that work should occur.
As I mentioned before, we didn't organize the LICENSE/NOTICE files in this manner before and I'm certain that other projects have not done it as well. The fact that it's a source release doesn't seem relevant to me. I could be missing something.
>> With that said, I think it's something good and extremely useful to strive for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE with regards to transitive dependencies, is not a showstopper IMO unless there are explicit rules prohibiting it on the ASF rules.
>
> I don't have a chapter and verse to quote you. I'll work on getting/creating some clarification. I may not be able to start on that for the next few days...
I checked, there don't seem to be any.
>> FWIW, what I did last time was hand review every single jar and make sure that it's AL 2.0 compatible; yes someone owes me a beer. I wish there was a rat target for sbt.
>
> Yep. This is something the PPMC should/must be doing. And we should be able to verify by comparing binary artifacts against LICENSE/NOTICE files.
Reviewing dependencies, yes. How LICENSE/NOTICE files are populated with regards to dependencies is your opinion; an opinion that I do share but don't feel it needs to hold up a release as long as the dependencies are reviewed.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 21, 2012, at 1:20 AM, Alan D. Cabrera wrote:
>
> On Jun 19, 2012, at 8:13 AM, Kevan Miller wrote:
>
>>
>> On Jun 18, 2012, at 9:51 PM, Jun Rao wrote:
>>
>>> Kevin,
>>>
>>> Thanks for the comments. Just want to clarify on your points on
>>> LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
>>> not those pulled in during building. We had a long discussion during our
>>> 1st release and in the end, we have reached the conclusion that we don't
>>> have to document LICENSE/NOTICE for jars not included in the source (since
>>> we are just doing a source release). Please correct me if you think this is
>>> blocking the release. We have to include a small number of jars in the
>>> source because there is no easy way to pull them in automatically.
>>
>> Hi Jun,
>> Well, IMO, a source-only release does not free you from your responsibilities of creating/reviewing the licensing of what your build produces.
>>
>> Would it be ok if your source-only release builds binaries with artifacts that are not open source or an approved open source license? How am I expected to review your release if you can't/haven't documented your LICENSE/NOTICE files?
>>
>> Your users will expect to build Kafka (not simply use Kafka source). IMO, you have a responsibility/requirement to document the licensing of Kafka, not just the portions of Kafka (i.e. Kafka source code) that you choose to document.
>
> There's precedent for not doing this, e.g. the previous release of Kafka and I am certain other ASF releases. Precedence has great weight.
Licensing issues were raised with the last release of Kafka. A source-only release was created to avoid the issue -- a practice which is debatable, at very best, and I is IMO wrong. From an ASF perspective, all releases are source releases. In some instances, projects also create/distribute binary artifacts. So now, a new release is being created. Yet, no progress has been made to address the same licensing issues.
I see your note in the current vote thread. That seems to be a good plan. I think we differ on what is required/optional and when that work should occur.
> With that said, I think it's something good and extremely useful to strive for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE with regards to transitive dependencies, is not a showstopper IMO unless there are explicit rules prohibiting it on the ASF rules.
I don't have a chapter and verse to quote you. I'll work on getting/creating some clarification. I may not be able to start on that for the next few days...
>
> FWIW, what I did last time was hand review every single jar and make sure that it's AL 2.0 compatible; yes someone owes me a beer. I wish there was a rat target for sbt.
Yep. This is something the PPMC should/must be doing. And we should be able to verify by comparing binary artifacts against LICENSE/NOTICE files.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
On Jun 19, 2012, at 8:13 AM, Kevan Miller wrote:
>
> On Jun 18, 2012, at 9:51 PM, Jun Rao wrote:
>
>> Kevin,
>>
>> Thanks for the comments. Just want to clarify on your points on
>> LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
>> not those pulled in during building. We had a long discussion during our
>> 1st release and in the end, we have reached the conclusion that we don't
>> have to document LICENSE/NOTICE for jars not included in the source (since
>> we are just doing a source release). Please correct me if you think this is
>> blocking the release. We have to include a small number of jars in the
>> source because there is no easy way to pull them in automatically.
>
> Hi Jun,
> Well, IMO, a source-only release does not free you from your responsibilities of creating/reviewing the licensing of what your build produces.
>
> Would it be ok if your source-only release builds binaries with artifacts that are not open source or an approved open source license? How am I expected to review your release if you can't/haven't documented your LICENSE/NOTICE files?
>
> Your users will expect to build Kafka (not simply use Kafka source). IMO, you have a responsibility/requirement to document the licensing of Kafka, not just the portions of Kafka (i.e. Kafka source code) that you choose to document.
There's precedent for not doing this, e.g. the previous release of Kafka and I am certain other ASF releases. Precedence has great weight. With that said, I think it's something good and extremely useful to strive for. The lack of it, i.e. extensive documentation in LICENSE/NOTICE with regards to transitive dependencies, is not a showstopper IMO unless there are explicit rules prohibiting it on the ASF rules.
FWIW, what I did last time was hand review every single jar and make sure that it's AL 2.0 compatible; yes someone owes me a beer. I wish there was a rat target for sbt.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 18, 2012, at 9:51 PM, Jun Rao wrote:
> Kevin,
>
> Thanks for the comments. Just want to clarify on your points on
> LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
> not those pulled in during building. We had a long discussion during our
> 1st release and in the end, we have reached the conclusion that we don't
> have to document LICENSE/NOTICE for jars not included in the source (since
> we are just doing a source release). Please correct me if you think this is
> blocking the release. We have to include a small number of jars in the
> source because there is no easy way to pull them in automatically.
Hi Jun,
Well, IMO, a source-only release does not free you from your responsibilities of creating/reviewing the licensing of what your build produces.
Would it be ok if your source-only release builds binaries with artifacts that are not open source or an approved open source license? How am I expected to review your release if you can't/haven't documented your LICENSE/NOTICE files?
Your users will expect to build Kafka (not simply use Kafka source). IMO, you have a responsibility/requirement to document the licensing of Kafka, not just the portions of Kafka (i.e. Kafka source code) that you choose to document.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Kevin,
Thanks for the comments. Just want to clarify on your points on
LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
not those pulled in during building. We had a long discussion during our
1st release and in the end, we have reached the conclusion that we don't
have to document LICENSE/NOTICE for jars not included in the source (since
we are just doing a source release). Please correct me if you think this is
blocking the release. We have to include a small number of jars in the
source because there is no easy way to pull them in automatically.
Thanks,
Jun
On Mon, Jun 18, 2012 at 1:53 PM, Kevan Miller <ke...@gmail.com>wrote:
> Things that I've noted:
>
> I don't see a checksum for your release in
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ --
> your release manager will need to generate a checksum for the release.
>
> It would be nice if your archive extracted into an
> apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> but that's minor.
>
> I see the following binary files in your source distribution:
>
> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-consumer/lib/piggybank.jar
> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-producer/lib/piggybank.jar
> ./lib/sbt-launch.jar
>
> If I understand correctly, this does not meet a definition of an open
> source release (which is what an apache release is…). It looks like this is
> how your last release was packaged, also… I don't know if this is a
> blocking issue (for an incubator release), but I think you need to work on
> resolving this (i.e. remove binaries from your source)…
>
> IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> built kafka and see that a number jars are pulled in… I have no idea what
> the LICENSING for these artifacts is… and whether or not they conform to
> ASF standards (I did not review them all). Your project needs to document
> them.
>
> FYI, I couldn't figure out from the documentation how to start a server
> after I built kafka.
>
> --kevan
>
> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>
> > Any other voters?
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This is the second candidate for the second incubator release for Apache
> >> Kafka, version 0.7.1-incubating.
> >>
> >> This release fixes the following issues
> >>
> >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >>
> >> RC2 fixes the issue identified in RC1 =>
> >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> >> to 2012
> >>
> >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >>
> >> Release artifacts:
> >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >>
> >> The tag to be voted upon (off the 0.7.1 branch):
> >>
> >>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >>
> >> Kafka's KEYS file containing PGP keys we use to sign the release:
> >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >>
> >> /*
> >> Joe Stein
> >> http://www.linkedin.com/in/charmalloc
> >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> >> */
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Kevin,
Thanks for the comments. Just want to clarify on your points on
LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source,
not those pulled in during building. We had a long discussion during our
1st release and in the end, we have reached the conclusion that we don't
have to document LICENSE/NOTICE for jars not included in the source (since
we are just doing a source release). Please correct me if you think this is
blocking the release. We have to include a small number of jars in the
source because there is no easy way to pull them in automatically.
Thanks,
Jun
On Mon, Jun 18, 2012 at 1:53 PM, Kevan Miller <ke...@gmail.com>wrote:
> Things that I've noted:
>
> I don't see a checksum for your release in
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ --
> your release manager will need to generate a checksum for the release.
>
> It would be nice if your archive extracted into an
> apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> but that's minor.
>
> I see the following binary files in your source distribution:
>
> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-consumer/lib/piggybank.jar
> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-producer/lib/piggybank.jar
> ./lib/sbt-launch.jar
>
> If I understand correctly, this does not meet a definition of an open
> source release (which is what an apache release is…). It looks like this is
> how your last release was packaged, also… I don't know if this is a
> blocking issue (for an incubator release), but I think you need to work on
> resolving this (i.e. remove binaries from your source)…
>
> IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> built kafka and see that a number jars are pulled in… I have no idea what
> the LICENSING for these artifacts is… and whether or not they conform to
> ASF standards (I did not review them all). Your project needs to document
> them.
>
> FYI, I couldn't figure out from the documentation how to start a server
> after I built kafka.
>
> --kevan
>
> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>
> > Any other voters?
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This is the second candidate for the second incubator release for Apache
> >> Kafka, version 0.7.1-incubating.
> >>
> >> This release fixes the following issues
> >>
> >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >>
> >> RC2 fixes the issue identified in RC1 =>
> >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> >> to 2012
> >>
> >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >>
> >> Release artifacts:
> >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >>
> >> The tag to be voted upon (off the 0.7.1 branch):
> >>
> >>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >>
> >> Kafka's KEYS file containing PGP keys we use to sign the release:
> >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >>
> >> /*
> >> Joe Stein
> >> http://www.linkedin.com/in/charmalloc
> >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> >> */
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2))
Posted by Joe Stein <cr...@gmail.com>.
Thanks, I will add the cleanup steps you have to what I was doing, good call. I should be able to roll RC3 later today/tonight.
On Jun 19, 2012, at 6:35 PM, Neha Narkhede <ne...@gmail.com> wrote:
> Joe,
>
> Here is the Kafka release process notes that I had written from the
> last release. Sorry that I couldn't formalize it into a wiki. Will do
> that soon -
>
> # checkout kafka trunk
> svn co https://svn.apache.org/repos/asf/incubator/kafka/trunk kafka
> cd kafka
> ./sbt update package test doc
>
> mkdir ~/kafka-0.7.0-incubating
> cp -r * ~/kafka-0.7.0-incubating
> cd ~/kafka-0.7.0-incubating
>
> # remove the .svn files
> find . -name ".svn" | xargs rm -rf
>
> # make sure the *.sh scripts have execute permissions
> find . -name "*sh" | xargs chmod ugoa+x
>
> # remove the .class files, except those in the project directory,
> since it is useful to run unit tests out of the box
> find . -name "*.class" | grep -v project | xargs rm
>
> # try rebuilding code
> ./sbt package
>
> # test it
> ./sbt test
>
> # copy the kafka jar to root
> cp core/target/scala_2.8.0/kafka-0.7.0.jar .
>
> # remove the .class files, except those in the project directory,
> since it is useful to run unit tests out of the box
> find . -name "*.class" | grep -v project | xargs rm
>
> # add the CHANGES.txt file
> Go to Apache JIRA and click on the version 0.7.
> (https://issues.apache.org/jira/browse/KAFKA/fixforversion/12317243)
> Click Release Notes
> Configure it to output text
> copy paste that to CHANGES.txt
>
> 2. quickstart
>
> # tar it
> tar cvf kafka-0.7.0-incubating-src.tar kafka-0.7.0-incubating-src/
> gzip kafka-0.7.0-incubating-src.tar
>
> # create a gpg key if you don't have one already
> http://www.webupd8.org/2010/01/how-to-create-your-own-gpg-key.html
>
> # if you are signing the release for the first time, add your key to
> the kafka/KEYS file
> gpg --list-sigs Neha Narkhede && gpg --armor --export Neha Narkhede >>
> ~/Projects/kafka-top-level/KEYS
> cd ~/Projects/kafka-top-level
> svn commit -m "Updating KEYS file with pgp key for Neha Narkhede"
>
> # sign the tarball
> gpg --armor --output kafka-0.7.0-incubating-src.tar.gz.asc
> --detach-sig kafka-0.7.0-incubating-src.tar.gz
> md5sum kafka-0.7.0-incubating-src.tar.gz > kafka-0.7.0-incubating-src.tar.gz.md5
>
> # add the html version of release notes
> vi RELEASE-NOTES.html
> Go to Apache JIRA and click on the version 0.7.
> (https://issues.apache.org/jira/browse/KAFKA/fixforversion/12317243)
> Click Release Notes
> Configure it to output html
> copy paste that to RELEASE-NOTES.html
> If the release includes new Features, include the following in the
> Release Notes -
>
> Let me know if you have questions.
>
> Thanks
> Neha
>
> On Tue, Jun 19, 2012 at 11:24 AM, Joe Stein <cr...@gmail.com> wrote:
>> ok, I uploaded a patch https://issues.apache.org/jira/browse/KAFKA-368 (not
>> receiving JIRA emails not sure if there is issue or not)
>>
>> anything else we want/need to-do (after this patch is reviewed
>> and committed) before rolling RC3 ?
>>
>> On Tue, Jun 19, 2012 at 12:08 PM, Jun Rao <ju...@gmail.com> wrote:
>>
>>> Joe,
>>>
>>> Perhaps we can just remove the pig-0.8.0.jar in the 0.7.1 release. We can
>>> sort out the remaining jars in 0.8.
>>>
>>> Thanks,
>>>
>>> Jun
>>>
>>> On Mon, Jun 18, 2012 at 10:22 PM, Joe Stein <cr...@gmail.com> wrote:
>>>
>>>> if the jars that are left are still an issue
>>>>
>>>> find ./branches/0.7.1/ -name *jar
>>>> ./branches/0.7.1//contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
>>>> ./branches/0.7.1//contrib/hadoop-consumer/lib/piggybank.jar
>>>> ./branches/0.7.1//contrib/hadoop-producer/lib/pig-0.8.0-core.jar
>>>> ./branches/0.7.1//contrib/hadoop-producer/lib/piggybank.jar
>>>> ./branches/0.7.1//lib/sbt-launch.jar
>>>>
>>>> pig-0.8.0-core.jar is in maven
>>>>
>>>> piggybank is not maven
>>>>
>>>> sbt-launch.jar we either have to leave in (since we have such an older
>>>> version) or proceed with
>>> https://issues.apache.org/jira/browse/KAFKA-134so
>>>> we can point people to the "latest" sbt since this is what we need to get
>>>> things rolling
>>>>
>>>> and then there is the nunit dll
>>>>
>>>> not sure if all or none are an issue or if the goal here is just to move
>>>> ping-0.8.0-core.jar out and into maven? want to keep this discussion
>>> moving
>>>> so we can come to an agreement for RC3
>>>>
>>>>
>>>>
>>>> On Mon, Jun 18, 2012 at 10:47 PM, Chris Burroughs <
>>>> chris.burroughs@gmail.com
>>>>> wrote:
>>>>
>>>>> My interpretation of the long "Binary dependencies in source releases"
>>>>> thread is that the build tools are (I think) defensible, but it really
>>>>> would be best if we could get rid of the rest.
>>>>>
>>>>> I see that Neha and Jacob already did most of the work last round in
>>>>> KAFKA-222 (go team!). In the comments pig is called out as a problem,
>>>>> but it looks like this is taken care of in PIG-1334. Any reason we
>>>>> can't mavenize those as well?
>>>>>
>>>>> I'm not sure what to do with DLLs.
>>>>>
>>>>>
>>>>>
>>>>> -------- Original Message --------
>>>>> Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
>>>>> Date: Mon, 18 Jun 2012 21:34:41 -0400
>>>>> From: Joe Stein <cr...@gmail.com>
>>>>> Reply-To: general@incubator.apache.org
>>>>> To: general@incubator.apache.org
>>>>> CC: kafka-dev@incubator.apache.org
>>>>>
>>>>> I uploaded a md5 checksum
>>>>>
>>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/to
>>>>> go along with the detached signature that was generated already
>>>>>
>>>>> starting the kafka server is in the quick start
>>>>> http://incubator.apache.org/kafka/quickstart.html
>>>>>
>>>>> looking at Cassandra and Hadoop source distributions both have jars in
>>>> them
>>>>> too, so not sure the issue you are raising others might have a better
>>>>> understanding or I am missing something you are trying to point out
>>>>>
>>>>> I would like to keep the RC2 voting open for another few days to see if
>>>>> this release passes (as folks have not had time to review) or we can
>>> get
>>>> to
>>>>> what issues we need to have resolved that can be done for RC3 for a new
>>>>> vote either with objective to getting 0.7.1 released.
>>>>>
>>>>> current votes:
>>>>>
>>>>> +1 [1] +0 [0] -1 [0] from the PPMC
>>>>>
>>>>> and
>>>>>
>>>>> +1 [0] +0 [0] -1 [0] from the IPMC
>>>>>
>>>>> please let me know if there is something different we want or should
>>> have
>>>>> been doing here or that I can be or should be doing differently.
>>>>>
>>>>> thanks!
>>>>>
>>>>> On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <kevan.miller@gmail.com
>>>>>> wrote:
>>>>>
>>>>>> Things that I've noted:
>>>>>>
>>>>>> I don't see a checksum for your release in
>>>>>>
>>>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/--
>>>>>> your release manager will need to generate a checksum for the
>>> release.
>>>>>>
>>>>>> It would be nice if your archive extracted into an
>>>>>> apache-kafka-0.7.1-incubating directory (or similar name rather than
>>>> .),
>>>>>> but that's minor.
>>>>>>
>>>>>> I see the following binary files in your source distribution:
>>>>>>
>>>>>> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
>>>>>> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
>>>>>> ./contrib/hadoop-consumer/lib/piggybank.jar
>>>>>> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
>>>>>> ./contrib/hadoop-producer/lib/piggybank.jar
>>>>>> ./lib/sbt-launch.jar
>>>>>>
>>>>>> If I understand correctly, this does not meet a definition of an open
>>>>>> source release (which is what an apache release is…). It looks like
>>>> this
>>>>> is
>>>>>> how your last release was packaged, also… I don't know if this is a
>>>>>> blocking issue (for an incubator release), but I think you need to
>>> work
>>>>> on
>>>>>> resolving this (i.e. remove binaries from your source)…
>>>>>>
>>>>>> IIUC, your LICENSE/NOTICE files are documenting your "source"
>>>> (including
>>>>>> the above jars). Do you document the LICENSE/NOTICE of your
>>> binaries? I
>>>>>> built kafka and see that a number jars are pulled in… I have no idea
>>>> what
>>>>>> the LICENSING for these artifacts is… and whether or not they conform
>>>> to
>>>>>> ASF standards (I did not review them all). Your project needs to
>>>> document
>>>>>> them.
>>>>>>
>>>>>> FYI, I couldn't figure out from the documentation how to start a
>>> server
>>>>>> after I built kafka.
>>>>>>
>>>>>> --kevan
>>>>>>
>>>>>> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>>>>>>
>>>>>>> Any other voters?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jun
>>>>>>>
>>>>>>> On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com>
>>>>> wrote:
>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> This is the second candidate for the second incubator release for
>>>>> Apache
>>>>>>>> Kafka, version 0.7.1-incubating.
>>>>>>>>
>>>>>>>> This release fixes the following issues
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>>
>>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>>>>>>>>
>>>>>>>> RC2 fixes the issue identified in RC1 =>
>>>>>>>> https://issues.apache.org/jira/browse/KAFKA-365 change copyright
>>> in
>>>>>> NOTICE
>>>>>>>> to 2012
>>>>>>>>
>>>>>>>> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>>>>>>>>
>>>>>>>> Release artifacts:
>>>>>>>>
>>>>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>>>>>>>>
>>>>>>>> The tag to be voted upon (off the 0.7.1 branch):
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>>>>>>>>
>>>>>>>> Kafka's KEYS file containing PGP keys we use to sign the release:
>>>>>>>> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>>>>>>>>
>>>>>>>> /*
>>>>>>>> Joe Stein
>>>>>>>> http://www.linkedin.com/in/charmalloc
>>>>>>>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop
>>>>
>>>>>>>> */
>>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> /*
>>>>> Joe Stein
>>>>> http://www.linkedin.com/in/charmalloc
>>>>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>>>>> */
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> /*
>>>> Joe Stein
>>>> http://www.linkedin.com/in/charmalloc
>>>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>>>> */
>>>>
>>>
>>
>>
>>
>> --
>>
>> /*
>> Joe Stein
>> http://www.linkedin.com/in/charmalloc
>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> */
Re: remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka
0.7.1-incubating (Candidate 2))
Posted by Neha Narkhede <ne...@gmail.com>.
Joe,
Here is the Kafka release process notes that I had written from the
last release. Sorry that I couldn't formalize it into a wiki. Will do
that soon -
# checkout kafka trunk
svn co https://svn.apache.org/repos/asf/incubator/kafka/trunk kafka
cd kafka
./sbt update package test doc
mkdir ~/kafka-0.7.0-incubating
cp -r * ~/kafka-0.7.0-incubating
cd ~/kafka-0.7.0-incubating
# remove the .svn files
find . -name ".svn" | xargs rm -rf
# make sure the *.sh scripts have execute permissions
find . -name "*sh" | xargs chmod ugoa+x
# remove the .class files, except those in the project directory,
since it is useful to run unit tests out of the box
find . -name "*.class" | grep -v project | xargs rm
# try rebuilding code
./sbt package
# test it
./sbt test
# copy the kafka jar to root
cp core/target/scala_2.8.0/kafka-0.7.0.jar .
# remove the .class files, except those in the project directory,
since it is useful to run unit tests out of the box
find . -name "*.class" | grep -v project | xargs rm
# add the CHANGES.txt file
Go to Apache JIRA and click on the version 0.7.
(https://issues.apache.org/jira/browse/KAFKA/fixforversion/12317243)
Click Release Notes
Configure it to output text
copy paste that to CHANGES.txt
2. quickstart
# tar it
tar cvf kafka-0.7.0-incubating-src.tar kafka-0.7.0-incubating-src/
gzip kafka-0.7.0-incubating-src.tar
# create a gpg key if you don't have one already
http://www.webupd8.org/2010/01/how-to-create-your-own-gpg-key.html
# if you are signing the release for the first time, add your key to
the kafka/KEYS file
gpg --list-sigs Neha Narkhede && gpg --armor --export Neha Narkhede >>
~/Projects/kafka-top-level/KEYS
cd ~/Projects/kafka-top-level
svn commit -m "Updating KEYS file with pgp key for Neha Narkhede"
# sign the tarball
gpg --armor --output kafka-0.7.0-incubating-src.tar.gz.asc
--detach-sig kafka-0.7.0-incubating-src.tar.gz
md5sum kafka-0.7.0-incubating-src.tar.gz > kafka-0.7.0-incubating-src.tar.gz.md5
# add the html version of release notes
vi RELEASE-NOTES.html
Go to Apache JIRA and click on the version 0.7.
(https://issues.apache.org/jira/browse/KAFKA/fixforversion/12317243)
Click Release Notes
Configure it to output html
copy paste that to RELEASE-NOTES.html
If the release includes new Features, include the following in the
Release Notes -
Let me know if you have questions.
Thanks
Neha
On Tue, Jun 19, 2012 at 11:24 AM, Joe Stein <cr...@gmail.com> wrote:
> ok, I uploaded a patch https://issues.apache.org/jira/browse/KAFKA-368 (not
> receiving JIRA emails not sure if there is issue or not)
>
> anything else we want/need to-do (after this patch is reviewed
> and committed) before rolling RC3 ?
>
> On Tue, Jun 19, 2012 at 12:08 PM, Jun Rao <ju...@gmail.com> wrote:
>
>> Joe,
>>
>> Perhaps we can just remove the pig-0.8.0.jar in the 0.7.1 release. We can
>> sort out the remaining jars in 0.8.
>>
>> Thanks,
>>
>> Jun
>>
>> On Mon, Jun 18, 2012 at 10:22 PM, Joe Stein <cr...@gmail.com> wrote:
>>
>> > if the jars that are left are still an issue
>> >
>> > find ./branches/0.7.1/ -name *jar
>> > ./branches/0.7.1//contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
>> > ./branches/0.7.1//contrib/hadoop-consumer/lib/piggybank.jar
>> > ./branches/0.7.1//contrib/hadoop-producer/lib/pig-0.8.0-core.jar
>> > ./branches/0.7.1//contrib/hadoop-producer/lib/piggybank.jar
>> > ./branches/0.7.1//lib/sbt-launch.jar
>> >
>> > pig-0.8.0-core.jar is in maven
>> >
>> > piggybank is not maven
>> >
>> > sbt-launch.jar we either have to leave in (since we have such an older
>> > version) or proceed with
>> https://issues.apache.org/jira/browse/KAFKA-134so
>> > we can point people to the "latest" sbt since this is what we need to get
>> > things rolling
>> >
>> > and then there is the nunit dll
>> >
>> > not sure if all or none are an issue or if the goal here is just to move
>> > ping-0.8.0-core.jar out and into maven? want to keep this discussion
>> moving
>> > so we can come to an agreement for RC3
>> >
>> >
>> >
>> > On Mon, Jun 18, 2012 at 10:47 PM, Chris Burroughs <
>> > chris.burroughs@gmail.com
>> > > wrote:
>> >
>> > > My interpretation of the long "Binary dependencies in source releases"
>> > > thread is that the build tools are (I think) defensible, but it really
>> > > would be best if we could get rid of the rest.
>> > >
>> > > I see that Neha and Jacob already did most of the work last round in
>> > > KAFKA-222 (go team!). In the comments pig is called out as a problem,
>> > > but it looks like this is taken care of in PIG-1334. Any reason we
>> > > can't mavenize those as well?
>> > >
>> > > I'm not sure what to do with DLLs.
>> > >
>> > >
>> > >
>> > > -------- Original Message --------
>> > > Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
>> > > Date: Mon, 18 Jun 2012 21:34:41 -0400
>> > > From: Joe Stein <cr...@gmail.com>
>> > > Reply-To: general@incubator.apache.org
>> > > To: general@incubator.apache.org
>> > > CC: kafka-dev@incubator.apache.org
>> > >
>> > > I uploaded a md5 checksum
>> > >
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/to
>> > > go along with the detached signature that was generated already
>> > >
>> > > starting the kafka server is in the quick start
>> > > http://incubator.apache.org/kafka/quickstart.html
>> > >
>> > > looking at Cassandra and Hadoop source distributions both have jars in
>> > them
>> > > too, so not sure the issue you are raising others might have a better
>> > > understanding or I am missing something you are trying to point out
>> > >
>> > > I would like to keep the RC2 voting open for another few days to see if
>> > > this release passes (as folks have not had time to review) or we can
>> get
>> > to
>> > > what issues we need to have resolved that can be done for RC3 for a new
>> > > vote either with objective to getting 0.7.1 released.
>> > >
>> > > current votes:
>> > >
>> > > +1 [1] +0 [0] -1 [0] from the PPMC
>> > >
>> > > and
>> > >
>> > > +1 [0] +0 [0] -1 [0] from the IPMC
>> > >
>> > > please let me know if there is something different we want or should
>> have
>> > > been doing here or that I can be or should be doing differently.
>> > >
>> > > thanks!
>> > >
>> > > On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <kevan.miller@gmail.com
>> > > >wrote:
>> > >
>> > > > Things that I've noted:
>> > > >
>> > > > I don't see a checksum for your release in
>> > > >
>> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/--
>> > > > your release manager will need to generate a checksum for the
>> release.
>> > > >
>> > > > It would be nice if your archive extracted into an
>> > > > apache-kafka-0.7.1-incubating directory (or similar name rather than
>> > .),
>> > > > but that's minor.
>> > > >
>> > > > I see the following binary files in your source distribution:
>> > > >
>> > > > ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
>> > > > ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
>> > > > ./contrib/hadoop-consumer/lib/piggybank.jar
>> > > > ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
>> > > > ./contrib/hadoop-producer/lib/piggybank.jar
>> > > > ./lib/sbt-launch.jar
>> > > >
>> > > > If I understand correctly, this does not meet a definition of an open
>> > > > source release (which is what an apache release is…). It looks like
>> > this
>> > > is
>> > > > how your last release was packaged, also… I don't know if this is a
>> > > > blocking issue (for an incubator release), but I think you need to
>> work
>> > > on
>> > > > resolving this (i.e. remove binaries from your source)…
>> > > >
>> > > > IIUC, your LICENSE/NOTICE files are documenting your "source"
>> > (including
>> > > > the above jars). Do you document the LICENSE/NOTICE of your
>> binaries? I
>> > > > built kafka and see that a number jars are pulled in… I have no idea
>> > what
>> > > > the LICENSING for these artifacts is… and whether or not they conform
>> > to
>> > > > ASF standards (I did not review them all). Your project needs to
>> > document
>> > > > them.
>> > > >
>> > > > FYI, I couldn't figure out from the documentation how to start a
>> server
>> > > > after I built kafka.
>> > > >
>> > > > --kevan
>> > > >
>> > > > On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>> > > >
>> > > > > Any other voters?
>> > > > >
>> > > > > Thanks,
>> > > > >
>> > > > > Jun
>> > > > >
>> > > > > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com>
>> > > wrote:
>> > > > >
>> > > > >> Hello,
>> > > > >>
>> > > > >> This is the second candidate for the second incubator release for
>> > > Apache
>> > > > >> Kafka, version 0.7.1-incubating.
>> > > > >>
>> > > > >> This release fixes the following issues
>> > > > >>
>> > > > >>
>> > > >
>> > >
>> >
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>> > > > >>
>> > > > >> RC2 fixes the issue identified in RC1 =>
>> > > > >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright
>> in
>> > > > NOTICE
>> > > > >> to 2012
>> > > > >>
>> > > > >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>> > > > >>
>> > > > >> Release artifacts:
>> > > > >>
>> > > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>> > > > >>
>> > > > >> The tag to be voted upon (off the 0.7.1 branch):
>> > > > >>
>> > > > >>
>> > > >
>> > >
>> >
>> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>> > > > >>
>> > > > >> Kafka's KEYS file containing PGP keys we use to sign the release:
>> > > > >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>> > > > >>
>> > > > >> /*
>> > > > >> Joe Stein
>> > > > >> http://www.linkedin.com/in/charmalloc
>> > > > >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop
>> >
>> > > > >> */
>> > > > >>
>> > > >
>> > > >
>> > > > ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > > > For additional commands, e-mail: general-help@incubator.apache.org
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > >
>> > > /*
>> > > Joe Stein
>> > > http://www.linkedin.com/in/charmalloc
>> > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> > > */
>> > >
>> > >
>> >
>> >
>> > --
>> >
>> > /*
>> > Joe Stein
>> > http://www.linkedin.com/in/charmalloc
>> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> > */
>> >
>>
>
>
>
> --
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
Re: remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka
0.7.1-incubating (Candidate 2))
Posted by Joe Stein <cr...@gmail.com>.
ok, I uploaded a patch https://issues.apache.org/jira/browse/KAFKA-368 (not
receiving JIRA emails not sure if there is issue or not)
anything else we want/need to-do (after this patch is reviewed
and committed) before rolling RC3 ?
On Tue, Jun 19, 2012 at 12:08 PM, Jun Rao <ju...@gmail.com> wrote:
> Joe,
>
> Perhaps we can just remove the pig-0.8.0.jar in the 0.7.1 release. We can
> sort out the remaining jars in 0.8.
>
> Thanks,
>
> Jun
>
> On Mon, Jun 18, 2012 at 10:22 PM, Joe Stein <cr...@gmail.com> wrote:
>
> > if the jars that are left are still an issue
> >
> > find ./branches/0.7.1/ -name *jar
> > ./branches/0.7.1//contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> > ./branches/0.7.1//contrib/hadoop-consumer/lib/piggybank.jar
> > ./branches/0.7.1//contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> > ./branches/0.7.1//contrib/hadoop-producer/lib/piggybank.jar
> > ./branches/0.7.1//lib/sbt-launch.jar
> >
> > pig-0.8.0-core.jar is in maven
> >
> > piggybank is not maven
> >
> > sbt-launch.jar we either have to leave in (since we have such an older
> > version) or proceed with
> https://issues.apache.org/jira/browse/KAFKA-134so
> > we can point people to the "latest" sbt since this is what we need to get
> > things rolling
> >
> > and then there is the nunit dll
> >
> > not sure if all or none are an issue or if the goal here is just to move
> > ping-0.8.0-core.jar out and into maven? want to keep this discussion
> moving
> > so we can come to an agreement for RC3
> >
> >
> >
> > On Mon, Jun 18, 2012 at 10:47 PM, Chris Burroughs <
> > chris.burroughs@gmail.com
> > > wrote:
> >
> > > My interpretation of the long "Binary dependencies in source releases"
> > > thread is that the build tools are (I think) defensible, but it really
> > > would be best if we could get rid of the rest.
> > >
> > > I see that Neha and Jacob already did most of the work last round in
> > > KAFKA-222 (go team!). In the comments pig is called out as a problem,
> > > but it looks like this is taken care of in PIG-1334. Any reason we
> > > can't mavenize those as well?
> > >
> > > I'm not sure what to do with DLLs.
> > >
> > >
> > >
> > > -------- Original Message --------
> > > Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
> > > Date: Mon, 18 Jun 2012 21:34:41 -0400
> > > From: Joe Stein <cr...@gmail.com>
> > > Reply-To: general@incubator.apache.org
> > > To: general@incubator.apache.org
> > > CC: kafka-dev@incubator.apache.org
> > >
> > > I uploaded a md5 checksum
> > >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/to
> > > go along with the detached signature that was generated already
> > >
> > > starting the kafka server is in the quick start
> > > http://incubator.apache.org/kafka/quickstart.html
> > >
> > > looking at Cassandra and Hadoop source distributions both have jars in
> > them
> > > too, so not sure the issue you are raising others might have a better
> > > understanding or I am missing something you are trying to point out
> > >
> > > I would like to keep the RC2 voting open for another few days to see if
> > > this release passes (as folks have not had time to review) or we can
> get
> > to
> > > what issues we need to have resolved that can be done for RC3 for a new
> > > vote either with objective to getting 0.7.1 released.
> > >
> > > current votes:
> > >
> > > +1 [1] +0 [0] -1 [0] from the PPMC
> > >
> > > and
> > >
> > > +1 [0] +0 [0] -1 [0] from the IPMC
> > >
> > > please let me know if there is something different we want or should
> have
> > > been doing here or that I can be or should be doing differently.
> > >
> > > thanks!
> > >
> > > On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <kevan.miller@gmail.com
> > > >wrote:
> > >
> > > > Things that I've noted:
> > > >
> > > > I don't see a checksum for your release in
> > > >
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/--
> > > > your release manager will need to generate a checksum for the
> release.
> > > >
> > > > It would be nice if your archive extracted into an
> > > > apache-kafka-0.7.1-incubating directory (or similar name rather than
> > .),
> > > > but that's minor.
> > > >
> > > > I see the following binary files in your source distribution:
> > > >
> > > > ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> > > > ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> > > > ./contrib/hadoop-consumer/lib/piggybank.jar
> > > > ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> > > > ./contrib/hadoop-producer/lib/piggybank.jar
> > > > ./lib/sbt-launch.jar
> > > >
> > > > If I understand correctly, this does not meet a definition of an open
> > > > source release (which is what an apache release is…). It looks like
> > this
> > > is
> > > > how your last release was packaged, also… I don't know if this is a
> > > > blocking issue (for an incubator release), but I think you need to
> work
> > > on
> > > > resolving this (i.e. remove binaries from your source)…
> > > >
> > > > IIUC, your LICENSE/NOTICE files are documenting your "source"
> > (including
> > > > the above jars). Do you document the LICENSE/NOTICE of your
> binaries? I
> > > > built kafka and see that a number jars are pulled in… I have no idea
> > what
> > > > the LICENSING for these artifacts is… and whether or not they conform
> > to
> > > > ASF standards (I did not review them all). Your project needs to
> > document
> > > > them.
> > > >
> > > > FYI, I couldn't figure out from the documentation how to start a
> server
> > > > after I built kafka.
> > > >
> > > > --kevan
> > > >
> > > > On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
> > > >
> > > > > Any other voters?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jun
> > > > >
> > > > > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com>
> > > wrote:
> > > > >
> > > > >> Hello,
> > > > >>
> > > > >> This is the second candidate for the second incubator release for
> > > Apache
> > > > >> Kafka, version 0.7.1-incubating.
> > > > >>
> > > > >> This release fixes the following issues
> > > > >>
> > > > >>
> > > >
> > >
> >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> > > > >>
> > > > >> RC2 fixes the issue identified in RC1 =>
> > > > >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright
> in
> > > > NOTICE
> > > > >> to 2012
> > > > >>
> > > > >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> > > > >>
> > > > >> Release artifacts:
> > > > >>
> > > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> > > > >>
> > > > >> The tag to be voted upon (off the 0.7.1 branch):
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> > > > >>
> > > > >> Kafka's KEYS file containing PGP keys we use to sign the release:
> > > > >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> > > > >>
> > > > >> /*
> > > > >> Joe Stein
> > > > >> http://www.linkedin.com/in/charmalloc
> > > > >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop
> >
> > > > >> */
> > > > >>
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > /*
> > > Joe Stein
> > > http://www.linkedin.com/in/charmalloc
> > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > > */
> > >
> > >
> >
> >
> > --
> >
> > /*
> > Joe Stein
> > http://www.linkedin.com/in/charmalloc
> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > */
> >
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Re: remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka
0.7.1-incubating (Candidate 2))
Posted by Jun Rao <ju...@gmail.com>.
Joe,
Perhaps we can just remove the pig-0.8.0.jar in the 0.7.1 release. We can
sort out the remaining jars in 0.8.
Thanks,
Jun
On Mon, Jun 18, 2012 at 10:22 PM, Joe Stein <cr...@gmail.com> wrote:
> if the jars that are left are still an issue
>
> find ./branches/0.7.1/ -name *jar
> ./branches/0.7.1//contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./branches/0.7.1//contrib/hadoop-consumer/lib/piggybank.jar
> ./branches/0.7.1//contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./branches/0.7.1//contrib/hadoop-producer/lib/piggybank.jar
> ./branches/0.7.1//lib/sbt-launch.jar
>
> pig-0.8.0-core.jar is in maven
>
> piggybank is not maven
>
> sbt-launch.jar we either have to leave in (since we have such an older
> version) or proceed with https://issues.apache.org/jira/browse/KAFKA-134so
> we can point people to the "latest" sbt since this is what we need to get
> things rolling
>
> and then there is the nunit dll
>
> not sure if all or none are an issue or if the goal here is just to move
> ping-0.8.0-core.jar out and into maven? want to keep this discussion moving
> so we can come to an agreement for RC3
>
>
>
> On Mon, Jun 18, 2012 at 10:47 PM, Chris Burroughs <
> chris.burroughs@gmail.com
> > wrote:
>
> > My interpretation of the long "Binary dependencies in source releases"
> > thread is that the build tools are (I think) defensible, but it really
> > would be best if we could get rid of the rest.
> >
> > I see that Neha and Jacob already did most of the work last round in
> > KAFKA-222 (go team!). In the comments pig is called out as a problem,
> > but it looks like this is taken care of in PIG-1334. Any reason we
> > can't mavenize those as well?
> >
> > I'm not sure what to do with DLLs.
> >
> >
> >
> > -------- Original Message --------
> > Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
> > Date: Mon, 18 Jun 2012 21:34:41 -0400
> > From: Joe Stein <cr...@gmail.com>
> > Reply-To: general@incubator.apache.org
> > To: general@incubator.apache.org
> > CC: kafka-dev@incubator.apache.org
> >
> > I uploaded a md5 checksum
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/to
> > go along with the detached signature that was generated already
> >
> > starting the kafka server is in the quick start
> > http://incubator.apache.org/kafka/quickstart.html
> >
> > looking at Cassandra and Hadoop source distributions both have jars in
> them
> > too, so not sure the issue you are raising others might have a better
> > understanding or I am missing something you are trying to point out
> >
> > I would like to keep the RC2 voting open for another few days to see if
> > this release passes (as folks have not had time to review) or we can get
> to
> > what issues we need to have resolved that can be done for RC3 for a new
> > vote either with objective to getting 0.7.1 released.
> >
> > current votes:
> >
> > +1 [1] +0 [0] -1 [0] from the PPMC
> >
> > and
> >
> > +1 [0] +0 [0] -1 [0] from the IPMC
> >
> > please let me know if there is something different we want or should have
> > been doing here or that I can be or should be doing differently.
> >
> > thanks!
> >
> > On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <kevan.miller@gmail.com
> > >wrote:
> >
> > > Things that I've noted:
> > >
> > > I don't see a checksum for your release in
> > >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/--
> > > your release manager will need to generate a checksum for the release.
> > >
> > > It would be nice if your archive extracted into an
> > > apache-kafka-0.7.1-incubating directory (or similar name rather than
> .),
> > > but that's minor.
> > >
> > > I see the following binary files in your source distribution:
> > >
> > > ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> > > ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> > > ./contrib/hadoop-consumer/lib/piggybank.jar
> > > ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> > > ./contrib/hadoop-producer/lib/piggybank.jar
> > > ./lib/sbt-launch.jar
> > >
> > > If I understand correctly, this does not meet a definition of an open
> > > source release (which is what an apache release is…). It looks like
> this
> > is
> > > how your last release was packaged, also… I don't know if this is a
> > > blocking issue (for an incubator release), but I think you need to work
> > on
> > > resolving this (i.e. remove binaries from your source)…
> > >
> > > IIUC, your LICENSE/NOTICE files are documenting your "source"
> (including
> > > the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> > > built kafka and see that a number jars are pulled in… I have no idea
> what
> > > the LICENSING for these artifacts is… and whether or not they conform
> to
> > > ASF standards (I did not review them all). Your project needs to
> document
> > > them.
> > >
> > > FYI, I couldn't figure out from the documentation how to start a server
> > > after I built kafka.
> > >
> > > --kevan
> > >
> > > On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
> > >
> > > > Any other voters?
> > > >
> > > > Thanks,
> > > >
> > > > Jun
> > > >
> > > > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com>
> > wrote:
> > > >
> > > >> Hello,
> > > >>
> > > >> This is the second candidate for the second incubator release for
> > Apache
> > > >> Kafka, version 0.7.1-incubating.
> > > >>
> > > >> This release fixes the following issues
> > > >>
> > > >>
> > >
> >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> > > >>
> > > >> RC2 fixes the issue identified in RC1 =>
> > > >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> > > NOTICE
> > > >> to 2012
> > > >>
> > > >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> > > >>
> > > >> Release artifacts:
> > > >>
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> > > >>
> > > >> The tag to be voted upon (off the 0.7.1 branch):
> > > >>
> > > >>
> > >
> >
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> > > >>
> > > >> Kafka's KEYS file containing PGP keys we use to sign the release:
> > > >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> > > >>
> > > >> /*
> > > >> Joe Stein
> > > >> http://www.linkedin.com/in/charmalloc
> > > >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > > >> */
> > > >>
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> >
> > /*
> > Joe Stein
> > http://www.linkedin.com/in/charmalloc
> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > */
> >
> >
>
>
> --
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka
0.7.1-incubating (Candidate 2))
Posted by Joe Stein <cr...@gmail.com>.
if the jars that are left are still an issue
find ./branches/0.7.1/ -name *jar
./branches/0.7.1//contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
./branches/0.7.1//contrib/hadoop-consumer/lib/piggybank.jar
./branches/0.7.1//contrib/hadoop-producer/lib/pig-0.8.0-core.jar
./branches/0.7.1//contrib/hadoop-producer/lib/piggybank.jar
./branches/0.7.1//lib/sbt-launch.jar
pig-0.8.0-core.jar is in maven
piggybank is not maven
sbt-launch.jar we either have to leave in (since we have such an older
version) or proceed with https://issues.apache.org/jira/browse/KAFKA-134 so
we can point people to the "latest" sbt since this is what we need to get
things rolling
and then there is the nunit dll
not sure if all or none are an issue or if the goal here is just to move
ping-0.8.0-core.jar out and into maven? want to keep this discussion moving
so we can come to an agreement for RC3
On Mon, Jun 18, 2012 at 10:47 PM, Chris Burroughs <chris.burroughs@gmail.com
> wrote:
> My interpretation of the long "Binary dependencies in source releases"
> thread is that the build tools are (I think) defensible, but it really
> would be best if we could get rid of the rest.
>
> I see that Neha and Jacob already did most of the work last round in
> KAFKA-222 (go team!). In the comments pig is called out as a problem,
> but it looks like this is taken care of in PIG-1334. Any reason we
> can't mavenize those as well?
>
> I'm not sure what to do with DLLs.
>
>
>
> -------- Original Message --------
> Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
> Date: Mon, 18 Jun 2012 21:34:41 -0400
> From: Joe Stein <cr...@gmail.com>
> Reply-To: general@incubator.apache.org
> To: general@incubator.apache.org
> CC: kafka-dev@incubator.apache.org
>
> I uploaded a md5 checksum
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ to
> go along with the detached signature that was generated already
>
> starting the kafka server is in the quick start
> http://incubator.apache.org/kafka/quickstart.html
>
> looking at Cassandra and Hadoop source distributions both have jars in them
> too, so not sure the issue you are raising others might have a better
> understanding or I am missing something you are trying to point out
>
> I would like to keep the RC2 voting open for another few days to see if
> this release passes (as folks have not had time to review) or we can get to
> what issues we need to have resolved that can be done for RC3 for a new
> vote either with objective to getting 0.7.1 released.
>
> current votes:
>
> +1 [1] +0 [0] -1 [0] from the PPMC
>
> and
>
> +1 [0] +0 [0] -1 [0] from the IPMC
>
> please let me know if there is something different we want or should have
> been doing here or that I can be or should be doing differently.
>
> thanks!
>
> On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <kevan.miller@gmail.com
> >wrote:
>
> > Things that I've noted:
> >
> > I don't see a checksum for your release in
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/--
> > your release manager will need to generate a checksum for the release.
> >
> > It would be nice if your archive extracted into an
> > apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> > but that's minor.
> >
> > I see the following binary files in your source distribution:
> >
> > ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> > ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> > ./contrib/hadoop-consumer/lib/piggybank.jar
> > ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> > ./contrib/hadoop-producer/lib/piggybank.jar
> > ./lib/sbt-launch.jar
> >
> > If I understand correctly, this does not meet a definition of an open
> > source release (which is what an apache release is…). It looks like this
> is
> > how your last release was packaged, also… I don't know if this is a
> > blocking issue (for an incubator release), but I think you need to work
> on
> > resolving this (i.e. remove binaries from your source)…
> >
> > IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> > the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> > built kafka and see that a number jars are pulled in… I have no idea what
> > the LICENSING for these artifacts is… and whether or not they conform to
> > ASF standards (I did not review them all). Your project needs to document
> > them.
> >
> > FYI, I couldn't figure out from the documentation how to start a server
> > after I built kafka.
> >
> > --kevan
> >
> > On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
> >
> > > Any other voters?
> > >
> > > Thanks,
> > >
> > > Jun
> > >
> > > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com>
> wrote:
> > >
> > >> Hello,
> > >>
> > >> This is the second candidate for the second incubator release for
> Apache
> > >> Kafka, version 0.7.1-incubating.
> > >>
> > >> This release fixes the following issues
> > >>
> > >>
> >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> > >>
> > >> RC2 fixes the issue identified in RC1 =>
> > >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> > NOTICE
> > >> to 2012
> > >>
> > >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> > >>
> > >> Release artifacts:
> > >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> > >>
> > >> The tag to be voted upon (off the 0.7.1 branch):
> > >>
> > >>
> >
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> > >>
> > >> Kafka's KEYS file containing PGP keys we use to sign the release:
> > >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> > >>
> > >> /*
> > >> Joe Stein
> > >> http://www.linkedin.com/in/charmalloc
> > >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > >> */
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
>
> --
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
remaining jars in svn (was Fwd: Re: [VOTE] Release Kafka 0.7.1-incubating
(Candidate 2))
Posted by Chris Burroughs <ch...@gmail.com>.
My interpretation of the long "Binary dependencies in source releases"
thread is that the build tools are (I think) defensible, but it really
would be best if we could get rid of the rest.
I see that Neha and Jacob already did most of the work last round in
KAFKA-222 (go team!). In the comments pig is called out as a problem,
but it looks like this is taken care of in PIG-1334. Any reason we
can't mavenize those as well?
I'm not sure what to do with DLLs.
-------- Original Message --------
Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Date: Mon, 18 Jun 2012 21:34:41 -0400
From: Joe Stein <cr...@gmail.com>
Reply-To: general@incubator.apache.org
To: general@incubator.apache.org
CC: kafka-dev@incubator.apache.org
I uploaded a md5 checksum
http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ to
go along with the detached signature that was generated already
starting the kafka server is in the quick start
http://incubator.apache.org/kafka/quickstart.html
looking at Cassandra and Hadoop source distributions both have jars in them
too, so not sure the issue you are raising others might have a better
understanding or I am missing something you are trying to point out
I would like to keep the RC2 voting open for another few days to see if
this release passes (as folks have not had time to review) or we can get to
what issues we need to have resolved that can be done for RC3 for a new
vote either with objective to getting 0.7.1 released.
current votes:
+1 [1] +0 [0] -1 [0] from the PPMC
and
+1 [0] +0 [0] -1 [0] from the IPMC
please let me know if there is something different we want or should have
been doing here or that I can be or should be doing differently.
thanks!
On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <ke...@gmail.com>wrote:
> Things that I've noted:
>
> I don't see a checksum for your release in
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ --
> your release manager will need to generate a checksum for the release.
>
> It would be nice if your archive extracted into an
> apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> but that's minor.
>
> I see the following binary files in your source distribution:
>
> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-consumer/lib/piggybank.jar
> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-producer/lib/piggybank.jar
> ./lib/sbt-launch.jar
>
> If I understand correctly, this does not meet a definition of an open
> source release (which is what an apache release is…). It looks like this is
> how your last release was packaged, also… I don't know if this is a
> blocking issue (for an incubator release), but I think you need to work on
> resolving this (i.e. remove binaries from your source)…
>
> IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> built kafka and see that a number jars are pulled in… I have no idea what
> the LICENSING for these artifacts is… and whether or not they conform to
> ASF standards (I did not review them all). Your project needs to document
> them.
>
> FYI, I couldn't figure out from the documentation how to start a server
> after I built kafka.
>
> --kevan
>
> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>
> > Any other voters?
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This is the second candidate for the second incubator release for Apache
> >> Kafka, version 0.7.1-incubating.
> >>
> >> This release fixes the following issues
> >>
> >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >>
> >> RC2 fixes the issue identified in RC1 =>
> >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> >> to 2012
> >>
> >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >>
> >> Release artifacts:
> >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >>
> >> The tag to be voted upon (off the 0.7.1 branch):
> >>
> >>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >>
> >> Kafka's KEYS file containing PGP keys we use to sign the release:
> >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >>
> >> /*
> >> Joe Stein
> >> http://www.linkedin.com/in/charmalloc
> >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> >> */
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 18, 2012, at 9:34 PM, Joe Stein wrote:
> I uploaded a md5 checksum
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ to
> go along with the detached signature that was generated already
Thanks.
>
> starting the kafka server is in the quick start
> http://incubator.apache.org/kafka/quickstart.html
I did track that doc down.
I find it easier to read that info in the download. Rather than bring up a README and then have to visit a web site (which may not be documenting the kafka version that I'm trying to start). But that's just my opinion and it's a minor point… I'm happy for the Kafka project to decide how they document their project...
Here's what I got trying to start zookeeper.properties, yesterday:
[2012-06-18 16:52:09,788] INFO Opening socket connection to server localhost/0:0:0:0:0:0:0:1:2181 (org.apache.zookeeper.ClientCnxn)
[2012-06-18 16:52:09,798] WARN Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect (org.apache.zookeeper.ClientCnxn)
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:599)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1146)
Seems to be working today. Don't know what's changed… Again not a big deal. You guys are in control of these issues/non-issues. When reviewing a release, I try to build (and start) a project.
>
> looking at Cassandra and Hadoop source distributions both have jars in them
> too, so not sure the issue you are raising others might have a better
> understanding or I am missing something you are trying to point out
We (the ASF) are not always terribly consistent. And there could be some debate on this. And I'm not sure there's official documented policy around this… Finally, I confess that in the past, I've been part of a project that has released a jar file(s) as part of a source release. However, IMO, this was a mistake. And since corrected…
Apache releases are *source* releases. See http://www.apache.org/dev/release.html#what -- "All releases are in the form of the source materials needed to make changes to the software being released."
IMO, we should not be including jar's, dll's, and other binary artifacts in our source releases. You may find some alternate opinions. I'm not aware of documentation that makes this explicit…
Build utilities (e.g. ant, maven, sbt, ivy) are usually a requirement to build a release. Not included in the release. I don't know why you are including the other jar/dll files in your source. But would encourage you to stop...
>
> I would like to keep the RC2 voting open for another few days to see if
> this release passes (as folks have not had time to review) or we can get to
> what issues we need to have resolved that can be done for RC3 for a new
> vote either with objective to getting 0.7.1 released.
You are the release manager. You're in control of the release timing/process. It's certainly frustrating to have a release vote, a problem found, and then have people hold off reviewing the release until there's a new RC. So, encouraging additional reviews/votes is quite understandable.
Also, there aren't VETO's of release votes. So my vote does not necessarily mean your release vote fails.
FYI, out-of-date copyright statements are not typically considered a blocking issue for a release…
>
> current votes:
>
> +1 [1] +0 [0] -1 [0] from the PPMC
>
> and
>
> +1 [0] +0 [0] -1 [0] from the IPMC
>
> please let me know if there is something different we want or should have
> been doing here or that I can be or should be doing differently.
I see that I didn't register my vote in my original email. Here's mine -- -1 (binding).
Binding just means that I'm a member of the Incubator PMC. Beyond the requirement for 3 +1 IPMC votes, it doesn't count more or less than any other votes… There aren't veto's of release votes. As a release manager, you can decide if problems found merit a new release candidate.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Joe Stein <cr...@gmail.com>.
I uploaded a md5 checksum
http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ to
go along with the detached signature that was generated already
starting the kafka server is in the quick start
http://incubator.apache.org/kafka/quickstart.html
looking at Cassandra and Hadoop source distributions both have jars in them
too, so not sure the issue you are raising others might have a better
understanding or I am missing something you are trying to point out
I would like to keep the RC2 voting open for another few days to see if
this release passes (as folks have not had time to review) or we can get to
what issues we need to have resolved that can be done for RC3 for a new
vote either with objective to getting 0.7.1 released.
current votes:
+1 [1] +0 [0] -1 [0] from the PPMC
and
+1 [0] +0 [0] -1 [0] from the IPMC
please let me know if there is something different we want or should have
been doing here or that I can be or should be doing differently.
thanks!
On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <ke...@gmail.com>wrote:
> Things that I've noted:
>
> I don't see a checksum for your release in
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ --
> your release manager will need to generate a checksum for the release.
>
> It would be nice if your archive extracted into an
> apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> but that's minor.
>
> I see the following binary files in your source distribution:
>
> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-consumer/lib/piggybank.jar
> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-producer/lib/piggybank.jar
> ./lib/sbt-launch.jar
>
> If I understand correctly, this does not meet a definition of an open
> source release (which is what an apache release is…). It looks like this is
> how your last release was packaged, also… I don't know if this is a
> blocking issue (for an incubator release), but I think you need to work on
> resolving this (i.e. remove binaries from your source)…
>
> IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> built kafka and see that a number jars are pulled in… I have no idea what
> the LICENSING for these artifacts is… and whether or not they conform to
> ASF standards (I did not review them all). Your project needs to document
> them.
>
> FYI, I couldn't figure out from the documentation how to start a server
> after I built kafka.
>
> --kevan
>
> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>
> > Any other voters?
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This is the second candidate for the second incubator release for Apache
> >> Kafka, version 0.7.1-incubating.
> >>
> >> This release fixes the following issues
> >>
> >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >>
> >> RC2 fixes the issue identified in RC1 =>
> >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> >> to 2012
> >>
> >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >>
> >> Release artifacts:
> >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >>
> >> The tag to be voted upon (off the 0.7.1 branch):
> >>
> >>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >>
> >> Kafka's KEYS file containing PGP keys we use to sign the release:
> >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >>
> >> /*
> >> Joe Stein
> >> http://www.linkedin.com/in/charmalloc
> >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> >> */
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Joe Stein <cr...@gmail.com>.
I uploaded a md5 checksum
http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ to
go along with the detached signature that was generated already
starting the kafka server is in the quick start
http://incubator.apache.org/kafka/quickstart.html
looking at Cassandra and Hadoop source distributions both have jars in them
too, so not sure the issue you are raising others might have a better
understanding or I am missing something you are trying to point out
I would like to keep the RC2 voting open for another few days to see if
this release passes (as folks have not had time to review) or we can get to
what issues we need to have resolved that can be done for RC3 for a new
vote either with objective to getting 0.7.1 released.
current votes:
+1 [1] +0 [0] -1 [0] from the PPMC
and
+1 [0] +0 [0] -1 [0] from the IPMC
please let me know if there is something different we want or should have
been doing here or that I can be or should be doing differently.
thanks!
On Mon, Jun 18, 2012 at 4:53 PM, Kevan Miller <ke...@gmail.com>wrote:
> Things that I've noted:
>
> I don't see a checksum for your release in
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ --
> your release manager will need to generate a checksum for the release.
>
> It would be nice if your archive extracted into an
> apache-kafka-0.7.1-incubating directory (or similar name rather than .),
> but that's minor.
>
> I see the following binary files in your source distribution:
>
> ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
> ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-consumer/lib/piggybank.jar
> ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
> ./contrib/hadoop-producer/lib/piggybank.jar
> ./lib/sbt-launch.jar
>
> If I understand correctly, this does not meet a definition of an open
> source release (which is what an apache release is…). It looks like this is
> how your last release was packaged, also… I don't know if this is a
> blocking issue (for an incubator release), but I think you need to work on
> resolving this (i.e. remove binaries from your source)…
>
> IIUC, your LICENSE/NOTICE files are documenting your "source" (including
> the above jars). Do you document the LICENSE/NOTICE of your binaries? I
> built kafka and see that a number jars are pulled in… I have no idea what
> the LICENSING for these artifacts is… and whether or not they conform to
> ASF standards (I did not review them all). Your project needs to document
> them.
>
> FYI, I couldn't figure out from the documentation how to start a server
> after I built kafka.
>
> --kevan
>
> On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
>
> > Any other voters?
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This is the second candidate for the second incubator release for Apache
> >> Kafka, version 0.7.1-incubating.
> >>
> >> This release fixes the following issues
> >>
> >>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >>
> >> RC2 fixes the issue identified in RC1 =>
> >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> >> to 2012
> >>
> >> *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >>
> >> Release artifacts:
> >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >>
> >> The tag to be voted upon (off the 0.7.1 branch):
> >>
> >>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >>
> >> Kafka's KEYS file containing PGP keys we use to sign the release:
> >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >>
> >> /*
> >> Joe Stein
> >> http://www.linkedin.com/in/charmalloc
> >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> >> */
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
Things that I've noted:
I don't see a checksum for your release in http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ -- your release manager will need to generate a checksum for the release.
It would be nice if your archive extracted into an apache-kafka-0.7.1-incubating directory (or similar name rather than .), but that's minor.
I see the following binary files in your source distribution:
./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
./contrib/hadoop-consumer/lib/piggybank.jar
./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
./contrib/hadoop-producer/lib/piggybank.jar
./lib/sbt-launch.jar
If I understand correctly, this does not meet a definition of an open source release (which is what an apache release is…). It looks like this is how your last release was packaged, also… I don't know if this is a blocking issue (for an incubator release), but I think you need to work on resolving this (i.e. remove binaries from your source)…
IIUC, your LICENSE/NOTICE files are documenting your "source" (including the above jars). Do you document the LICENSE/NOTICE of your binaries? I built kafka and see that a number jars are pulled in… I have no idea what the LICENSING for these artifacts is… and whether or not they conform to ASF standards (I did not review them all). Your project needs to document them.
FYI, I couldn't figure out from the documentation how to start a server after I built kafka.
--kevan
On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
> Any other voters?
>
> Thanks,
>
> Jun
>
> On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
>
>> Hello,
>>
>> This is the second candidate for the second incubator release for Apache
>> Kafka, version 0.7.1-incubating.
>>
>> This release fixes the following issues
>>
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>>
>> RC2 fixes the issue identified in RC1 =>
>> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
>> to 2012
>>
>> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>>
>> Release artifacts:
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>>
>> The tag to be voted upon (off the 0.7.1 branch):
>>
>> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>>
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>>
>> /*
>> Joe Stein
>> http://www.linkedin.com/in/charmalloc
>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> */
>>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Joel Koshy <jj...@gmail.com>.
I would like to give this a look today - I can vote by tomorrow.
Thanks,
Joel
On Mon, Jun 18, 2012 at 10:14 AM, Jun Rao <ju...@gmail.com> wrote:
> Any other voters?
>
> Thanks,
>
> Jun
>
> On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
>
> > Hello,
> >
> > This is the second candidate for the second incubator release for Apache
> > Kafka, version 0.7.1-incubating.
> >
> > This release fixes the following issues
> >
> >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >
> > RC2 fixes the issue identified in RC1 =>
> > https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> > to 2012
> >
> > *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >
> > Release artifacts:
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >
> > The tag to be voted upon (off the 0.7.1 branch):
> >
> >
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >
> > Kafka's KEYS file containing PGP keys we use to sign the release:
> > http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >
> > /*
> > Joe Stein
> > http://www.linkedin.com/in/charmalloc
> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > */
> >
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Kevan Miller <ke...@gmail.com>.
Things that I've noted:
I don't see a checksum for your release in http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ -- your release manager will need to generate a checksum for the release.
It would be nice if your archive extracted into an apache-kafka-0.7.1-incubating directory (or similar name rather than .), but that's minor.
I see the following binary files in your source distribution:
./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
./contrib/hadoop-consumer/lib/piggybank.jar
./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
./contrib/hadoop-producer/lib/piggybank.jar
./lib/sbt-launch.jar
If I understand correctly, this does not meet a definition of an open source release (which is what an apache release is…). It looks like this is how your last release was packaged, also… I don't know if this is a blocking issue (for an incubator release), but I think you need to work on resolving this (i.e. remove binaries from your source)…
IIUC, your LICENSE/NOTICE files are documenting your "source" (including the above jars). Do you document the LICENSE/NOTICE of your binaries? I built kafka and see that a number jars are pulled in… I have no idea what the LICENSING for these artifacts is… and whether or not they conform to ASF standards (I did not review them all). Your project needs to document them.
FYI, I couldn't figure out from the documentation how to start a server after I built kafka.
--kevan
On Jun 18, 2012, at 1:14 PM, Jun Rao wrote:
> Any other voters?
>
> Thanks,
>
> Jun
>
> On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
>
>> Hello,
>>
>> This is the second candidate for the second incubator release for Apache
>> Kafka, version 0.7.1-incubating.
>>
>> This release fixes the following issues
>>
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>>
>> RC2 fixes the issue identified in RC1 =>
>> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
>> to 2012
>>
>> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>>
>> Release artifacts:
>> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>>
>> The tag to be voted upon (off the 0.7.1 branch):
>>
>> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>>
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>>
>> /*
>> Joe Stein
>> http://www.linkedin.com/in/charmalloc
>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> */
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Any other voters?
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Joe Stein <cr...@gmail.com>.
yup, will do. I will also change the version to 0.7.1 in the
build.properties after I commit kafka-366
On Tue, Jun 19, 2012 at 12:50 AM, Jun Rao <ju...@gmail.com> wrote:
> ---------- Forwarded message ----------
> From: Jun Rao <ju...@gmail.com>
> Date: Mon, Jun 18, 2012 at 9:49 PM
> Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
> To: general@incubator.apache.org
>
>
> Joe,
>
> It looks like that we need to create a new RC. Could you pick up kafka-366?
> It just adds a new jmx.
>
> Thanks,
>
> Jun
>
> On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
>
> > Hello,
> >
> > This is the second candidate for the second incubator release for Apache
> > Kafka, version 0.7.1-incubating.
> >
> > This release fixes the following issues
> >
> >
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
> >
> > RC2 fixes the issue identified in RC1 =>
> > https://issues.apache.org/jira/browse/KAFKA-365 change copyright in
> NOTICE
> > to 2012
> >
> > *** Please download, test and vote by Monday June, 18th, 12pm PDT
> >
> > Release artifacts:
> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
> >
> > The tag to be voted upon (off the 0.7.1 branch):
> >
> >
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
> >
> > Kafka's KEYS file containing PGP keys we use to sign the release:
> > http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
> >
> > /*
> > Joe Stein
> > http://www.linkedin.com/in/charmalloc
> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > */
> >
>
--
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
Fwd: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
---------- Forwarded message ----------
From: Jun Rao <ju...@gmail.com>
Date: Mon, Jun 18, 2012 at 9:49 PM
Subject: Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
To: general@incubator.apache.org
Joe,
It looks like that we need to create a new RC. Could you pick up kafka-366?
It just adds a new jmx.
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Joe,
It looks like that we need to create a new RC. Could you pick up kafka-366?
It just adds a new jmx.
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Any other voters?
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Chris Burroughs <ch...@gmail.com>.
I don't think we should release as is.
- project.version is set to 0.7.0
- Have not released since the general@ threads highlighted the included
jars problem. Thanks for pointing that out Kevan.
(The unit test also don't pass for me but that could easily be a local
issue, I'll try to get a branch specific jenkins build going.)
On 06/14/2012 02:42 PM, Joe Stein wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Chris Burroughs <ch...@gmail.com>.
I don't think we should release as is.
- project.version is set to 0.7.0
- Have not released since the general@ threads highlighted the included
jars problem. Thanks for pointing that out Kevan.
(The unit test also don't pass for me but that could easily be a local
issue, I'll try to get a branch specific jenkins build going.)
On 06/14/2012 02:42 PM, Joe Stein wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
Can other people (including mentors) help vote on this release?
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
Re: [VOTE] Release Kafka 0.7.1-incubating (Candidate 2)
Posted by Jun Rao <ju...@gmail.com>.
+1
Ran quick start, unit tests and rat tests.
Thanks,
Jun
On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <cr...@gmail.com> wrote:
> Hello,
>
> This is the second candidate for the second incubator release for Apache
> Kafka, version 0.7.1-incubating.
>
> This release fixes the following issues
>
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html
>
> RC2 fixes the issue identified in RC1 =>
> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in NOTICE
> to 2012
>
> *** Please download, test and vote by Monday June, 18th, 12pm PDT
>
> Release artifacts:
> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/
>
> The tag to be voted upon (off the 0.7.1 branch):
>
> https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>