You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/12/01 13:50:17 UTC

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1425

    [FLINK-3080] Relax restrictions of DataStream.union()

    Before, it would not allow unioning with predecessors (also transitive)
    and streams of differing parallelism.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink union-relax

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1425
    
----
commit a2c393e329b81015bd959f02f65fa27ebab744ef
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2015-12-01T10:46:53Z

    [FLINK-3080] Relax restrictions of DataStream.union()
    
    Before, it would not allow unioning with predecessors (also transitive)
    and streams of differing parallelism.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

Posted by vasia <gi...@git.apache.org>.

Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1425#issuecomment-161003995
  
    Hi @aljoscha,
    thanks for fixing this! It seems that, with this change, when you union a stream with itself you get each element twice. If this is intentional, could you please also update the docs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1425#issuecomment-161041477
  
    Also changed the doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/1425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1425#issuecomment-161041124
  
    Yes, you get each element twice, so it behaves like bag-union.
    
    @mxm I added a test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

Posted by mxm <gi...@git.apache.org>.

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1425#issuecomment-160999814
  
    Looks good. Is there a test case for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---