You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "henrymai (via GitHub)" <gi...@apache.org> on 2023/08/01 22:12:16 UTC
[GitHub] [spark] henrymai opened a new pull request, #42279: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks -- Backport to 3.4
henrymai opened a new pull request, #42279:
URL: https://github.com/apache/spark/pull/42279
### What changes were proposed in this pull request?
Fix double encryption issue for migrated shuffle blocks
Shuffle blocks upon migration are sent without decryption when io.encryption is enabled. The code on the receiving side ends up using serializer.wrapStream on the OutputStream to the file which results in the already encrypted bytes being encrypted again when the bytes are written out.
This patch removes the usage of serializerManager.wrapStream on the receiving side and also adds tests that validate that this works as expected. I have also validated that the added tests will fail if the fix is not in place.
Jira ticket with more details: https://issues.apache.org/jira/browse/SPARK-44588
### Why are the changes needed?
Migrated shuffle blocks will be double encrypted when `spark.io.encryption = true` without this fix.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests were added to test shuffle block migration with spark.io.encryption enabled and also fixes a test helper method to properly construct the SerializerManager with the encryption key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42279: [SPARK-44588][CORE][3.4] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42279:
URL: https://github.com/apache/spark/pull/42279#issuecomment-1661238624
We can ignore AppVeyor on this PR.
BTW, the CI is still pending.
- https://github.com/henrymai/spark/actions/runs/5732348434/job/15535122136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] henrymai commented on pull request #42279: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks -- Backport to 3.4
Posted by "henrymai (via GitHub)" <gi...@apache.org>.
henrymai commented on PR #42279:
URL: https://github.com/apache/spark/pull/42279#issuecomment-1661171022
CC: @dongjoon-hyun @holdenk
Here's the backport for 3.4. But not sure why appveyor says that this is a non-mergeable pull request. I didn't get any conflicts and this is based on top of the tip of branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42279: [SPARK-44588][CORE][3.4] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42279:
URL: https://github.com/apache/spark/pull/42279#issuecomment-1661458444
Great. Thank you, @henrymai . Merged to branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] henrymai commented on pull request #42279: [SPARK-44588][CORE][3.4] Fix double encryption issue for migrated shuffle blocks
Posted by "henrymai (via GitHub)" <gi...@apache.org>.
henrymai commented on PR #42279:
URL: https://github.com/apache/spark/pull/42279#issuecomment-1661453119
CI just passed now: https://github.com/henrymai/spark/actions/runs/5732348434/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42279: [SPARK-44588][CORE][3.4] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42279: [SPARK-44588][CORE][3.4] Fix double encryption issue for migrated shuffle blocks
URL: https://github.com/apache/spark/pull/42279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org