You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/02 03:32:26 UTC

[GitHub] szha commented on a change in pull request #10773: specify common arch for mkldnn build, so it can be reused on all arch

szha commented on a change in pull request #10773: specify common arch for mkldnn build, so it can be reused on all arch
URL: https://github.com/apache/incubator-mxnet/pull/10773#discussion_r185386380
 
 

 ##########
 File path: prepare_mkldnn.sh
 ##########
 @@ -93,7 +93,7 @@ if [ ! -f $MKLDNN_LIBFILE ]; then
     echo "Building MKLDNN ..." >&2
     cd $MXNET_ROOTDIR
 	g++ --version >&2
-    cmake $MKLDNN_ROOTDIR -DCMAKE_INSTALL_PREFIX=$MKLDNN_INSTALLDIR -B$MKLDNN_BUILDDIR -DARCH_OPT_FLAGS="-mtune=generic" >&2
+    cmake $MKLDNN_ROOTDIR -DCMAKE_INSTALL_PREFIX=$MKLDNN_INSTALLDIR -B$MKLDNN_BUILDDIR -DARCH_OPT_FLAGS="-mtune=generic -march=haswell" >&2
 
 Review comment:
   we have received reports before from users who don't even have AVX2. Please don't assume haswell.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services