You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/07/20 10:05:52 UTC

[GitHub] [iceberg] nastra opened a new pull request, #8114: Spark, Flink: Fix running integration tests with JDK17

nastra opened a new pull request, #8114:
URL: https://github.com/apache/iceberg/pull/8114

   fixes #8102 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra commented on a diff in pull request #8114: Spark, Flink: Fix running integration tests with JDK17

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #8114:
URL: https://github.com/apache/iceberg/pull/8114#discussion_r1269242085


##########
spark/v3.4/build.gradle:
##########
@@ -230,6 +230,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
     integrationImplementation "org.apache.spark:spark-hive_${scalaVersion}:${sparkVersion}"
     integrationImplementation 'org.junit.vintage:junit-vintage-engine'
     integrationImplementation 'org.slf4j:slf4j-simple'
+    integrationImplementation 'org.assertj:assertj-core'

Review Comment:
   tests were passing but it would print the following error at the end
   ```
   > Task :iceberg-spark:iceberg-spark-runtime-3.4_2.12:integrationTest
   Exception in thread "Thread-4" java.lang.NoClassDefFoundError: org/assertj/core/api/Assertions
           at org.apache.iceberg.hive.TestHiveMetastore.lambda$static$0(TestHiveMetastore.java:115)
           at java.base/java.lang.Thread.run(Thread.java:833)
   Caused by: java.lang.ClassNotFoundException: org.assertj.core.api.Assertions
           at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
           at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
           at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
           ... 2 more
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra merged pull request #8114: Spark, Flink: Fix running integration tests with JDK17

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #8114:
URL: https://github.com/apache/iceberg/pull/8114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org