[GitHub] [arrow] lidavidm commented on a change in pull request #11255: ARROW-13876: [C++] Add trivial null kernels to arithmetic, sort functions

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #11255:
URL: https://github.com/apache/arrow/pull/11255#discussion_r717603172



##########
File path: cpp/src/arrow/compute/kernels/vector_sort_test.cc
##########
@@ -675,6 +687,15 @@ TYPED_TEST(TestArraySortIndicesForDecimal, DecimalSortTestTypes) {
                           "[1, 5, 3, 0, 2, 4]");
 }
 
+TEST(TestArraySortIndices, Null) {
+  for (const auto null_placement : AllNullPlacements()) {
+    for (const auto order : AllOrders()) {
+      AssertSortIndices(null(), "[null, null, null, null]", order, null_placement,
+                        "[0, 1, 2, 3]");
+    }
+  }
+}
+

Review comment:
       Ah, good point. I've added the necessary support for those cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org