You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/23 12:06:13 UTC
[jira] [Commented] (THRIFT-2912) Autotool build for C++ Qt library
is invalid
[ https://issues.apache.org/jira/browse/THRIFT-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256853#comment-14256853 ]
ASF GitHub Bot commented on THRIFT-2912:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/336
THRIFT-2912 Autotool build for C++ Qt library is invalid
* Fix incorrect AC_PATH_PROGS usage
* Exclude generated source code from distribution
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-2912
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #336
----
commit 1a363fd813cc7a61e0d6fcebc46767aeba62b6bc
Author: Nobuaki Sukegawa <ns...@gmail.com>
Date: 2014-12-23T10:17:59Z
THRIFT-2912 Autotool build for C++ Qt library is invalid
* Fix incorrect AC_PATH_PROGS usage
* Exclude generated source code from distribution
----
> Autotool build for C++ Qt library is invalid
> --------------------------------------------
>
> Key: THRIFT-2912
> URL: https://issues.apache.org/jira/browse/THRIFT-2912
> Project: Thrift
> Issue Type: Bug
> Components: Build Process, C++ - Library
> Reporter: Nobuaki Sukegawa
> Assignee: Nobuaki Sukegawa
>
> Qt4 and Qt5 build settings for Autotool are invalid:
> * Generated source code is not excluded from distribution, resulting in {{make dist}} failure if libthriftqt or libthriftqt5 is not built
> * The case where the library is found but the moc tool is not found is not handled correctly, resulting in {{make}} failure in these cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)