You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/09/09 04:03:38 UTC
Re: Review Request 37868: Sqoop2: Use object name instead of object
id for the name filed in MResource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37868/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 2:03 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2537
https://issues.apache.org/jira/browse/SQOOP-2537
Repository: sqoop-sqoop2
Description
-------
Currently the meaning of the name field in MResource isn't consistent. Some places assume this field means the object name of the resource, such as in AuthorizationRequestHandler. Some places assume this field means the object id of the resource, such as in AuthorizationEngine.
Diffs (updated)
-----
security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java bebbe91
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 23f6c63
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 13ebb35
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java aa7e5ff
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java f2a6758
Diff: https://reviews.apache.org/r/37868/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 37868: Sqoop2: Use object name instead of object
id for the name filed in MResource
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37868/#review98172
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 9, 2015, 2:03 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37868/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 2:03 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2537
> https://issues.apache.org/jira/browse/SQOOP-2537
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Currently the meaning of the name field in MResource isn't consistent. Some places assume this field means the object name of the resource, such as in AuthorizationRequestHandler. Some places assume this field means the object id of the resource, such as in AuthorizationEngine.
>
>
> Diffs
> -----
>
> security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java bebbe91
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 23f6c63
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 13ebb35
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java aa7e5ff
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java f2a6758
>
> Diff: https://reviews.apache.org/r/37868/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>