You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/11 13:10:48 UTC

[GitHub] lostella opened a new pull request #12794: fixed symbols naming in RNNCell and LSTMCell

lostella opened a new pull request #12794: fixed symbols naming in RNNCell and LSTMCell
URL: https://github.com/apache/incubator-mxnet/pull/12794
 
 
   ## Description ##
   This partially fixes #12783, by assigning *all* nodes in `hybrid_forward` a unique `name`. Some operations were in fact performed without attaching the appropriate (time) prefix to the name.
   
   ### Changes ###
   - [ ] Fixed `hybrid_forward` of `mxnet.gluon.rnn.RNNCell` to account for time prefix
   - [ ] Fixed `hybrid_forward` of `mxnet.gluon.rnn.LSTMCell` to account for time prefix
   
   ## Comments ##
   The same issue occurs with `GRUCell`, however there are some operations there that I don't know how to attach a name to.
   
   Furthermore, tests have not been added to verify the correctness of the fixed `hybrid_forward`, as already existing tests should suffice.
   
   However, from this issue it appears that proper serialization/deserialization tests are missing for `RNNCell`, `LSTMCell`, `GRUCell`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services