[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15414: [fix][tls] remove throw exception in getProvider

[GitBox <gi...@apache.org>]

mattisonchao commented on code in PR #15414:
URL: https://github.com/apache/pulsar/pull/15414#discussion_r865483093


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java:
##########
@@ -110,8 +110,8 @@ public static Provider getProvider() {
             return getBCProviderFromClassPath();
         } catch (Exception e) {
             log.warn("Not able to get Bouncy Castle provider for both FIPS and Non-FIPS from class path:", e);
-            throw new RuntimeException(e);
         }
+        return null;

Review Comment:
   LGTM, left a trivial comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org