You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2024/10/21 11:31:01 UTC

[PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Jibing-Li opened a new pull request, #42209:
URL: https://github.com/apache/doris/pull/42209

   Skip auto analyze when table row count is not fully reported. Not fully reported means row count is -1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2426489529

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.56 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 67fc5264b17f31609d26819a4524446b56d800c6, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.07	0.02	0.03
   query3	0.23	0.07	0.07
   query4	1.65	0.10	0.10
   query5	0.49	0.54	0.52
   query6	1.17	0.73	0.72
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.03
   query9	0.57	0.51	0.50
   query10	0.55	0.56	0.56
   query11	0.14	0.10	0.11
   query12	0.14	0.11	0.11
   query13	0.61	0.61	0.59
   query14	2.82	2.85	2.82
   query15	0.90	0.83	0.84
   query16	0.40	0.39	0.38
   query17	1.06	1.08	1.06
   query18	0.24	0.22	0.22
   query19	1.86	1.87	2.02
   query20	0.02	0.01	0.01
   query21	15.36	0.60	0.60
   query22	2.38	2.61	2.25
   query23	17.01	1.01	0.83
   query24	3.73	0.92	0.22
   query25	0.35	0.06	0.04
   query26	0.41	0.14	0.14
   query27	0.04	0.04	0.04
   query28	10.93	1.08	1.07
   query29	12.54	3.23	3.27
   query30	0.25	0.06	0.07
   query31	2.86	0.37	0.36
   query32	3.31	0.46	0.44
   query33	2.96	3.02	3.06
   query34	16.96	4.54	4.43
   query35	4.56	4.50	4.48
   query36	0.68	0.49	0.51
   query37	0.09	0.06	0.06
   query38	0.05	0.04	0.03
   query39	0.03	0.02	0.02
   query40	0.16	0.13	0.13
   query41	0.09	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.03	0.03	0.03
   Total cold run time: 107.82 s
   Total hot run time: 32.56 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2428178366

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.32 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2eb94ba9031aa2462cc503875d84405d0fc13360, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.07	0.03	0.03
   query3	0.23	0.06	0.06
   query4	1.64	0.10	0.10
   query5	0.52	0.50	0.49
   query6	1.14	0.74	0.72
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.03
   query9	0.57	0.51	0.50
   query10	0.56	0.54	0.56
   query11	0.14	0.11	0.11
   query12	0.14	0.11	0.12
   query13	0.61	0.59	0.59
   query14	2.87	2.72	2.75
   query15	0.89	0.84	0.84
   query16	0.38	0.38	0.38
   query17	1.00	1.04	0.96
   query18	0.20	0.20	0.20
   query19	1.97	1.86	1.94
   query20	0.01	0.01	0.02
   query21	15.36	0.58	0.56
   query22	2.60	1.92	1.60
   query23	17.03	1.10	0.81
   query24	2.96	1.76	0.85
   query25	0.22	0.19	0.18
   query26	0.38	0.14	0.14
   query27	0.04	0.05	0.04
   query28	10.79	1.09	1.06
   query29	12.56	3.25	3.19
   query30	0.24	0.07	0.06
   query31	2.86	0.38	0.37
   query32	3.28	0.46	0.46
   query33	2.99	3.05	3.03
   query34	16.89	4.48	4.45
   query35	4.48	4.46	4.47
   query36	0.66	0.48	0.48
   query37	0.08	0.06	0.05
   query38	0.04	0.03	0.03
   query39	0.03	0.02	0.02
   query40	0.16	0.12	0.12
   query41	0.07	0.03	0.02
   query42	0.03	0.02	0.02
   query43	0.04	0.03	0.03
   Total cold run time: 106.82 s
   Total hot run time: 32.32 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431179240

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431172447

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.67 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit be5cff57b64c188ed999b27c01eb67384274a39f, data reload: false
   
   query1	0.04	0.04	0.03
   query2	0.06	0.03	0.03
   query3	0.24	0.06	0.06
   query4	1.65	0.10	0.10
   query5	0.49	0.51	0.50
   query6	1.14	0.72	0.73
   query7	0.02	0.02	0.02
   query8	0.04	0.04	0.02
   query9	0.56	0.50	0.52
   query10	0.56	0.55	0.54
   query11	0.13	0.10	0.11
   query12	0.14	0.11	0.11
   query13	0.62	0.61	0.59
   query14	2.70	2.74	2.75
   query15	0.90	0.82	0.84
   query16	0.40	0.38	0.38
   query17	1.06	1.01	1.04
   query18	0.20	0.19	0.21
   query19	1.86	1.79	1.96
   query20	0.01	0.01	0.01
   query21	15.38	0.57	0.58
   query22	2.45	2.06	1.67
   query23	17.19	0.82	0.84
   query24	3.27	1.33	2.06
   query25	0.19	0.14	0.04
   query26	0.65	0.13	0.15
   query27	0.05	0.04	0.04
   query28	9.37	1.10	1.07
   query29	12.59	3.24	3.20
   query30	0.24	0.06	0.06
   query31	2.88	0.38	0.37
   query32	3.29	0.46	0.45
   query33	2.96	3.06	3.05
   query34	16.86	4.48	4.40
   query35	4.49	4.45	4.44
   query36	0.66	0.47	0.48
   query37	0.08	0.06	0.06
   query38	0.04	0.03	0.04
   query39	0.04	0.02	0.02
   query40	0.15	0.12	0.12
   query41	0.08	0.02	0.02
   query42	0.04	0.02	0.02
   query43	0.03	0.04	0.03
   Total cold run time: 105.8 s
   Total hot run time: 32.67 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2427164734

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41366 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 81aaa57596ef042c612efeda82b98d8c584b8794, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17567	7492	7297	7297
   q2	2065	157	158	157
   q3	10566	1120	1157	1120
   q4	10229	799	792	792
   q5	7703	3071	3058	3058
   q6	235	152	148	148
   q7	1014	623	605	605
   q8	9362	1981	2004	1981
   q9	7736	6479	6439	6439
   q10	7143	2416	2419	2416
   q11	459	243	253	243
   q12	545	211	213	211
   q13	17783	2973	3002	2973
   q14	251	212	214	212
   q15	593	534	507	507
   q16	657	578	583	578
   q17	1004	544	561	544
   q18	7336	6816	6786	6786
   q19	1354	931	973	931
   q20	466	191	187	187
   q21	4035	3182	3205	3182
   q22	1107	1014	999	999
   Total cold run time: 109210 ms
   Total hot run time: 41366 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7255	7195	7214	7195
   q2	334	226	232	226
   q3	2933	2812	2791	2791
   q4	1938	1744	1729	1729
   q5	5431	5477	5535	5477
   q6	225	141	143	141
   q7	2128	1685	1746	1685
   q8	3268	3388	3406	3388
   q9	8535	8579	8602	8579
   q10	3537	3450	3456	3450
   q11	568	480	493	480
   q12	796	598	570	570
   q13	14649	2992	2986	2986
   q14	299	266	266	266
   q15	570	504	510	504
   q16	693	643	618	618
   q17	1828	1585	1563	1563
   q18	7817	7429	7511	7429
   q19	1673	1537	1574	1537
   q20	2067	1831	1825	1825
   q21	5420	5267	5346	5267
   q22	1108	1032	993	993
   Total cold run time: 73072 ms
   Total hot run time: 58699 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2426452542

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41080 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 67fc5264b17f31609d26819a4524446b56d800c6, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17563	7450	7433	7433
   q2	2059	164	155	155
   q3	10567	1124	1177	1124
   q4	10224	812	826	812
   q5	7746	3045	3030	3030
   q6	241	157	154	154
   q7	1019	607	594	594
   q8	9344	1874	1981	1874
   q9	6655	6436	6413	6413
   q10	7025	2459	2435	2435
   q11	447	237	250	237
   q12	415	221	217	217
   q13	17786	2969	3020	2969
   q14	245	215	215	215
   q15	572	513	505	505
   q16	636	602	578	578
   q17	969	505	548	505
   q18	7286	6708	6812	6708
   q19	1366	812	960	812
   q20	498	184	181	181
   q21	3972	3210	3109	3109
   q22	1115	1020	1021	1020
   Total cold run time: 107750 ms
   Total hot run time: 41080 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7318	7265	8031	7265
   q2	329	239	229	229
   q3	2944	2776	2758	2758
   q4	1942	1747	1679	1679
   q5	5439	5481	5521	5481
   q6	227	145	139	139
   q7	2126	1718	1732	1718
   q8	3229	3409	3418	3409
   q9	8626	8579	8603	8579
   q10	3511	3462	3439	3439
   q11	579	494	485	485
   q12	784	595	585	585
   q13	7702	3060	2990	2990
   q14	308	268	267	267
   q15	578	520	521	520
   q16	676	634	662	634
   q17	1818	1600	1586	1586
   q18	7874	7628	7437	7437
   q19	1662	1546	1568	1546
   q20	2050	1809	1814	1809
   q21	5429	5182	5202	5182
   q22	1110	1041	1017	1017
   Total cold run time: 66261 ms
   Total hot run time: 58754 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2426477534

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192325 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 67fc5264b17f31609d26819a4524446b56d800c6, data reload: false
   
   query1	962	379	373	373
   query2	6513	2111	2149	2111
   query3	6833	210	223	210
   query4	36603	23693	23450	23450
   query5	4407	484	474	474
   query6	273	168	174	168
   query7	4598	291	305	291
   query8	305	223	221	221
   query9	9304	2725	2719	2719
   query10	471	284	277	277
   query11	17944	15337	15254	15254
   query12	149	101	103	101
   query13	1688	458	426	426
   query14	10165	7701	7289	7289
   query15	251	174	178	174
   query16	8012	412	464	412
   query17	1664	569	554	554
   query18	2036	304	299	299
   query19	352	154	150	150
   query20	116	109	108	108
   query21	207	107	108	107
   query22	4662	4517	4276	4276
   query23	34975	34363	34140	34140
   query24	11168	2776	2715	2715
   query25	655	405	429	405
   query26	1361	159	169	159
   query27	2826	285	288	285
   query28	8039	2447	2440	2440
   query29	872	438	416	416
   query30	329	160	157	157
   query31	1045	802	840	802
   query32	102	59	58	58
   query33	777	292	288	288
   query34	982	509	536	509
   query35	893	755	748	748
   query36	1105	938	945	938
   query37	155	89	93	89
   query38	4038	4015	3986	3986
   query39	1483	1455	1434	1434
   query40	293	99	101	99
   query41	50	47	49	47
   query42	118	103	98	98
   query43	539	492	493	492
   query44	1277	813	817	813
   query45	203	168	166	166
   query46	1118	686	706	686
   query47	1918	1838	1816	1816
   query48	419	321	325	321
   query49	1168	432	424	424
   query50	835	377	398	377
   query51	7223	7087	6953	6953
   query52	100	89	90	89
   query53	255	181	180	180
   query54	1231	465	442	442
   query55	79	78	77	77
   query56	273	276	263	263
   query57	1338	1158	1149	1149
   query58	255	263	248	248
   query59	3152	3274	3130	3130
   query60	306	271	276	271
   query61	145	105	103	103
   query62	900	670	684	670
   query63	216	190	177	177
   query64	5296	645	607	607
   query65	3305	3429	3229	3229
   query66	1406	314	305	305
   query67	16097	15670	15826	15670
   query68	4994	564	580	564
   query69	439	281	282	281
   query70	1221	1134	1109	1109
   query71	339	266	272	266
   query72	6378	4021	3977	3977
   query73	775	364	366	364
   query74	10041	9132	9079	9079
   query75	3391	2657	2702	2657
   query76	2773	1017	868	868
   query77	408	299	295	295
   query78	10811	9797	9570	9570
   query79	2699	585	625	585
   query80	1323	459	465	459
   query81	588	243	243	243
   query82	729	141	147	141
   query83	257	139	140	139
   query84	273	75	71	71
   query85	1330	291	288	288
   query86	466	306	307	306
   query87	4430	4403	4415	4403
   query88	4215	2192	2162	2162
   query89	400	293	284	284
   query90	2086	187	188	187
   query91	140	102	101	101
   query92	72	49	49	49
   query93	1570	566	556	556
   query94	1137	286	297	286
   query95	348	246	250	246
   query96	620	285	280	280
   query97	3286	3107	3149	3107
   query98	226	201	190	190
   query99	1539	1297	1304	1297
   Total cold run time: 307139 ms
   Total hot run time: 192325 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2427188387

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192254 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 81aaa57596ef042c612efeda82b98d8c584b8794, data reload: false
   
   query1	907	365	359	359
   query2	4486	2181	2096	2096
   query3	3301	208	226	208
   query4	32773	23592	23582	23582
   query5	3024	488	449	449
   query6	225	159	160	159
   query7	3652	287	288	287
   query8	255	234	226	226
   query9	6981	2769	2750	2750
   query10	421	287	289	287
   query11	17688	15268	15265	15265
   query12	154	106	102	102
   query13	1288	434	416	416
   query14	9558	7577	7391	7391
   query15	253	178	182	178
   query16	6758	463	445	445
   query17	1087	566	551	551
   query18	1859	296	306	296
   query19	283	150	151	150
   query20	119	113	108	108
   query21	215	108	105	105
   query22	4443	4430	4432	4430
   query23	35245	34156	34123	34123
   query24	11541	2742	2751	2742
   query25	628	407	404	404
   query26	1280	157	157	157
   query27	2373	282	294	282
   query28	6708	2469	2432	2432
   query29	801	428	426	426
   query30	323	157	159	157
   query31	1040	769	853	769
   query32	95	57	58	57
   query33	715	304	297	297
   query34	928	508	515	508
   query35	904	737	739	737
   query36	1075	952	961	952
   query37	149	91	86	86
   query38	4045	3911	3891	3891
   query39	1484	1420	1445	1420
   query40	282	101	99	99
   query41	51	47	49	47
   query42	116	99	97	97
   query43	540	495	495	495
   query44	1193	804	809	804
   query45	197	166	166	166
   query46	1139	691	686	686
   query47	1958	1852	1883	1852
   query48	409	327	329	327
   query49	1096	436	423	423
   query50	828	374	390	374
   query51	7148	7090	6945	6945
   query52	101	88	86	86
   query53	258	178	182	178
   query54	903	423	439	423
   query55	78	77	78	77
   query56	288	270	265	265
   query57	1346	1206	1163	1163
   query58	259	237	244	237
   query59	3359	3183	3272	3183
   query60	294	266	268	266
   query61	102	102	96	96
   query62	861	699	667	667
   query63	213	189	179	179
   query64	3927	644	620	620
   query65	3283	3250	3192	3192
   query66	1046	317	308	308
   query67	16214	15551	15536	15536
   query68	3572	579	578	578
   query69	495	286	288	286
   query70	1165	1139	1153	1139
   query71	363	270	270	270
   query72	7111	3935	3983	3935
   query73	775	359	365	359
   query74	9847	9165	8931	8931
   query75	3441	2648	2683	2648
   query76	2691	876	896	876
   query77	663	298	284	284
   query78	11558	10188	9686	9686
   query79	1828	596	600	596
   query80	1387	454	438	438
   query81	588	247	246	246
   query82	415	136	145	136
   query83	297	134	135	134
   query84	286	71	66	66
   query85	762	285	279	279
   query86	390	296	296	296
   query87	4432	4308	4320	4308
   query88	3949	2179	2135	2135
   query89	395	286	285	285
   query90	2089	184	185	184
   query91	133	102	108	102
   query92	68	49	48	48
   query93	1096	538	531	531
   query94	973	281	284	281
   query95	323	246	241	241
   query96	615	271	283	271
   query97	3278	3142	3112	3112
   query98	207	200	199	199
   query99	1522	1309	1303	1303
   Total cold run time: 283267 ms
   Total hot run time: 192254 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2427218209

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.08 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 81aaa57596ef042c612efeda82b98d8c584b8794, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.03	0.03
   query3	0.23	0.06	0.06
   query4	1.64	0.10	0.11
   query5	0.51	0.49	0.49
   query6	1.14	0.73	0.72
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.03
   query9	0.56	0.51	0.52
   query10	0.56	0.56	0.55
   query11	0.13	0.11	0.11
   query12	0.14	0.11	0.10
   query13	0.60	0.60	0.59
   query14	2.71	2.82	2.75
   query15	0.90	0.83	0.84
   query16	0.40	0.39	0.38
   query17	1.02	1.05	1.02
   query18	0.19	0.19	0.19
   query19	1.89	1.76	1.94
   query20	0.01	0.01	0.01
   query21	15.36	0.60	0.60
   query22	2.52	2.80	1.73
   query23	17.04	0.84	0.87
   query24	3.20	1.28	0.46
   query25	0.30	0.07	0.08
   query26	0.57	0.15	0.15
   query27	0.05	0.04	0.04
   query28	10.94	1.08	1.08
   query29	12.51	3.31	3.30
   query30	0.25	0.06	0.06
   query31	2.86	0.38	0.37
   query32	3.32	0.45	0.46
   query33	2.97	3.04	3.00
   query34	16.95	4.47	4.41
   query35	4.50	4.48	4.53
   query36	0.68	0.47	0.48
   query37	0.08	0.06	0.06
   query38	0.05	0.03	0.03
   query39	0.03	0.02	0.03
   query40	0.16	0.12	0.12
   query41	0.08	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.04	0.03	0.03
   Total cold run time: 107.27 s
   Total hot run time: 32.08 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431340296

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2426414091

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2427936356

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li merged PR #42209:
URL: https://github.com/apache/doris/pull/42209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2428049291

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2428145985

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41740 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2eb94ba9031aa2462cc503875d84405d0fc13360, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17572	8417	7375	7375
   q2	2051	279	278	278
   q3	11999	1091	1259	1091
   q4	10576	854	802	802
   q5	7772	3148	3107	3107
   q6	242	158	152	152
   q7	1034	616	602	602
   q8	9362	1975	1980	1975
   q9	6612	6518	6487	6487
   q10	7055	2454	2451	2451
   q11	449	257	245	245
   q12	430	223	221	221
   q13	17782	3017	3027	3017
   q14	242	211	216	211
   q15	572	524	519	519
   q16	642	584	588	584
   q17	998	612	550	550
   q18	7333	6738	6775	6738
   q19	1363	1000	957	957
   q20	497	184	179	179
   q21	4097	3267	3214	3214
   q22	1060	1016	985	985
   Total cold run time: 109740 ms
   Total hot run time: 41740 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7337	7327	7334	7327
   q2	333	231	232	231
   q3	3103	3003	2991	2991
   q4	2077	1851	1832	1832
   q5	5738	5785	5840	5785
   q6	243	150	154	150
   q7	2279	1815	1844	1815
   q8	3400	3504	3534	3504
   q9	8912	8871	8868	8868
   q10	3606	3568	3590	3568
   q11	607	488	503	488
   q12	825	650	618	618
   q13	10616	3180	3214	3180
   q14	300	271	284	271
   q15	587	538	518	518
   q16	677	649	643	643
   q17	1869	1646	1608	1608
   q18	8421	7872	7534	7534
   q19	1779	1430	1538	1430
   q20	2135	1876	1880	1876
   q21	5631	5507	5511	5507
   q22	1127	1077	1045	1045
   Total cold run time: 71602 ms
   Total hot run time: 60789 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2426412388

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2428087803

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431160363

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 190674 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit be5cff57b64c188ed999b27c01eb67384274a39f, data reload: false
   
   query1	956	399	396	396
   query2	6232	2039	2071	2039
   query3	8692	203	210	203
   query4	34066	23693	23549	23549
   query5	3632	465	465	465
   query6	260	168	163	163
   query7	4198	282	284	282
   query8	290	221	224	221
   query9	9581	2652	2624	2624
   query10	430	273	262	262
   query11	17804	15251	15184	15184
   query12	134	107	98	98
   query13	1582	434	398	398
   query14	9248	6948	7360	6948
   query15	239	167	176	167
   query16	7908	427	472	427
   query17	1618	590	565	565
   query18	2113	342	306	306
   query19	252	179	155	155
   query20	117	121	120	120
   query21	220	110	109	109
   query22	4672	4452	4444	4444
   query23	35250	34058	34285	34058
   query24	10890	2725	2757	2725
   query25	635	419	408	408
   query26	1285	158	159	158
   query27	2660	271	281	271
   query28	7801	2404	2379	2379
   query29	869	433	425	425
   query30	287	150	154	150
   query31	1063	779	791	779
   query32	96	52	56	52
   query33	778	289	299	289
   query34	920	503	501	501
   query35	898	731	728	728
   query36	1098	936	955	936
   query37	155	91	93	91
   query38	4086	3923	3930	3923
   query39	1450	1434	1446	1434
   query40	254	98	98	98
   query41	48	47	46	46
   query42	132	101	98	98
   query43	533	487	487	487
   query44	1268	808	788	788
   query45	193	164	164	164
   query46	1219	713	670	670
   query47	1930	1860	1835	1835
   query48	420	333	330	330
   query49	1012	415	434	415
   query50	795	382	382	382
   query51	7038	6948	6919	6919
   query52	103	85	86	85
   query53	249	177	182	177
   query54	1219	441	431	431
   query55	78	75	80	75
   query56	286	269	294	269
   query57	1299	1140	1137	1137
   query58	234	239	227	227
   query59	3151	3005	2900	2900
   query60	289	274	257	257
   query61	102	96	102	96
   query62	881	673	658	658
   query63	215	186	177	177
   query64	4138	634	622	622
   query65	3301	3186	3200	3186
   query66	974	319	306	306
   query67	15833	15512	15551	15512
   query68	4664	564	529	529
   query69	506	293	284	284
   query70	1178	1110	1175	1110
   query71	361	269	270	269
   query72	7114	3897	3914	3897
   query73	772	361	366	361
   query74	10027	9005	8985	8985
   query75	3478	2619	2685	2619
   query76	3262	844	863	844
   query77	562	291	294	291
   query78	10344	9586	9570	9570
   query79	1725	599	596	596
   query80	2198	440	454	440
   query81	574	240	236	236
   query82	740	137	135	135
   query83	290	137	131	131
   query84	267	73	71	71
   query85	1423	291	289	289
   query86	372	292	299	292
   query87	4492	4260	4421	4260
   query88	2886	2200	2158	2158
   query89	399	285	289	285
   query90	2209	182	182	182
   query91	131	95	97	95
   query92	62	50	48	48
   query93	1095	516	522	516
   query94	1116	291	244	244
   query95	349	245	242	242
   query96	611	286	286	286
   query97	3259	3159	3138	3138
   query98	216	198	197	197
   query99	1635	1295	1303	1295
   Total cold run time: 299976 ms
   Total hot run time: 190674 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431340236

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431135813

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41167 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit be5cff57b64c188ed999b27c01eb67384274a39f, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17559	7384	7252	7252
   q2	2029	287	293	287
   q3	12290	1053	1139	1053
   q4	10563	761	833	761
   q5	7773	3046	3080	3046
   q6	241	153	146	146
   q7	1039	601	588	588
   q8	9360	1913	1910	1910
   q9	6613	6427	6401	6401
   q10	7031	2407	2456	2407
   q11	465	238	240	238
   q12	425	224	221	221
   q13	17776	2971	2986	2971
   q14	244	218	227	218
   q15	559	506	523	506
   q16	662	573	589	573
   q17	962	576	482	482
   q18	7203	6778	6747	6747
   q19	1360	952	1005	952
   q20	496	187	184	184
   q21	4025	3275	3253	3253
   q22	1092	996	971	971
   Total cold run time: 109767 ms
   Total hot run time: 41167 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7242	7243	7206	7206
   q2	332	235	226	226
   q3	3061	2941	2961	2941
   q4	2111	1834	1776	1776
   q5	5778	5772	5792	5772
   q6	233	146	147	146
   q7	2203	1838	1778	1778
   q8	3310	3543	3467	3467
   q9	8908	8938	8849	8849
   q10	3584	3604	3583	3583
   q11	588	503	485	485
   q12	798	664	645	645
   q13	8718	3227	3249	3227
   q14	307	295	272	272
   q15	570	519	530	519
   q16	684	645	654	645
   q17	1824	1606	1588	1588
   q18	8326	7709	7661	7661
   q19	1715	1486	1415	1415
   q20	2167	1896	1900	1896
   q21	5618	5371	5434	5371
   q22	1142	1064	1023	1023
   Total cold run time: 69219 ms
   Total hot run time: 60491 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2428159325

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192986 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2eb94ba9031aa2462cc503875d84405d0fc13360, data reload: false
   
   query1	893	400	396	396
   query2	6274	2114	2030	2030
   query3	8681	195	202	195
   query4	34233	23702	23653	23653
   query5	3485	477	486	477
   query6	293	174	172	172
   query7	4200	298	290	290
   query8	300	248	244	244
   query9	9387	2745	2751	2745
   query10	471	276	269	269
   query11	17912	15447	15402	15402
   query12	156	102	103	102
   query13	1601	450	417	417
   query14	10089	7380	7525	7380
   query15	248	171	176	171
   query16	8061	473	482	473
   query17	1621	588	580	580
   query18	2167	327	320	320
   query19	368	153	149	149
   query20	126	111	119	111
   query21	220	115	118	115
   query22	4620	4436	4605	4436
   query23	34983	34273	34303	34273
   query24	10901	2752	2799	2752
   query25	617	411	404	404
   query26	1183	157	159	157
   query27	2271	288	286	286
   query28	7574	2463	2447	2447
   query29	838	430	428	428
   query30	280	156	153	153
   query31	1036	818	807	807
   query32	99	54	56	54
   query33	763	289	308	289
   query34	935	522	515	515
   query35	909	740	742	740
   query36	1133	961	946	946
   query37	152	89	91	89
   query38	4104	3939	3931	3931
   query39	1490	1416	1448	1416
   query40	207	100	103	100
   query41	49	48	46	46
   query42	131	106	109	106
   query43	538	493	483	483
   query44	1249	817	808	808
   query45	195	165	168	165
   query46	1143	680	713	680
   query47	1933	1837	1828	1828
   query48	425	318	310	310
   query49	940	427	429	427
   query50	815	395	393	393
   query51	7298	7010	6969	6969
   query52	102	88	88	88
   query53	254	175	176	175
   query54	1116	419	416	416
   query55	81	76	75	75
   query56	258	255	260	255
   query57	1352	1126	1122	1122
   query58	231	239	235	235
   query59	3272	3085	2970	2970
   query60	293	265	256	256
   query61	102	102	102	102
   query62	856	698	661	661
   query63	219	184	179	179
   query64	3988	628	635	628
   query65	3257	3199	3218	3199
   query66	859	292	304	292
   query67	16300	15782	15757	15757
   query68	4676	571	561	561
   query69	467	283	286	283
   query70	1251	1087	1112	1087
   query71	338	274	266	266
   query72	7271	4063	3986	3986
   query73	783	360	363	360
   query74	10318	9020	9011	9011
   query75	3438	2662	2662	2662
   query76	2864	897	930	897
   query77	610	288	283	283
   query78	10640	9678	9593	9593
   query79	2229	602	604	602
   query80	2372	446	456	446
   query81	554	237	237	237
   query82	723	146	142	142
   query83	296	138	136	136
   query84	291	70	69	69
   query85	1154	300	280	280
   query86	331	310	305	305
   query87	4389	4435	4455	4435
   query88	3905	2213	2213	2213
   query89	404	285	285	285
   query90	2067	186	183	183
   query91	146	100	104	100
   query92	69	46	49	46
   query93	1417	545	548	545
   query94	891	284	288	284
   query95	349	252	262	252
   query96	613	278	278	278
   query97	3268	3114	3120	3114
   query98	221	207	195	195
   query99	1572	1311	1316	1311
   Total cold run time: 302054 ms
   Total hot run time: 192986 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #42209:
URL: https://github.com/apache/doris/pull/42209#discussion_r1811933079


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java:
##########
@@ -203,6 +206,13 @@ protected AnalysisInfo createAnalyzeJobForTbl(
         if (StatisticsUtil.enablePartitionAnalyze() && table.isPartitionedTable()) {
             analysisMethod = AnalysisMethod.FULL;
         }
+        if (table instanceof OlapTable && analysisMethod.equals(AnalysisMethod.SAMPLE)) {
+            OlapTable ot = (OlapTable) table;
+            if (ot.getRowCountForIndex(ot.getBaseIndexId(), true) == -1) {

Review Comment:
   -1 is a magic number, could we use a static variable instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2431059022

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](statistics)Skip auto analyze when table row count is not fully reported. (return -1) [doris]

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #42209:
URL: https://github.com/apache/doris/pull/42209#issuecomment-2427123061

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org