You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/18 05:40:27 UTC

[GitHub] [apisix-dashboard] guoqqqi commented on a diff in pull request #2593: fix: page refresh causes deletion exception

guoqqqi commented on code in PR #2593:
URL: https://github.com/apache/apisix-dashboard/pull/2593#discussion_r948626222


##########
web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js:
##########
@@ -211,6 +225,93 @@ context('Delete Plugin List with the Drawer', () => {
       });
     });
     cy.contains(data.basicAuthPlugin).should('exist');
+
+    cy.visit('/plugin/list');
+    cy.get(selector.empty).should('be.visible');
+  });
+
+  it('should be deleted one of the plugins instead of all', function () {
+    cy.visit('/plugin/list');
+    cy.get(selector.refresh).click();
+    cy.contains('Enable').click();
+
+    const pluginList = [data.jwtAuthPlugin, data.basicAuthPlugin, data.keyAuthPlugin];
+    pluginList.forEach((item) => {

Review Comment:
   why not use `Object.values(data)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org