[GitHub] [ant] jaikiran commented on a change in pull request #89: Added version and mainClass attributes to task.

[GitBox <gi...@apache.org>]

jaikiran commented on a change in pull request #89: Added version and mainClass attributes to <jar> task.
URL: https://github.com/apache/ant/pull/89#discussion_r270277284
 
 

 ##########
 File path: manual/Tasks/jar.html
 ##########
 @@ -217,6 +217,23 @@ <h3>Parameters</h3>
       include <samp>META-INF</samp> unless explicitly asked to. <em>Since Ant 1.8.0</em></td>
     <td>No; defaults to <q>false</q></td>
   </tr>
+  <tr>
+    <td>version</td>
+    <td>The <a href="https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/module/ModuleDescriptor.Version.html">module version</a>
+      to embed into the jar file's module descriptor, if it has one.  Not used in Java versions
+      older than Java 9.
 
 Review comment:
   >Not used in Java versions older than Java 9.
   
   I think this wording is confusing. Rephrasing it to "Not used in Java versions below Java 9", might be better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org