You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vyacheslav Daradur (JIRA)" <ji...@apache.org> on 2017/06/07 07:31:18 UTC
[jira] [Commented] (IGNITE-5383) Do not perform cache key
validation when BinaryMarshaller is used
[ https://issues.apache.org/jira/browse/IGNITE-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040394#comment-16040394 ]
Vyacheslav Daradur commented on IGNITE-5383:
--------------------------------------------
All subclasses of GridCacheAdapter use the non-static methods {{validateCacheKey}} and {{validateCacheKeys}} which are controlled by the flag {{keyCheck}}.
I propose to check in the conctructor of {{GridCacheAdapter}} if {{BinaryMarshaller}} is used then set {{keyCheck}} to {{false}}.
[~vozerov], please, review the solution. ([ci.tests|http://ci.ignite.apache.org/viewLog.html?buildId=652028&tab=buildResultsDiv&buildTypeId=IgniteTests_RunAll])
> Do not perform cache key validation when BinaryMarshaller is used
> -----------------------------------------------------------------
>
> Key: IGNITE-5383
> URL: https://issues.apache.org/jira/browse/IGNITE-5383
> Project: Ignite
> Issue Type: Task
> Components: binary, cache
> Affects Versions: 2.1
> Reporter: Vladimir Ozerov
> Labels: important
> Fix For: 2.2
>
>
> Currently whenever cache operation is performed, we invoke {{GridCacheAdapter.validateCacheKey}} to make sure that key overrides {{equals}} and {{hashCode}}.
> This check should not be performed when {{BinaryMarshaller}} is set, since we do not use these methods in binary mode.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)