You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/15 19:54:18 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #197: replace akka based names in logging code
pjfanning opened a new pull request, #197:
URL: https://github.com/apache/incubator-pekko/pull/197
splits out some of the changes in #184 so that can focus more on the Pekko/Akka URL protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #197: replace akka based names in logging code
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #197:
URL: https://github.com/apache/incubator-pekko/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #197: replace akka based names in logging code
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #197:
URL: https://github.com/apache/incubator-pekko/pull/197#discussion_r1108177075
##########
actor-tests/src/test/scala/org/apache/pekko/serialization/SerializeSpec.scala:
##########
@@ -276,7 +276,7 @@ class SerializeSpec extends PekkoSpec(SerializationTests.serializeConf) {
}
"log warning if non-Pekko serializer is configured for Pekko message" in {
- EventFilter.warning(pattern = ".*not implemented by Apache Pekko.*", occurrences = 1).intercept {
+ EventFilter.warning(pattern = ".*not implemented by Pekko.*", occurrences = 1).intercept {
Review Comment:
Weird, a reverse change like this is also proposed as part of #196?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #197: replace akka based names in logging code
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #197:
URL: https://github.com/apache/incubator-pekko/pull/197#issuecomment-1432808446
The squash merge led to this commit: https://github.com/apache/incubator-pekko/commit/2824a44abeedaefffc68f4930d5f2435690d1eb2
There appears to be no change to SerializeSpec in that commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #197: replace akka based names in logging code
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #197:
URL: https://github.com/apache/incubator-pekko/pull/197#issuecomment-1432801077
> 196
I was trying to fix an issue in #196 and committed the change to this PR by mistake. I committed a revert of that commit to this PR after committing the fix to #196. I am getting no conflicts showing for this PR now that #196 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org