You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myriad.apache.org by Santosh Marella <sm...@maprtech.com> on 2015/11/19 04:36:51 UTC
Fwd: [VOTE] Release Apache Myriad 0.1.0 (incubating)
We need to fix the LICENSE, exclude the gradle-wrapper.jar from the
tarball, and add build instructions (potentially also on how to download
gradle as well) in the README.
Santosh
---------- Forwarded message ----------
From: Justin Mclean <ju...@me.com>
Date: Wed, Nov 18, 2015 at 4:55 PM
Subject: Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
To: general@incubator.apache.org
Hi,
Sorry but it -1 due to inclusion of a jar in the source release. This issue
has come up before on the incubator mailing list e.g. [4].
Other than some minor license issues everything else is good.
I checked:
- artefact name contains incubating
- signatures and hashes good
- DISCLAIMER exists
- LICENSE has a couple of minor issues
- NOTICE good
- unexpected binary file in the source release [3]
- all source code has Apache headers
- Can build from source
For the LICENSE:
- The appendix part of the LICENSE isn’t correct (i.e. the Apache licence
can apply to non ASF licensed software). Best to use the stock one and not
modify it [1]
- LICENSE mentions sub components but there are none listed
- LICENSE is missing normalise.css which is MIT licensed see [2]
You may want to consider:
- Signing with an apache.org email address
- Adding some build instruction to README
Thanks,
Justin
1. http://www.apache.org/licenses/LICENSE-2.0.txt
2. ./myriad-scheduler/src/main/resources/webapp/css/bootstrap-myriad.css
3../gradle/wrapper/gradle-wrapper.jar
4. http://apache.markmail.org/thread/stygi2hnnovbmf46
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
Thanks Justin.
Santosh
On Thu, Nov 19, 2015 at 5:11 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > @Justin - it'll be great if you can review the PR as well. Thanks!
> >
> > [1] https://github.com/apache/incubator-myriad/pull/49 <
> https://github.com/apache/incubator-myriad/pull/49>
> Looks good to me.
>
> Thanks,
> Justin
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> @Justin - it'll be great if you can review the PR as well. Thanks!
>
> [1] https://github.com/apache/incubator-myriad/pull/49 <https://github.com/apache/incubator-myriad/pull/49>
Looks good to me.
Thanks,
Justin
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
I think so too.
----------------------
Sent from mobile
On Nov 19, 2015 4:14 PM, "Jim Klucar" <kl...@gmail.com> wrote:
> I have a script that pulls all the licenses from the node stuff. I guess we
> only need the ones delivered, not the ones pulled down to make the build.
> (Like gulp)
>
> On Thursday, November 19, 2015, Santosh Marella <sm...@maprtech.com>
> wrote:
>
> > Incorporated feedback from IPMC and submitted a PR for review [1].
> >
> > @Justin - it'll be great if you can review the PR as well. Thanks!
> >
> > [1] https://github.com/apache/incubator-myriad/pull/49
> >
> > Santosh
> >
> > On Thu, Nov 19, 2015 at 1:02 AM, Santosh Marella <smarella@maprtech.com
> > <javascript:;>>
> > wrote:
> >
> > > Great. Thanks once again! We'll try to get the necessary changes
> > > incorporated and prepare a new RC ASAP.
> > >
> > > Santosh
> > >
> > > On Thu, Nov 19, 2015 at 12:56 AM, Justin Mclean <
> > justin@classsoftware.com <javascript:;>>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> > I didn't understand what's not correct in the appendix part of the
> > >> LICENSE.
> > >> > I compared the appendix section with that from the stock, and
> couldn't
> > >> spot
> > >> > a difference. Can you please clarify?
> > >>
> > >> Yep the text should be this:
> > >> Copyright [yyyy] [name of copyright owner]
> > >>
> > >> Not this:
> > >> Copyright 2012-present Apache Software Foundation
> > >>
> > >> Just replace the whole file with the official version here [1].
> > >>
> > >> Thanks,
> > >> Justin
> > >>
> > >> 1. http://www.apache.org/licenses/LICENSE-2.0.txt
> > >>
> > >>
> > >>
> > >
> >
>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Jim Klucar <kl...@gmail.com>.
I have a script that pulls all the licenses from the node stuff. I guess we
only need the ones delivered, not the ones pulled down to make the build.
(Like gulp)
On Thursday, November 19, 2015, Santosh Marella <sm...@maprtech.com>
wrote:
> Incorporated feedback from IPMC and submitted a PR for review [1].
>
> @Justin - it'll be great if you can review the PR as well. Thanks!
>
> [1] https://github.com/apache/incubator-myriad/pull/49
>
> Santosh
>
> On Thu, Nov 19, 2015 at 1:02 AM, Santosh Marella <smarella@maprtech.com
> <javascript:;>>
> wrote:
>
> > Great. Thanks once again! We'll try to get the necessary changes
> > incorporated and prepare a new RC ASAP.
> >
> > Santosh
> >
> > On Thu, Nov 19, 2015 at 12:56 AM, Justin Mclean <
> justin@classsoftware.com <javascript:;>>
> > wrote:
> >
> >> Hi,
> >>
> >> > I didn't understand what's not correct in the appendix part of the
> >> LICENSE.
> >> > I compared the appendix section with that from the stock, and couldn't
> >> spot
> >> > a difference. Can you please clarify?
> >>
> >> Yep the text should be this:
> >> Copyright [yyyy] [name of copyright owner]
> >>
> >> Not this:
> >> Copyright 2012-present Apache Software Foundation
> >>
> >> Just replace the whole file with the official version here [1].
> >>
> >> Thanks,
> >> Justin
> >>
> >> 1. http://www.apache.org/licenses/LICENSE-2.0.txt
> >>
> >>
> >>
> >
>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
Incorporated feedback from IPMC and submitted a PR for review [1].
@Justin - it'll be great if you can review the PR as well. Thanks!
[1] https://github.com/apache/incubator-myriad/pull/49
Santosh
On Thu, Nov 19, 2015 at 1:02 AM, Santosh Marella <sm...@maprtech.com>
wrote:
> Great. Thanks once again! We'll try to get the necessary changes
> incorporated and prepare a new RC ASAP.
>
> Santosh
>
> On Thu, Nov 19, 2015 at 12:56 AM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> > I didn't understand what's not correct in the appendix part of the
>> LICENSE.
>> > I compared the appendix section with that from the stock, and couldn't
>> spot
>> > a difference. Can you please clarify?
>>
>> Yep the text should be this:
>> Copyright [yyyy] [name of copyright owner]
>>
>> Not this:
>> Copyright 2012-present Apache Software Foundation
>>
>> Just replace the whole file with the official version here [1].
>>
>> Thanks,
>> Justin
>>
>> 1. http://www.apache.org/licenses/LICENSE-2.0.txt
>>
>>
>>
>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
Great. Thanks once again! We'll try to get the necessary changes
incorporated and prepare a new RC ASAP.
Santosh
On Thu, Nov 19, 2015 at 12:56 AM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > I didn't understand what's not correct in the appendix part of the
> LICENSE.
> > I compared the appendix section with that from the stock, and couldn't
> spot
> > a difference. Can you please clarify?
>
> Yep the text should be this:
> Copyright [yyyy] [name of copyright owner]
>
> Not this:
> Copyright 2012-present Apache Software Foundation
>
> Just replace the whole file with the official version here [1].
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/licenses/LICENSE-2.0.txt
>
>
>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I didn't understand what's not correct in the appendix part of the LICENSE.
> I compared the appendix section with that from the stock, and couldn't spot
> a difference. Can you please clarify?
Yep the text should be this:
Copyright [yyyy] [name of copyright owner]
Not this:
Copyright 2012-present Apache Software Foundation
Just replace the whole file with the official version here [1].
Thanks,
Justin
1. http://www.apache.org/licenses/LICENSE-2.0.txt
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> (This may be a question for Jim Klucar (Myriad's UI developer), but if you
> are familiar with bootstrap's licensing, your guidance is much appreciated.)
Different versions of bootstrap have had different licenses you need to respect the version you have bundled not the current license.
> Also, the bootstrap-myriad.css[1] file mentions normalize.css as MIT
> licensed.
Looks MIT to me compare [1] with [2]. The principal here is [3].
Thanks,
Justin
1. https://github.com/necolas/normalize.css/blob/master/LICENSE.md <https://github.com/necolas/normalize.css/blob/master/LICENSE.md>
2. https://opensource.org/licenses/MIT <https://opensource.org/licenses/MIT>
3. http://www.apache.org/dev/licensing-howto.html#guiding-principle <http://www.apache.org/dev/licensing-howto.html#guiding-principle>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
Thanks Justin. Please see inline.
>For the LICENSE:
>- The appendix part of the LICENSE isn’t correct (i.e. the Apache licence
can apply to non ASF licensed software). Best to use the stock one and not
>modify it [1]
I didn't understand what's not correct in the appendix part of the LICENSE.
I compared the appendix section with that from the stock, and couldn't spot
a difference. Can you please clarify?
>- LICENSE mentions sub components but there are none listed
>- LICENSE is missing normalise.css which is MIT licensed see [2]
(This may be a question for Jim Klucar (Myriad's UI developer), but if you
are familiar with bootstrap's licensing, your guidance is much appreciated.)
The bootstrap-myriad.css[1] file shows it is Apache 2 licensed, but I see
v3.2.0 of bootstrap.css[2] is MIT licensed. I wonder which one is correct.
Also, the bootstrap-myriad.css[1] file mentions normalize.css as MIT
licensed. However, [3] doesn't return anything. I found [4], but it doesn't
seem to be MIT licensed. Just trying to figure out what should go into the
"sub components" section of Myriad's LICENSE file.
1.
https://github.com/apache/incubator-myriad/blob/master/myriad-scheduler/src/main/resources/webapp/css/bootstrap-myriad.css
2. https://github.com/twbs/bootstrap/blob/v3.2.0/LICENSE
3. http://git.io/normalize
4. https://github.com/necolas/normalize.css/blob/3.0.2/LICENSE.md
Santosh
On Wed, Nov 18, 2015 at 11:34 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > I've a few questions to ask regarding the update to LICENSE. I'll ask
> > them on the general@ thread.
>
> Ask away. Also happy to review it before it get to the incubator if you
> want.
>
> Thanks,
> Justin
>
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I've a few questions to ask regarding the update to LICENSE. I'll ask
> them on the general@ thread.
Ask away. Also happy to review it before it get to the incubator if you want.
Thanks,
Justin
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Santosh Marella <sm...@maprtech.com>.
Hi Justin,
I think we'll definitely need to prepare a new RC as the exclusion of the
jar from the tar.gz will force an update to the build instructions.
I've a few questions to ask regarding the update to LICENSE. I'll ask
them on the general@ thread.
Thanks for your guidance!
Regards,
Santosh
On Wed, Nov 18, 2015 at 10:02 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > We need to fix the LICENSE, exclude the gradle-wrapper.jar from the
> > tarball, and add build instructions (potentially also on how to download
> > gradle as well) in the README.
>
> IMO The jar would be the only blocking issue, but if you’re making another
> RC then you might as well fix the rest.
>
> Thanks,
> Justin
Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> We need to fix the LICENSE, exclude the gradle-wrapper.jar from the
> tarball, and add build instructions (potentially also on how to download
> gradle as well) in the README.
IMO The jar would be the only blocking issue, but if you’re making another RC then you might as well fix the rest.
Thanks,
Justin