You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/06/13 23:14:13 UTC
[jira] Created: (HADOOP-6825) FileStatus needs unit tests
FileStatus needs unit tests
---------------------------
Key: HADOOP-6825
URL: https://issues.apache.org/jira/browse/HADOOP-6825
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.22.0
Reporter: Rodrigo Schmidt
Assignee: Rodrigo Schmidt
Fix For: 0.22.0
We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887859#action_12887859 ]
Hudson commented on HADOOP-6825:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #324 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/324/])
HADOOP-6825. FileStatus needs unit tests. Contributed by Rodrigo Schmidt.
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887514#action_12887514 ]
Eli Collins commented on HADOOP-6825:
-------------------------------------
Thanks for the explanation.
+1 I'll commit this soon.
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888292#action_12888292 ]
Hudson commented on HADOOP-6825:
--------------------------------
Integrated in Hadoop-Common-trunk #392 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/392/])
HADOOP-6825. FileStatus needs unit tests. Contributed by Rodrigo Schmidt.
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881977#action_12881977 ]
Rodrigo Schmidt commented on HADOOP-6825:
-----------------------------------------
It also tests that an empty or partially completed FileStatus can be overwritten (problem with MAPREDUCE-1858). Simple and effective.
I think we should have at least some test for FileStatus inside hadoop-common.
At the moment, a complicated patch could obfuscate changes to FileStatus and break MAPREDUCE or HDFS.
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6825) FileStatus needs unit tests
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6825:
--------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I've committed this. Thanks Rodrigo!
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881948#action_12881948 ]
Eli Collins commented on HADOOP-6825:
-------------------------------------
I might be missing something but doesn't this just test that the FileStatus fields are persisted, ie that the writable code works? (ie a FileStatus can be written and read back).
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6825:
------------------------------------
Attachment: HADOOP-6825.0.patch
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878821#action_12878821 ]
Rodrigo Schmidt commented on HADOOP-6825:
-----------------------------------------
Eli, Jakob, can one of you review this patch. It's good to have tests for FileStatus in hadoop common (it's kind of bad to rely only on unit tests that are in HDFS or MAPREDUCE).
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878440#action_12878440 ]
Rodrigo Schmidt commented on HADOOP-6825:
-----------------------------------------
warnings seem to be coming from security files, not my patch:
[exec] [javadoc] Constructing Javadoc information...
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/KerberosName.java:31: warning: sun.security.krb5.Config is Sun prop\
rietary API and may be removed in a future release
[exec] [javadoc] import sun.security.krb5.Config;
[exec] [javadoc] ^
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/KerberosName.java:32: warning: sun.security.krb5.KrbException is Su\
n proprietary API and may be removed in a future release
[exec] [javadoc] import sun.security.krb5.KrbException;
[exec] [javadoc] ^
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/KerberosName.java:81: warning: sun.security.krb5.Config is Sun prop\
rietary API and may be removed in a future release
[exec] [javadoc] private static Config kerbConf;
[exec] [javadoc] ^
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:33: warning: sun.security.jgss.krb5.Krb5Util is S\
un proprietary API and may be removed in a future release
[exec] [javadoc] import sun.security.jgss.krb5.Krb5Util;
[exec] [javadoc] ^
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:34: warning: sun.security.krb5.Credentials is Sun\
proprietary API and may be removed in a future release
[exec] [javadoc] import sun.security.krb5.Credentials;
[exec] [javadoc] ^
[exec] [javadoc] /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:35: warning: sun.security.krb5.PrincipalName is S\
un proprietary API and may be removed in a future release
[exec] [javadoc] import sun.security.krb5.PrincipalName;
[exec] [javadoc] ^
[exec] [javadoc] ExcludePrivateAnnotationsStandardDoclet
[exec] [javadoc] Standard Doclet version 1.6.0_11
[exec] [javadoc] Building tree for all the packages and classes...
...
[exec] [javadoc] Generating /grid/0/hudson/hudson-slave/workspace/Hadoop-Patch-h4.grid.sp2.yahoo.net/trunk/build/docs/api/stylesheet.css...
[exec] [javadoc] 6 warnings
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886961#action_12886961 ]
Rodrigo Schmidt commented on HADOOP-6825:
-----------------------------------------
Any further comments? Can this be committed?
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6825) FileStatus needs unit tests
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878439#action_12878439 ]
Hadoop QA commented on HADOOP-6825:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12446991/HADOOP-6825.0.patch
against trunk revision 954165.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/583/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/583/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/583/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/583/console
This message is automatically generated.
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6825) FileStatus needs unit tests
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6825:
------------------------------------
Status: Patch Available (was: Open)
First patch
> FileStatus needs unit tests
> ---------------------------
>
> Key: HADOOP-6825
> URL: https://issues.apache.org/jira/browse/HADOOP-6825
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6825.0.patch
>
>
> We need some unit tests for FileStatus to prevent problems like those we recently had on HADOOP-6796 and MAPREDUCE-1858.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.