You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/10 09:19:24 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
KarmaGYZ opened a new pull request #13581:
URL: https://github.com/apache/flink/pull/13581
…is written to NettyMessage
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Explicitly get the ByteBuf length of all classes which is written to NettyMessage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fcc301fbb0d04ada457d2c39d325ede52cc0db8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-741513858
cc @curcur Rebased to the latest master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fcc301fbb0d04ada457d2c39d325ede52cc0db8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069)
* 05751c9777cba4c922adac2fb1f1c5a980b779da Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13581:
URL: https://github.com/apache/flink/pull/13581#discussion_r547804302
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -259,7 +259,7 @@ protected Object decode(ChannelHandlerContext ctx, ByteBuf in) throws Exception
static final byte ID = 0;
// receiver ID (16), sequence number (4), backlog (4), dataType (1), isCompressed (1), buffer size (4)
- static final int MESSAGE_HEADER_LENGTH = 16 + 4 + 4 + 1 + 1 + 4;
+ static final int MESSAGE_HEADER_LENGTH = InputChannelID.getByteBufLength() + Integer.BYTES + Integer.BYTES + Byte.BYTES + 1 + Integer.BYTES;
Review comment:
After a deeper investigation, I find that a `boolean` will be treated as a `byte` in netty. Will change it to `Byte.BYTES`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05751c9777cba4c922adac2fb1f1c5a980b779da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376)
* 1e187203b15559b08d15a0cca949ca15a8a3bafe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376)
* 1e187203b15559b08d15a0cca949ca15a8a3bafe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
}, {
"hash" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230",
"triggerID" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05751c9777cba4c922adac2fb1f1c5a980b779da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681)
* cd05d23ea1ac2a9283e03039a3791b1cc2df1a95 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fcc301fbb0d04ada457d2c39d325ede52cc0db8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069)
* 05751c9777cba4c922adac2fb1f1c5a980b779da UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-750000919
@KarmaGYZ , thanks for the PR.
I think the PR is quite safe to go, and I left a few minor comments.
Besides that, I have a few comments on the filed PR itself.
1. Maybe add a bit more detail the motivation of this change in the section of "What is the purpose of the change".
2. Would you please add a test for NettyMessage.java as well? No matter what, that's the main purpose of the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e187203b15559b08d15a0cca949ca15a8a3bafe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
}, {
"hash" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230",
"triggerID" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd05d23ea1ac2a9283e03039a3791b1cc2df1a95 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-714242065
cc @zhijiangW
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13581:
URL: https://github.com/apache/flink/pull/13581#discussion_r547722393
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -31,6 +31,7 @@
public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private static final int BYTEBUF_LEN = 16;
Review comment:
Would you please add a comment here, something like
"the length of two long types representing an `executionAttemptId`, with the lower part and the upper part taking one long type of length each" or something similar to explain where `16` comes from.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -259,7 +259,7 @@ protected Object decode(ChannelHandlerContext ctx, ByteBuf in) throws Exception
static final byte ID = 0;
// receiver ID (16), sequence number (4), backlog (4), dataType (1), isCompressed (1), buffer size (4)
- static final int MESSAGE_HEADER_LENGTH = 16 + 4 + 4 + 1 + 1 + 4;
+ static final int MESSAGE_HEADER_LENGTH = InputChannelID.getByteBufLength() + Integer.BYTES + Integer.BYTES + Byte.BYTES + 1 + Integer.BYTES;
Review comment:
why `isCompressed` (boolean) is hardcoded, while everything else is not?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/IntermediateResultPartitionID.java
##########
@@ -30,6 +30,7 @@
public class IntermediateResultPartitionID implements ResultID {
private static final long serialVersionUID = 1L;
+ private static final int BYTEBUF_LEN = 20;
Review comment:
similarly here, please add a comment.
Where are the extra 4 bytes coming from? partitionNum?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannelID.java
##########
@@ -28,6 +28,7 @@
public class InputChannelID extends AbstractID {
private static final long serialVersionUID = 1L;
+ private static final int BYTEBUF_LEN = 16;
Review comment:
similarly here, please add a comment to explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706518502
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c (Sat Oct 10 09:22:09 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e187203b15559b08d15a0cca949ca15a8a3bafe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383)
* fcc301fbb0d04ada457d2c39d325ede52cc0db8d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e187203b15559b08d15a0cca949ca15a8a3bafe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383)
* fcc301fbb0d04ada457d2c39d325ede52cc0db8d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-750016970
Thanks for the review, @curcur !
I've addressed your comments. Regarding the test, I think `NettyMessageServerSideSerializationTest` might be good enough as it covers the encoding and decoding logic for all the `NettyMessage`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-750796118
> Thanks for the review, @curcur !
> I've addressed your comments. Regarding the test, I think `NettyMessageServerSideSerializationTest` might be good enough as it covers the encoding and decoding logic for all the `NettyMessage`s.
That' true, thanks for pointing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #13581:
URL: https://github.com/apache/flink/pull/13581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13581:
URL: https://github.com/apache/flink/pull/13581#discussion_r547789257
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/IntermediateResultPartitionID.java
##########
@@ -30,6 +30,7 @@
public class IntermediateResultPartitionID implements ResultID {
private static final long serialVersionUID = 1L;
+ private static final int BYTEBUF_LEN = 20;
Review comment:
Yes, the extra 4 bytes come from the `partitionNum`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706518502
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 008f1e53122962ab10c83e548b60f0e7da5e6654 (Fri May 28 06:57:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
}, {
"hash" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230",
"triggerID" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"triggerType" : "PUSH"
}, {
"hash" : "008f1e53122962ab10c83e548b60f0e7da5e6654",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11427",
"triggerID" : "008f1e53122962ab10c83e548b60f0e7da5e6654",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd05d23ea1ac2a9283e03039a3791b1cc2df1a95 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230)
* 008f1e53122962ab10c83e548b60f0e7da5e6654 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11427)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
}, {
"hash" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05751c9777cba4c922adac2fb1f1c5a980b779da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681)
* cd05d23ea1ac2a9283e03039a3791b1cc2df1a95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
}, {
"hash" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8069",
"triggerID" : "fcc301fbb0d04ada457d2c39d325ede52cc0db8d",
"triggerType" : "PUSH"
}, {
"hash" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10681",
"triggerID" : "05751c9777cba4c922adac2fb1f1c5a980b779da",
"triggerType" : "PUSH"
}, {
"hash" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230",
"triggerID" : "cd05d23ea1ac2a9283e03039a3791b1cc2df1a95",
"triggerType" : "PUSH"
}, {
"hash" : "008f1e53122962ab10c83e548b60f0e7da5e6654",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "008f1e53122962ab10c83e548b60f0e7da5e6654",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd05d23ea1ac2a9283e03039a3791b1cc2df1a95 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11230)
* 008f1e53122962ab10c83e548b60f0e7da5e6654 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-750800553
Just one more thing: I think the description could be a bit more informative: something like this:
"""
Currently, the length of some header fields in NettyMessage is hardcoded: InputChannelID, ExecutionAttemptID, e.t.c.
So if we make some changes for such field, then we are not ware that it also needs to change the respective length for related netty messages component.
This PR explicitly get the ByteBuf length of all classes which is written to NettyMessage to avoid such problems.
"""
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13581: [FLINK-17331] Explicitly get the ByteBuf length of all classes which …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-706519397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376",
"triggerID" : "ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c",
"triggerType" : "PUSH"
}, {
"hash" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383",
"triggerID" : "1e187203b15559b08d15a0cca949ca15a8a3bafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef1039af70b46068bbbcd9ef4ea0c5cfd0583d5c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7376)
* 1e187203b15559b08d15a0cca949ca15a8a3bafe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org