You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Tom Graves <tg...@yahoo.com> on 2015/06/30 21:41:35 UTC

Re: Review Request 34494: Patch for KAFKA-2212

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34494/#review89940
-----------------------------------------------------------



core/src/main/scala/kafka/admin/AclCommand.scala (line 48)
<https://reviews.apache.org/r/34494/#comment142836>

    Needs to check for list opteration also else you can't do a list.


- Tom Graves


On May 20, 2015, 8:03 p.m., Parth Brahmbhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34494/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 8:03 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2212
>     https://issues.apache.org/jira/browse/KAFKA-2212
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2212: Add CLI for acl management of authorizer.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AclCommand.scala PRE-CREATION 
>   core/src/test/scala/unit/kafka/admin/AclCommandTest.scala PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34494/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Parth Brahmbhatt
> 
>