[GitHub] [calcite] chunweilei commented on a change in pull request #2438: [CALCITE-4650] TopDownRuleDriver.DeriveTrait.derive produces wrong AssertionError when registering new nodes (Vladimir Ozerov)

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #2438:
URL: https://github.com/apache/calcite/pull/2438#discussion_r659528281



##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -952,7 +952,8 @@ private void derive() {
         List<RelNode> relList = rel.derive(inputTraits);
         for (RelNode relNode : relList) {
           if (!planner.isRegistered(relNode)) {
-            planner.register(relNode, rel);
+            RelSubset relSubset = planner.register(relNode, rel);
+            assert relSubset.set == VolcanoPlanner.canonize(planner.getSubsetNonNull(rel)).set;
           }

Review comment:
       Could you please add a test case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org