[GitHub] [arrow-rs] mbrobbel commented on pull request #4653: Bump `workspace.rust-version` to `1.70.0` and use for all members

["mbrobbel (via GitHub)" <gi...@apache.org>]

mbrobbel commented on PR #4653:
URL: https://github.com/apache/arrow-rs/pull/4653#issuecomment-1667642369

   > Looks okay. Just one question. I think half only requires 1.70 since [v2.3.0](https://github.com/starkat99/half-rs/releases/tag/v2.3.0). But arrow-buffer uses half 2.1, cannot it be compiled using 1.62?
   
   `arrow-buffer` requires half `2.1` so that is `>=2.1.0, <3.0.0`, and the REAMDE of `half-rs` states: [*Requires Rust 1.70 or greater.* If you need support for older versions of Rust, use 1.x versions of this crate.](https://github.com/starkat99/half-rs/blob/cabfc74e2a48b44b4556780f9d1550dd50a708be/README.md?plain=1#L18-L19). We would have to use [tilde requirements](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#tilde-requirements) to pin to a minor version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org