You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/03/12 01:19:52 UTC
[jira] Created: (HBASE-1258) ganglia metrics for 'requests' is
confusing
ganglia metrics for 'requests' is confusing
-------------------------------------------
Key: HBASE-1258
URL: https://issues.apache.org/jira/browse/HBASE-1258
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.19.0
Reporter: ryan rawson
Fix For: 0.19.1, 0.20.0
the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1258:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed branch and trunk. Thanks for the patch Ryan.
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
> Attachments: HBASE-1258-1259-v2.patch, HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1258:
-------------------------------
Attachment: HBASE-1258-1259-v2.patch
oh im sorry, my bad. here is a fixed patch.
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
> Attachments: HBASE-1258-1259-v2.patch, HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1258:
-------------------------------
Status: Patch Available (was: Open)
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
> Attachments: HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reassigned HBASE-1258:
----------------------------------
Assignee: ryan rawson
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681386#action_12681386 ]
stack commented on HBASE-1258:
------------------------------
I applied to a clean trunk and when I tried to build I got this:
{code}
jspc:
[echo] Setting jspc.notRequired property. jsp pages generated once per ant session only
compile:
[javac] Compiling 285 source files to /Users/stack/checkouts/hbase/trunk.clean/build/classes
[javac] /Users/stack/checkouts/hbase/trunk.clean/src/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java:107: cannot find symbol
[javac] symbol : variable atomicIncrementTime
[javac] location: class org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
[javac] this.atomicIncrementTime.pushMetric(this.metricsRecord);
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
{code}
You might also check out src/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java. It has a toString method that summarizes regionserver metrics when called that is displayed in the regionserver UI. Does it include your metrics naming changes?
Good on you Ryan.
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
> Attachments: HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1258) ganglia metrics for 'requests' is
confusing
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1258:
-------------------------------
Attachment: HBASE-1258-1259.patch
this patch is for both 1258 and 1259
> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
> Key: HBASE-1258
> URL: https://issues.apache.org/jira/browse/HBASE-1258
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.19.1, 0.20.0
>
> Attachments: HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval. Which means the number is actually 'requests per interval' which is a config value in hbase.
> HBase should export 'requests/second' instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.