You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "KuroSaka TeruHiko (JIRA)" <ji...@apache.org> on 2017/05/25 23:18:04 UTC

[jira] [Comment Edited] (SOLR-9509) Fix problems in shell scripts reported by "shellcheck"

    [ https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025547#comment-16025547 ] 

KuroSaka TeruHiko edited comment on SOLR-9509 at 5/25/17 11:17 PM:
-------------------------------------------------------------------

This patch only includes mods to the bin/solr script. It has been lightly tested. Is there a test suite for the bin/solr script that I can run? (Kuro)


was (Author: tkurosaka):
This patch only includes mods to the bin/solr script. It has been lightly tested. Is there a test suite for the bin/solr script that I can run?

> Fix problems in shell scripts reported by "shellcheck"
> ------------------------------------------------------
>
>                 Key: SOLR-9509
>                 URL: https://issues.apache.org/jira/browse/SOLR-9509
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>            Reporter: Jan Høydahl
>              Labels: newdev
>         Attachments: bin_solr_shellcheck.txt, shellcheck_solr_20160915.txt, shellcheck_solr_bin_bash_20160915.txt, shellcheck_solr_bin_sh_20160915.txt, shellcheck_solr_usr_bin_env_bash_20160915.txt, SOLR-9509.patch
>
>
> Running {{shellcheck}} on our shell scripts reveal various improvements we should consider.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org