You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Rashko Rejmer (JIRA)" <ji...@apache.org> on 2008/03/31 13:24:28 UTC
[jira] Created: (OFBIZ-1731) Missing accounting UI labels
Missing accounting UI labels
----------------------------
Key: OFBIZ-1731
URL: https://issues.apache.org/jira/browse/OFBIZ-1731
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Rashko Rejmer
Priority: Trivial
Fix For: SVN trunk
Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1731) Missing accounting UI labels
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583668#action_12583668 ]
Pranay Pandey commented on OFBIZ-1731:
--------------------------------------
I have gone through your patch. You have done the right thing.
--
Thanks and Regards
Pranay Pandey
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1731) Missing accounting UI labels
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583654#action_12583654 ]
Rashko Rejmer commented on OFBIZ-1731:
--------------------------------------
The problem is that in the code AccountingVarianceReasonGlAccounts entry is used 5 times. You can check EditVarianceReasonGlAccounts screen, PartyAdminAssignTabBar menu. The VarianceReasonGlAccounts entry is used only once.
I thought that it will be better to add AccountingVarianceReasonGlAccounts entry than changing all the places where it is used.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1731) Missing accounting UI
labels
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583647#action_12583647 ]
pranaypa edited comment on OFBIZ-1731 at 3/31/08 4:42 AM:
---------------------------------------------------------------
Hello Rashko,
In AccountingUiLabels.xml an entry for "VarianceReasonGlAccounts" with value "Variance Reason Gl Accounts" is already there so i think no need to create another one.
--
Thanks and Regards
Pranay Pandey
was (Author: pranaypa):
Hello Rashko,
In AccountingUiLabels.xml an entry for "VarianceReasonGlAccounts" with value "Variance Reason Gl Accounts" is already there so i think no need to create another one.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1731) Missing accounting UI labels
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-1731:
---------------------------------
Comment: was deleted
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1731) Missing accounting UI labels
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1731.
----------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
Thanks Rashko and Pranay,
Pranay, your patch is in trunk revision: 643151. I checked also, it's all right.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1731) Missing accounting UI labels
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rashko Rejmer updated OFBIZ-1731:
---------------------------------
Attachment: AccountingUiLabels.patch
Patch for the issue.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1731) Missing accounting UI labels
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583665#action_12583665 ]
Pranay Pandey commented on OFBIZ-1731:
--------------------------------------
In that case I think we should edit the existing entry for value "Variance Reason Gl Accounts" which is already there instead of creating a new one and should make a change at the single place where the old entry has been used. Creating a new entry for this will increase redundancy.
--
Thanks and Regards
Pranay Pandey
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1731) Missing accounting UI labels
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583647#action_12583647 ]
Pranay Pandey commented on OFBIZ-1731:
--------------------------------------
Hello Rashko,
In AccountingUiLabels.xml an entry for "VarianceReasonGlAccounts" with value "Variance Reason Gl Accounts" is already there so i think no need to create another one.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1731) Missing accounting UI
labels
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583865#action_12583865 ]
jacques.le.roux edited comment on OFBIZ-1731 at 3/31/08 2:13 PM:
-----------------------------------------------------------------
Thanks Rashko and Pranay,
Rashko, your patch is in trunk revision: 643151. I checked also, it's all right.
was (Author: jacques.le.roux):
Thanks Rashko and Pranay,
Pranay, your patch is in trunk revision: 643151. I checked also, it's all right.
> Missing accounting UI labels
> ----------------------------
>
> Key: OFBIZ-1731
> URL: https://issues.apache.org/jira/browse/OFBIZ-1731
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: AccountingUiLabels.patch
>
>
> Missing labels: AccountingPartyAccountsSummary and AccountingVarianceReasonGlAccounts
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.