[GitHub] [maven] gnodet commented on a diff in pull request #1066: [MNG-6825] Consistently use commons-lang3 StringUtils

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #1066:
URL: https://github.com/apache/maven/pull/1066#discussion_r1141462379


##########
maven-xml-impl/pom.xml:
##########
@@ -39,12 +39,6 @@ under the License.
       <groupId>org.eclipse.sisu</groupId>
       <artifactId>org.eclipse.sisu.plexus</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.codehaus.plexus</groupId>
-      <artifactId>plexus-utils</artifactId>

Review Comment:
   That looks just wrong.  The change works only because sisu-plexus has a dependency on plexus-utils, but the plexus-utils dependency is a requiered dependency and should not be only transitive.
   This may be the same for other removal, but if there's any direct import, the dependency should be kept as a direct dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org