[GitHub] [spark] hvanhovell commented on a diff in pull request #40329: [SPARK-42710][CONNECT][PYTHON] Rename FrameMap proto to MapPartitions

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40329:
URL: https://github.com/apache/spark/pull/40329#discussion_r1129551866


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -774,11 +774,11 @@ message RepartitionByExpression {
   optional int32 num_partitions = 3;
 }
 
-message FrameMap {
-  // (Required) Input relation for a Frame Map API: mapInPandas, mapInArrow.
+message MapPartitions {

Review Comment:
   I prefer MapPartitions because that reflects what is actually does. Batch is IMO a property of the UDF used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org