You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/01/09 23:19:43 UTC

Review Request 16770: SENTRY-85: The JDBC connection from hive test framework should use a userid that's supported by default test resource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16770/
-----------------------------------------------------------

Review request for sentry and Shreepadma Venugopalan.


Bugs: SENTRY-85
    https://issues.apache.org/jira/browse/SENTRY-85


Repository: sentry


Description
-------

The test framework for Hive tests starts a HiveServer2 and checks if the server is in usable state. This is done by attempting a JDBC connection to the server. Currently it does that as user 'hive'. This user doesn't any privileges in the default policy file used in the tests.
Hive JDBC driver now implicitly switches the database to one specified by the connection URL (HIVE-4256). This causes leads to the test framework problem since the test user 'hive' doesn't have privileges to execute 'use default'
The patch makes the test connection as user 'foo' which has privileges to connect and switch to default database.


Diffs
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java badd523 

Diff: https://reviews.apache.org/r/16770/diff/


Testing
-------


Thanks,

Prasad Mujumdar


Re: Review Request 16770: SENTRY-85: The JDBC connection from hive test framework should use a userid that's supported by default test resource

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16770/#review31479
-----------------------------------------------------------

Ship it!


Ship It!

- Shreepadma Venugopalan


On Jan. 9, 2014, 10:19 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16770/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 10:19 p.m.)
> 
> 
> Review request for sentry and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-85
>     https://issues.apache.org/jira/browse/SENTRY-85
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The test framework for Hive tests starts a HiveServer2 and checks if the server is in usable state. This is done by attempting a JDBC connection to the server. Currently it does that as user 'hive'. This user doesn't any privileges in the default policy file used in the tests.
> Hive JDBC driver now implicitly switches the database to one specified by the connection URL (HIVE-4256). This causes leads to the test framework problem since the test user 'hive' doesn't have privileges to execute 'use default'
> The patch makes the test connection as user 'foo' which has privileges to connect and switch to default database.
> 
> 
> Diffs
> -----
> 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java badd523 
> 
> Diff: https://reviews.apache.org/r/16770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>