You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Pyasma (via GitHub)" <gi...@apache.org> on 2026/04/08 08:56:08 UTC

[PR] removing scroll into view to scroll to Bottom [airflow]

Pyasma opened a new pull request, #64889:
URL: https://github.com/apache/airflow/pull/64889

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #64757
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: prevent log loading from scrolling ancestor elements in task Logs tab [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #64889:
URL: https://github.com/apache/airflow/pull/64889#discussion_r3064325736


##########
airflow/www/static/js/utils/useOffsetTop.ts:
##########
@@ -21,7 +21,7 @@ import { debounce } from "lodash";
 import React, { useEffect, useState } from "react";
 
 // For an html element, keep it within view height by calculating the top offset and footer height
-const useOffsetTop = (contentRef: React.RefObject<HTMLElement>) => {
+const useOffsetTop = (contentRef: React.RefObject<HTMLElement | null>) => {

Review Comment:
   Nit: This seems unrelated to the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: prevent log loading from scrolling ancestor elements in task Logs tab [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma commented on code in PR #64889:
URL: https://github.com/apache/airflow/pull/64889#discussion_r3064620472


##########
airflow/www/static/js/utils/useOffsetTop.ts:
##########
@@ -21,7 +21,7 @@ import { debounce } from "lodash";
 import React, { useEffect, useState } from "react";
 
 // For an html element, keep it within view height by calculating the top offset and footer height
-const useOffsetTop = (contentRef: React.RefObject<HTMLElement>) => {
+const useOffsetTop = (contentRef: React.RefObject<HTMLElement | null>) => {

Review Comment:
   hey @pierrejeambrun these changes were suggested by Claude code I wasn't able to reproduce the issue on my end before 
   
   I just finished with the problem of reproducing 
   
   will push the changes soon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: prevent log loading from scrolling ancestor elements in task Logs tab [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma closed pull request #64889: fix: prevent log loading from scrolling ancestor elements in task Logs tab
URL: https://github.com/apache/airflow/pull/64889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: prevent log loading from scrolling ancestor elements in task Logs tab [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma commented on code in PR #64889:
URL: https://github.com/apache/airflow/pull/64889#discussion_r3064624098


##########
airflow/www/static/js/utils/useOffsetTop.ts:
##########
@@ -21,7 +21,7 @@ import { debounce } from "lodash";
 import React, { useEffect, useState } from "react";
 
 // For an html element, keep it within view height by calculating the top offset and footer height
-const useOffsetTop = (contentRef: React.RefObject<HTMLElement>) => {
+const useOffsetTop = (contentRef: React.RefObject<HTMLElement | null>) => {

Review Comment:
   sure i will also add the video to show the After and Before changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org