[GitHub] [samza] vjagadish1989 opened a new pull request #958: SAMZA-2117: Handle race condition in container launch due to incorrect AM accounting

[GitBox <gi...@apache.org>]

vjagadish1989 opened a new pull request #958: SAMZA-2117: Handle race condition in container launch due to incorrect AM accounting
URL: https://github.com/apache/samza/pull/958
 
 
   Steps involved when starting a Samza container:
   1. Issue a request to YARN to launch a container
   2. Record that container as "pending" launch. 
   3. Launch callback succeeds on a different thread : The callback looks at the "pending" container and marks it as "running".
   
   A race-condition in the above: If the main thread gets pre-empted between (1) and (2), the callback thread wouldn't see the container state as "pending" - hence, it wouldn't transition it to a "running" state.
   
   This PR fixes it by flipping (1) and (2) - ie., record the intent prior to issuing the launch request.
   Added an unit test - refactored existing tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services