You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by happy2discover <gi...@git.apache.org> on 2016/11/21 02:28:35 UTC

[GitHub] cordova-plugin-screen-orientation pull request #5: change console.log to sho...

GitHub user happy2discover opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/5

    change console.log to show ScreenOrientation

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    before:
    Orientation is [object ScreenOrientation]
    after:
    Orientation is ScreenOrientation
                              angle: 90
                              onchange: null
                              type: "landscape-primary"
                           __proto__: EventTarget

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/happy2discover/cordova-plugin-screen-orientation patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 668585717c0eb7bd5298a79a7a71ab38a3d92bf8
Author: Yang Zhonghua <ha...@users.noreply.github.com>
Date:   2016-11-21T02:28:15Z

    change console.log to show ScreenOrientation
    
    before:
    Orientation is [object ScreenOrientation]
    after:
    Orientation is ScreenOrientation
                              angle: 90
                              onchange: null
                              type: "landscape-primary"
                           __proto__: EventTarget

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #5: change console.log to show Scree...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/5
  
    Technically, this does not change anything. But it does point out that there is an issue in how toString is handled by the orientation object.  Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #5: change console.log to sho...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org