You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/02 02:28:51 UTC
[GitHub] [incubator-gobblin] vikrambohra opened a new pull request #3021: [GOBBLIN-1176] create gobblin-all module resolving full dependency tree
vikrambohra opened a new pull request #3021:
URL: https://github.com/apache/incubator-gobblin/pull/3021
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3021: [GOBBLIN-1176] create gobblin-all module resolving full dependency tree
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3021:
URL: https://github.com/apache/incubator-gobblin/pull/3021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3021: [GOBBLIN-1176] create gobblin-all module resolving full dependency tree
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3021:
URL: https://github.com/apache/incubator-gobblin/pull/3021#issuecomment-637276512
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=h1) Report
> Merging [#3021](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/76d5a3bab26b471b722787d735f3df696beecd68&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `61.34%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3021 +/- ##
============================================
+ Coverage 45.63% 45.73% +0.09%
- Complexity 9230 9293 +63
============================================
Files 1947 1951 +4
Lines 73968 74222 +254
Branches 8180 8213 +33
============================================
+ Hits 33757 33943 +186
- Misses 37049 37105 +56
- Partials 3162 3174 +12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/cluster/ContainerHealthCheckException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoQ2hlY2tFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gobblin/cluster/HelixAssignedParticipantCheck.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhBc3NpZ25lZFBhcnRpY2lwYW50Q2hlY2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `7.14% <0.00%> (+0.09%)` | `9.00 <0.00> (ø)` | |
| [.../couchbase/writer/CouchbaseEnvironmentFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlRW52aXJvbm1lbnRGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh) | `1.34% <0.00%> (-0.01%)` | `1.00 <0.00> (ø)` | |
| [...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==) | `15.84% <0.00%> (+2.16%)` | `2.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `60.36% <ø> (ø)` | `37.00 <0.00> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <ø> (ø)` | `14.00 <0.00> (ø)` | |
| ... and [73 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=footer). Last update [ad2da14...434a6e1](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] jhsenjaliya commented on pull request #3021: [GOBBLIN-1176] create gobblin-all module resolving full dependency tree
Posted by GitBox <gi...@apache.org>.
jhsenjaliya commented on pull request #3021:
URL: https://github.com/apache/incubator-gobblin/pull/3021#issuecomment-637942090
Hi @vikrambohra, not sure about the context here. but can this be done with gobblin-flavor as well ? as I was thinking about this earlier. would be good to know. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3021: [GOBBLIN-1176] create gobblin-all module resolving full dependency tree
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3021:
URL: https://github.com/apache/incubator-gobblin/pull/3021#issuecomment-637276512
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=h1) Report
> Merging [#3021](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/76d5a3bab26b471b722787d735f3df696beecd68&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `61.34%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3021 +/- ##
============================================
+ Coverage 45.63% 45.73% +0.09%
- Complexity 9230 9293 +63
============================================
Files 1947 1951 +4
Lines 73968 74222 +254
Branches 8180 8213 +33
============================================
+ Hits 33757 33943 +186
- Misses 37049 37105 +56
- Partials 3162 3174 +12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/cluster/ContainerHealthCheckException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoQ2hlY2tFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gobblin/cluster/HelixAssignedParticipantCheck.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhBc3NpZ25lZFBhcnRpY2lwYW50Q2hlY2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `7.14% <0.00%> (+0.09%)` | `9.00 <0.00> (ø)` | |
| [.../couchbase/writer/CouchbaseEnvironmentFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlRW52aXJvbm1lbnRGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh) | `1.34% <0.00%> (-0.01%)` | `1.00 <0.00> (ø)` | |
| [...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==) | `15.84% <0.00%> (+2.16%)` | `2.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `60.36% <ø> (ø)` | `37.00 <0.00> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <ø> (ø)` | `14.00 <0.00> (ø)` | |
| ... and [73 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3021/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=footer). Last update [ad2da14...434a6e1](https://codecov.io/gh/apache/incubator-gobblin/pull/3021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org