You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Nick Dimiduk (JIRA)" <ji...@apache.org> on 2015/01/07 18:00:37 UTC

[jira] [Commented] (HTRACE-57) Fix LocalFileSpanReceiver to avoid adding irrelevant wrapper object

    [ https://issues.apache.org/jira/browse/HTRACE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267866#comment-14267866 ] 

Nick Dimiduk commented on HTRACE-57:
------------------------------------

Fix for the stated issue looks good. Are the other changes intentional?

> Fix LocalFileSpanReceiver to avoid adding irrelevant wrapper object
> -------------------------------------------------------------------
>
>                 Key: HTRACE-57
>                 URL: https://issues.apache.org/jira/browse/HTRACE-57
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-57.001.patch
>
>
> Currently, LocalFileSpanReceiver adds a "wrapper" around the span it writes:
> {code}
> {"span":{"i":"0b09dac41100f489","s":"a3090d1e915c0723","b":1420647781123,"e":1420647781124,"d":"testWriteToLocalFile","r":"jar","p":[]}}
> {code}
> It should just write the object itself with no wrapper.  This was regressed by my change in HTRACE-32... we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)