You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/07 19:46:44 UTC
[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #4090: STM32G43XX Analog Comparator
hartmannathan commented on a change in pull request #4090:
URL: https://github.com/apache/incubator-nuttx/pull/4090#discussion_r665657362
##########
File path: arch/arm/src/stm32/stm32_comp.h
##########
@@ -192,5 +84,4 @@ FAR struct comp_dev_s *stm32_compinitialize(int intf);
#endif
#endif /* __ASSEMBLY__ */
-#endif /* CONFIG_STM23_COMP */
-#endif /* __ARCH_ARM_SRC_STM32_STM32_COMP_H */
+#endif /* __ARCH_ARM_SRC_STM32_STM32_COMP_H */
Review comment:
Recommend adding newline at end of file.
##########
File path: arch/arm/src/stm32/stm32_comp.c
##########
@@ -34,6 +46,8 @@
Review comment:
The above comment is now incorrect.
I recommend:
```
/* This file is only a thin shell that includes the correct COMP
* implementation. At this moment STM32 COMP IP versions 1 and 2 are
* supported.
* - STM32 COMP IP version 1: SMT32F33XX
* - STM32 COMP IP version 2: SMT32G4XXX
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org