[GitHub] [spark] HyukjinKwon commented on a change in pull request #27897: [SPARK-31113][SQL] Add SHOW VIEWS command

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27897: [SPARK-31113][SQL] Add SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r394766551
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
 ##########
 @@ -363,6 +370,15 @@ private[client] class Shim_v0_12 extends Shim with Logging {
     conf.getIntVar(HiveConf.ConfVars.METASTORE_CLIENT_CONNECT_RETRY_DELAY) * 1000L
   }
 
+  override def getTablesByType(
+      hive: Hive,
+      dbName: String,
+      pattern: String,
+      tableType: TableType): Seq[String] = {
+    throw new UnsupportedOperationException("Hive 2.2 and lower versions don't support " +
 
 Review comment:
   Can we implement without adding the method in `HiveShim` first, and improve with using `listTables`? Seems like it's not a must given my reading. Adding a method here requires to test in multiple profiles with multiple versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org