You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/04/18 16:00:22 UTC
Re: Review Request 56935: Fix for unnecessary object serializations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56935/#review172213
-----------------------------------------------------------
Ship it!
LGTM. We should ship it before it gets stale :-)
- Stephan Erb
On Feb. 22, 2017, 8:34 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56935/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 8:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Methodology: I attached a profiler (YourKit) to Aurora in one of test clusters (where very minimal workload was being applied to the scheduler). Looking at object allocation rates, `Webhook` and `ResourceType` stood out. Based on the two cases above, I looked itno `requireNonNull()` and `LOG.xxx()` methods in the code base to find potentially misbehaving statements.
>
> This patch provides a fix for some unnecessary object serilizations that happen on high frequency execution paths and contribute to scheduler's high object creation rate. Due to low scheduler workload at the time observation, this list is not exhaustive.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/Webhook.java 3e8e38abe29766f6fcf08707fba5df402c96a257
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java c88428412d69e4202e7cceb1b608dc1809a9ccc0
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java a649a6e3d2f2d0aeaf6d7ac704ed24911c310a1e
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d89e715b1b08faf95f8b5788c9c28cbbb33af093
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
>
> Diff: https://reviews.apache.org/r/56935/diff/1/
>
>
> Testing
> -------
>
> ```./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>