You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "ni-ze (via GitHub)" <gi...@apache.org> on 2023/05/15 02:24:58 UTC

[GitHub] [rocketmq-streams] ni-ze commented on issue #290: The logic of watermark judging whether to solve the data may result in missing data.

ni-ze commented on issue #290:
URL: https://github.com/apache/rocketmq-streams/issues/290#issuecomment-1547105334

   The watermark is based on the endTime of window:
   ![image](https://github.com/apache/rocketmq-streams/assets/31175234/a8d03f5b-a1ee-4125-97a8-bc040aaf4ae4)
   
   But I agree, commit(store) watermark into RocksDB should only happened after window fired.
   
   store watermark when data coming is not correct.
   ![image](https://github.com/apache/rocketmq-streams/assets/31175234/900619f8-1d85-4626-b23e-1b74b9e55b84)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org