[jira] Commented: (HADOOP-5420) Support killing of process groups in LinuxTaskController binary

["Vinod K V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716174#action_12716174 ] 

Vinod K V commented on HADOOP-5420:
-----------------------------------

Looked at the patch. Some comments, hopefully the last lap..

task-controller.h:
 - Plz knock off the un-used error codes
   OUT_OF_MEMORY, //5
   INVALID_TT_PID, //11

task-controller.c
 -  In check_tt_root(), the line _"const char ** mapred_local_dir = get_values(TT_SYS_DIR_KEY);"_ has to be moved after NULL check for tt_root, because otherwise there is a memory leak.
 - Plz add a comment as to why we do check_tt_root before changing user in run_task_as_user
 - Fix comments of kill_user_task. No need of the mention for tt_root here any longer.

TaskController.java
 - (Don't hit me!) Rename TaskController.cleanupTaskJvm() to destroyTaskJvm(). This is consistent with terminology in ProcessTree.java

> Support killing of process groups in LinuxTaskController binary
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5420
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: hadoop-5420-1.patch, hadoop-5420-2.patch, hadoop-5420-3.patch, hadoop-5420-4.patch, hadoop-5420-5.patch, hadoop-5420-6.patch, hadoop-5420-7.patch, hadoop-5420-8.patch, hadoop-5420-9.patch, hadoop-5420.patch
>
>
> Support setsid based kill in LinuxTaskController.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.