[GitHub] [spark] imback82 commented on a change in pull request #34096: [SPARK-36841][SQL] Add ansi syntax `set catalog xxx` to change the current catalog

[GitBox <gi...@apache.org>]

imback82 commented on a change in pull request #34096:
URL: https://github.com/apache/spark/pull/34096#discussion_r717748633



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
##########
@@ -278,6 +278,11 @@ case class InsertIntoStatement(
  */
 case class UseStatement(isNamespaceSet: Boolean, nameParts: Seq[String]) extends LeafParsedStatement
 
+/**
+ * A SetCatalog statement, as parsed from SQL.
+ */
+case class SetCatalogStatement(nameParts: Option[String]) extends LeafParsedStatement

Review comment:
       Can't we just make this `nameParts: String` without `Option`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org