You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/14 22:32:53 UTC

[GitHub] [pinot] Jackie-Jiang commented on pull request #8341: Canonicalize the function name for SQL parser

Jackie-Jiang commented on pull request #8341:
URL: https://github.com/apache/pinot/pull/8341#issuecomment-1067367576


   @richardstartin Can you please take another look? I have to change several tests to accommodate with the lower case change, but that should be able to save a lot of unnecessary extra string allocations since we use lower case to canonicalize function names in all other places.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org