You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ps...@apache.org on 2019/05/30 16:41:42 UTC

[hbase] branch branch-2.1 updated: HBASE-22487 getMostLoadedRegions is unused

This is an automated email from the ASF dual-hosted git repository.

psomogyi pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new 9029130  HBASE-22487 getMostLoadedRegions is unused
9029130 is described below

commit 9029130ba059a8ee063469c91cd1bf64c5db4e88
Author: Clay Baenziger <cw...@clayb.net>
AuthorDate: Mon May 27 21:57:15 2019 -0400

    HBASE-22487 getMostLoadedRegions is unused
    
    Signed-off-by: Wellington Chevreuil <we...@gmail.com>
    Signed-off-by: Peter Somogyi <ps...@apache.org>
---
 .../hadoop/hbase/regionserver/HRegionServer.java    | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index 36e0977..446a19b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -2845,27 +2845,6 @@ public class HRegionServer extends HasThread implements
     return this.compactSplitThread;
   }
 
-  /**
-   * Get the top N most loaded regions this server is serving so we can tell the
-   * master which regions it can reallocate if we're overloaded. TODO: actually
-   * calculate which regions are most loaded. (Right now, we're just grabbing
-   * the first N regions being served regardless of load.)
-   */
-  protected RegionInfo[] getMostLoadedRegions() {
-    ArrayList<RegionInfo> regions = new ArrayList<>();
-    for (Region r : onlineRegions.values()) {
-      if (!r.isAvailable()) {
-        continue;
-      }
-      if (regions.size() < numRegionsToReport) {
-        regions.add(r.getRegionInfo());
-      } else {
-        break;
-      }
-    }
-    return regions.toArray(new RegionInfo[regions.size()]);
-  }
-
   @Override
   public Leases getLeases() {
     return leases;