[GitHub] [solr] dsmiley commented on a diff in pull request #852: SOLR-15739: Convert v2 GET /get API to annotations (#677)

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #852:
URL: https://github.com/apache/solr/pull/852#discussion_r873296358


##########
solr/core/src/java/org/apache/solr/handler/RealTimeGetHandler.java:
##########
@@ -51,7 +53,7 @@ public String getDescription() {
 
   @Override
   public Collection<Api> getApis() {
-    return ApiBag.wrapRequestHandlers(this, "core.RealtimeGet");
+    return Lists.newArrayList(AnnotatedApi.getApis(new RealTimeGetAPI(this)));

Review Comment:
   Please avoid Guava for this; I think you can simply use List.of even though it's immutable (probably a good thing).  I know this PR is merged; my comment is for your future consideration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org