You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/15 00:15:32 UTC
[GitHub] [rocketmq] fuyou001 opened a new pull request, #5323: [ISSUE #5322] improving SDK topic route availability
fuyou001 opened a new pull request, #5323:
URL: https://github.com/apache/rocketmq/pull/5323
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415
##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
*/
private boolean enableControllerInNamesrv = false;
+ private volatile boolean needWaitForService = true;
+
+ private int waitSecondsForService = 45;
Review Comment:
Hard-coded value is not optimal, because users might adjust the interval of broker registration... Would it be better to set it to alpha * interval_of_broker_registration, where alpha is somewhat 1.5 or 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fuyou001 commented on pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
fuyou001 commented on PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#issuecomment-1280328449
> @fuyou001 A few test cases failed after this change...Please look into them
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fuyou001 commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
fuyou001 commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996639223
##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
*/
private boolean enableControllerInNamesrv = false;
+ private volatile boolean needWaitForService = true;
+
+ private int waitSecondsForService = 45;
Review Comment:
broker config and namesrv config is independence，it's hard to get broker interval_of_broker_registration in namesrv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#issuecomment-1280205376
@fuyou001 A few test cases failed after this change...Please look into them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415
##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
*/
private boolean enableControllerInNamesrv = false;
+ private volatile boolean needWaitForService = true;
+
+ private int waitSecondsForService = 45;
Review Comment:
Hard-coded value is not optimal, users might adjust the interval of broker registration... Would it be better to set it to alpha * interval_of_broker_registration, where alpha is somewhat 1.5 or 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fuyou001 commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability
Posted by GitBox <gi...@apache.org>.
fuyou001 commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996639223
##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
*/
private boolean enableControllerInNamesrv = false;
+ private volatile boolean needWaitForService = true;
+
+ private int waitSecondsForService = 45;
Review Comment:
broker config and namesrv config is independence，it's hard to get broker config nterval_of_broker_registration in namesrv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org