[jira] [Comment Edited] (CRUNCH-225) Scala 2.10 support

["Micah Whitacre (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820901#comment-13820901 ] 

Micah Whitacre edited comment on CRUNCH-225 at 11/13/13 3:51 AM:
-----------------------------------------------------------------

Attached is a patch which adds a "scala-2.10" and "scala-2.9.2" profile to the crunch-scrunch project.  By default the scala-2.9.2 profile will be enabled.

The additional changes have to do with the fact that JunitSuite is no longer a mixin type and needs to be extended in the newer version of scalatest.  This requires us to stop using CrunchTestSupport and also the Rule annotation doesn't work with Scala.  

If you build the project with either "mvn clean install" or "mvn clean install -P scala-2.10" builds should pass.

I'm know the patch is comprehensive enough to be applied just yet.  The outstanding work I know of is:

1. There are a number of compile warnings when building the project due to its use of ClassManifest which was deprecated in Scala 2.10  So it'd be nice to get rid of those warnings.
2. I didn't change the sbt file at all.  It doesn't look like the file is used when building so I wonder if we could just delete the file to avoid the dual maintenance between the Maven POM and sbt file.
3. I haven't tracked down any additional changes that might need to be made to support releasing 2.9.2 and 2.10 easily.  Suggestions on what this might be would be helpful.


was (Author: mkwhitacre):
Attached is a patch which adds a "scala-2.10" and "scala-2.9.2" profile to the crunch-scala project.  By default the scala-2.9.2 profile will be enabled.

The additional changes have to do with the fact that JunitSuite is no longer a mixin type and needs to be extended in the newer version of scalatest.  This requires us to stop using CrunchTestSupport and also the Rule annotation doesn't work with Scala.  

If you build the project with either "mvn clean install" or "mvn clean install -P scala-2.10" builds should pass.

I'm not the patch is comprehensive enough to be applied just yet.  The outstanding work I know of is:

1. There are a number of compile warnings when building the project due to its use of ClassManifest which was deprecated in Scala 2.10  So it'd be nice to get rid of those warnings.
2. I didn't change the sbt file at all.  It doesn't look like the file is used when building so I wonder if we could just delete the file to avoid the dual maintenance between the Maven POM and sbt file.
3. I haven't tracked down any additional changes that might need to be made to support releasing 2.9.2 and 2.10 easily.  Suggestions on what this might be would be helpful.

> Scala 2.10 support
> ------------------
>
>                 Key: CRUNCH-225
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-225
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Scrunch
>    Affects Versions: 0.7.0
>            Reporter: Jan Prach
>             Fix For: 0.9.0
>
>         Attachments: 0001-CRUNCH-225-Scala-2.10-support.patch, CRUNCH-225.patch
>
>
> Scala 2.10 is mainstream. It was released half a year ago. It should be supported and default.



--
This message was sent by Atlassian JIRA
(v6.1#6144)