[GitHub] [incubator-flagon-useralejs] poorejc commented on pull request #323: Composed path

[GitBox <gi...@apache.org>]

poorejc commented on PR #323:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/323#issuecomment-1365557602

   @Jyyjy Thanks! This is great and timely. I'm going to do some additional integration tests on this, and see if everything looks solid all the way through the pipeline.
   
   RE: "A better solution for buildPath would look something like this:
   `export function buildPath(e) {
   if (typeof e == "Event") {
   let path = e.composedPath();
   return selectorizePath(path);
   }
   
   return null;
   }`
   
   But I couldn't figure out how to properly test that. "
   
   Let's get that up to @dev and see what someone like @UncleGedd thinks--he helped to do a massive overhaul of our test framework not too long ago.
   
   Again, many thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org